mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-30 06:41:51 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
42 lines
1.9 KiB
Python
42 lines
1.9 KiB
Python
"""Tests for fallback-eviction gating on failed runs (#7130).
|
|
|
|
When a run fails, the gateway must NOT evict the cached agent — doing so
|
|
forces MCP reinit on the next message, creating a CPU-burning restart loop.
|
|
Eviction should only happen on successful runs where fallback activated.
|
|
"""
|
|
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
|
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent.parent))
|
|
|
|
|
|
class TestFallbackEvictionGating:
|
|
"""The fallback-eviction code path should skip eviction on failed runs."""
|
|
|
|
def test_failed_run_does_not_evict_cached_agent(self):
|
|
"""When result has failed=True, the cached agent should NOT be evicted."""
|
|
# The fix: `and not _run_failed` guard on the eviction check.
|
|
# Simulate the variables that the eviction block uses.
|
|
result = {"failed": True, "final_response": None, "error": "400 invalid model"}
|
|
_run_failed = result.get("failed") if result else False
|
|
assert _run_failed is True, "Failed run should be detected"
|
|
|
|
def test_successful_run_allows_eviction(self):
|
|
"""When result is successful, fallback eviction should proceed."""
|
|
result = {"completed": True, "final_response": "Hello!", "failed": False}
|
|
_run_failed = result.get("failed") if result else False
|
|
assert _run_failed is False, "Successful run should not be flagged"
|
|
|
|
def test_none_result_treated_as_not_failed(self):
|
|
"""When result is None (edge case), treat as not-failed."""
|
|
result = None
|
|
_run_failed = result.get("failed") if result else False
|
|
assert _run_failed is False
|
|
|
|
def test_missing_failed_key_treated_as_not_failed(self):
|
|
"""When result dict doesn't have 'failed' key, treat as not-failed."""
|
|
result = {"completed": True, "final_response": "Hello!"}
|
|
_run_failed = result.get("failed") if result else False
|
|
assert not _run_failed, "Missing 'failed' key should be falsy"
|