mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-30 06:41:51 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
94 lines
4 KiB
Python
94 lines
4 KiB
Python
"""Tests for the auto-continue feature (#4493).
|
|
|
|
When the gateway restarts mid-agent-work, the session transcript ends on a
|
|
tool result that the agent never processed. The auto-continue logic detects
|
|
this and prepends a system note to the next user message so the model
|
|
finishes the interrupted work before addressing the new input.
|
|
"""
|
|
|
|
|
|
|
|
def _simulate_auto_continue(agent_history: list, user_message: str) -> str:
|
|
"""Reproduce the auto-continue injection logic from _run_agent().
|
|
|
|
This mirrors the exact code in gateway/run.py so we can test the
|
|
detection and message transformation without spinning up a full
|
|
gateway runner.
|
|
"""
|
|
message = user_message
|
|
if agent_history and agent_history[-1].get("role") == "tool":
|
|
message = (
|
|
"[System note: Your previous turn was interrupted before you could "
|
|
"process the last tool result(s). The conversation history contains "
|
|
"tool outputs you haven't responded to yet. Please finish processing "
|
|
"those results and summarize what was accomplished, then address the "
|
|
"user's new message below.]\n\n"
|
|
+ message
|
|
)
|
|
return message
|
|
|
|
|
|
class TestAutoDetection:
|
|
"""Test that trailing tool results are correctly detected."""
|
|
|
|
def test_trailing_tool_result_triggers_note(self):
|
|
history = [
|
|
{"role": "user", "content": "deploy the app"},
|
|
{"role": "assistant", "content": None, "tool_calls": [
|
|
{"id": "call_1", "function": {"name": "terminal", "arguments": "{}"}}
|
|
]},
|
|
{"role": "tool", "tool_call_id": "call_1", "content": "deployed successfully"},
|
|
]
|
|
result = _simulate_auto_continue(history, "what happened?")
|
|
assert "[System note:" in result
|
|
assert "interrupted" in result
|
|
assert "what happened?" in result
|
|
|
|
def test_trailing_assistant_message_no_note(self):
|
|
history = [
|
|
{"role": "user", "content": "hello"},
|
|
{"role": "assistant", "content": "Hi there!"},
|
|
]
|
|
result = _simulate_auto_continue(history, "how are you?")
|
|
assert "[System note:" not in result
|
|
assert result == "how are you?"
|
|
|
|
def test_empty_history_no_note(self):
|
|
result = _simulate_auto_continue([], "hello")
|
|
assert result == "hello"
|
|
|
|
def test_trailing_user_message_no_note(self):
|
|
"""Shouldn't happen in practice, but ensure no false positive."""
|
|
history = [
|
|
{"role": "user", "content": "hello"},
|
|
]
|
|
result = _simulate_auto_continue(history, "hello again")
|
|
assert result == "hello again"
|
|
|
|
def test_multiple_tool_results_still_triggers(self):
|
|
"""Multiple tool calls in a row — last one is still role=tool."""
|
|
history = [
|
|
{"role": "user", "content": "search and read"},
|
|
{"role": "assistant", "content": None, "tool_calls": [
|
|
{"id": "call_1", "function": {"name": "search", "arguments": "{}"}},
|
|
{"id": "call_2", "function": {"name": "read", "arguments": "{}"}},
|
|
]},
|
|
{"role": "tool", "tool_call_id": "call_1", "content": "found it"},
|
|
{"role": "tool", "tool_call_id": "call_2", "content": "file content here"},
|
|
]
|
|
result = _simulate_auto_continue(history, "continue")
|
|
assert "[System note:" in result
|
|
|
|
def test_original_message_preserved_after_note(self):
|
|
"""The user's actual message must appear after the system note."""
|
|
history = [
|
|
{"role": "assistant", "content": None, "tool_calls": [
|
|
{"id": "c1", "function": {"name": "t", "arguments": "{}"}}
|
|
]},
|
|
{"role": "tool", "tool_call_id": "c1", "content": "done"},
|
|
]
|
|
result = _simulate_auto_continue(history, "now do X")
|
|
# System note comes first, then user's message
|
|
note_end = result.index("]\n\n")
|
|
user_msg_start = result.index("now do X")
|
|
assert user_msg_start > note_end
|