mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-30 06:41:51 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
62 lines
2 KiB
Python
62 lines
2 KiB
Python
from unittest.mock import MagicMock, patch
|
|
from hermes_cli.plugins import VALID_HOOKS, PluginManager
|
|
from cli import HermesCLI
|
|
|
|
|
|
def test_session_hooks_in_valid_hooks():
|
|
"""Verify on_session_finalize and on_session_reset are registered as valid hooks."""
|
|
assert "on_session_finalize" in VALID_HOOKS
|
|
assert "on_session_reset" in VALID_HOOKS
|
|
|
|
|
|
@patch("hermes_cli.plugins.invoke_hook")
|
|
def test_session_finalize_on_reset(mock_invoke_hook):
|
|
"""Verify on_session_finalize fires when /new or /reset is used."""
|
|
cli = HermesCLI()
|
|
cli.agent = MagicMock()
|
|
cli.agent.session_id = "test-session-id"
|
|
|
|
# Simulate /new command which triggers on_session_finalize for the old session
|
|
cli.new_session(silent=True)
|
|
|
|
# Check if on_session_finalize was called for the old session
|
|
mock_invoke_hook.assert_any_call(
|
|
"on_session_finalize", session_id="test-session-id", platform="cli"
|
|
)
|
|
# Check if on_session_reset was called for the new session
|
|
mock_invoke_hook.assert_any_call(
|
|
"on_session_reset", session_id=cli.session_id, platform="cli"
|
|
)
|
|
|
|
|
|
@patch("hermes_cli.plugins.invoke_hook")
|
|
def test_session_finalize_on_cleanup(mock_invoke_hook):
|
|
"""Verify on_session_finalize fires during CLI exit cleanup."""
|
|
import cli as cli_mod
|
|
|
|
mock_agent = MagicMock()
|
|
mock_agent.session_id = "cleanup-session-id"
|
|
cli_mod._active_agent_ref = mock_agent
|
|
cli_mod._cleanup_done = False
|
|
|
|
cli_mod._run_cleanup()
|
|
|
|
mock_invoke_hook.assert_any_call(
|
|
"on_session_finalize", session_id="cleanup-session-id", platform="cli"
|
|
)
|
|
|
|
|
|
@patch("hermes_cli.plugins.invoke_hook")
|
|
def test_hook_errors_are_caught(mock_invoke_hook):
|
|
"""Verify hook exceptions are caught and don't crash the agent."""
|
|
mgr = PluginManager()
|
|
|
|
# Register a hook that raises
|
|
def bad_callback(**kwargs):
|
|
raise Exception("Hook failed")
|
|
|
|
mgr._hooks["on_session_finalize"] = [bad_callback]
|
|
|
|
# This should not raise
|
|
results = mgr.invoke_hook("on_session_finalize", session_id="test", platform="cli")
|
|
assert results == []
|