mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
70925363b6
Copilot review on #14968 caught that the early returns gated on the global `detailsMode === 'hidden'` short-circuited every render path before sectionMode() got a chance to apply per-section overrides — so `details_mode: hidden` + `sections.tools: expanded` was silently a no-op. Three call sites had the same bug shape; all now key off the resolved section modes: - ToolTrail: replace the `detailsMode === 'hidden'` early return with an `allHidden = every section resolved to hidden` check. When that's true, fall back to the floating-alert backstop (errors/warnings) so quiet-mode users aren't blind to ambient failures, and update the comment block to match the actual condition. - messageLine.tsx: drop the same `detailsMode === 'hidden'` pre-check on `msg.kind === 'trail'`; only skip rendering the wrapper when every section resolves to hidden (`SECTION_NAMES.some(...) !== 'hidden'`). - useMainApp.ts: rebuild `showProgressArea` around `anyPanelVisible` instead of branching on the global mode. This also fixes the suppressed Copilot concern about an empty wrapper Box rendering above the streaming area when ToolTrail returns null. Regression test in details.test.ts pins the override-escapes-hidden behaviour for tools/thinking/activity. 271/271 vitest, lints clean.
102 lines
3.8 KiB
TypeScript
102 lines
3.8 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
|
|
import { isSectionName, parseDetailsMode, resolveSections, sectionMode, SECTION_NAMES } from '../domain/details.js'
|
|
|
|
describe('parseDetailsMode', () => {
|
|
it('accepts the canonical modes case-insensitively', () => {
|
|
expect(parseDetailsMode('hidden')).toBe('hidden')
|
|
expect(parseDetailsMode(' COLLAPSED ')).toBe('collapsed')
|
|
expect(parseDetailsMode('Expanded')).toBe('expanded')
|
|
})
|
|
|
|
it('rejects junk', () => {
|
|
expect(parseDetailsMode('truncated')).toBeNull()
|
|
expect(parseDetailsMode('')).toBeNull()
|
|
expect(parseDetailsMode(undefined)).toBeNull()
|
|
expect(parseDetailsMode(42)).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('isSectionName', () => {
|
|
it('only lets the four canonical sections through', () => {
|
|
expect(isSectionName('thinking')).toBe(true)
|
|
expect(isSectionName('tools')).toBe(true)
|
|
expect(isSectionName('subagents')).toBe(true)
|
|
expect(isSectionName('activity')).toBe(true)
|
|
|
|
expect(isSectionName('Thinking')).toBe(false) // case-sensitive on purpose
|
|
expect(isSectionName('bogus')).toBe(false)
|
|
expect(isSectionName('')).toBe(false)
|
|
expect(isSectionName(7)).toBe(false)
|
|
})
|
|
|
|
it('SECTION_NAMES exposes them all', () => {
|
|
expect([...SECTION_NAMES].sort()).toEqual(['activity', 'subagents', 'thinking', 'tools'])
|
|
})
|
|
})
|
|
|
|
describe('resolveSections', () => {
|
|
it('parses a well-formed sections object', () => {
|
|
expect(
|
|
resolveSections({
|
|
thinking: 'expanded',
|
|
tools: 'expanded',
|
|
subagents: 'collapsed',
|
|
activity: 'hidden'
|
|
})
|
|
).toEqual({
|
|
thinking: 'expanded',
|
|
tools: 'expanded',
|
|
subagents: 'collapsed',
|
|
activity: 'hidden'
|
|
})
|
|
})
|
|
|
|
it('drops unknown section names and unknown modes', () => {
|
|
expect(
|
|
resolveSections({
|
|
thinking: 'expanded',
|
|
tools: 'maximised',
|
|
bogus: 'hidden',
|
|
activity: 'hidden'
|
|
})
|
|
).toEqual({ thinking: 'expanded', activity: 'hidden' })
|
|
})
|
|
|
|
it('treats nullish/non-objects as empty overrides', () => {
|
|
expect(resolveSections(undefined)).toEqual({})
|
|
expect(resolveSections(null)).toEqual({})
|
|
expect(resolveSections('hidden')).toEqual({})
|
|
expect(resolveSections([])).toEqual({})
|
|
})
|
|
})
|
|
|
|
describe('sectionMode', () => {
|
|
it('falls back to the global mode for sections without a built-in default', () => {
|
|
expect(sectionMode('tools', 'collapsed', {})).toBe('collapsed')
|
|
expect(sectionMode('tools', 'expanded', undefined)).toBe('expanded')
|
|
expect(sectionMode('thinking', 'collapsed', {})).toBe('collapsed')
|
|
expect(sectionMode('subagents', 'expanded', {})).toBe('expanded')
|
|
})
|
|
|
|
it('hides the activity panel by default regardless of global mode', () => {
|
|
expect(sectionMode('activity', 'collapsed', {})).toBe('hidden')
|
|
expect(sectionMode('activity', 'expanded', undefined)).toBe('hidden')
|
|
expect(sectionMode('activity', 'hidden', {})).toBe('hidden')
|
|
})
|
|
|
|
it('honours per-section overrides over both the section default and global mode', () => {
|
|
expect(sectionMode('activity', 'collapsed', { activity: 'expanded' })).toBe('expanded')
|
|
expect(sectionMode('activity', 'expanded', { activity: 'collapsed' })).toBe('collapsed')
|
|
expect(sectionMode('tools', 'collapsed', { tools: 'expanded' })).toBe('expanded')
|
|
})
|
|
|
|
it('lets per-section overrides escape the global hidden mode', () => {
|
|
// Regression for the case where global details_mode: hidden used to
|
|
// short-circuit the entire accordion and prevent overrides from
|
|
// surfacing — `sections.tools: expanded` must still resolve to expanded.
|
|
expect(sectionMode('tools', 'hidden', { tools: 'expanded' })).toBe('expanded')
|
|
expect(sectionMode('thinking', 'hidden', { thinking: 'collapsed' })).toBe('collapsed')
|
|
expect(sectionMode('activity', 'hidden', { activity: 'expanded' })).toBe('expanded')
|
|
})
|
|
})
|