mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
70744add15
Adds two Camofox features: 1. Persistent browser sessions: new `browser.camofox.managed_persistence` config option. When enabled, Hermes sends a deterministic profile-scoped userId to Camofox so the server maps it to a persistent browser profile directory. Cookies, logins, and browser state survive across restarts. Default remains ephemeral (random userId per session). 2. VNC URL discovery: Camofox /health endpoint returns vncPort when running in headed mode. Hermes constructs the VNC URL and includes it in navigate responses so the agent can share it with users. Also fixes camofox_vision bug where call_llm response object was passed directly to json.dumps instead of extracting .choices[0].message.content. Changes from original PR: - Removed browser_evaluate tool (separate feature, needs own PR) - Removed snapshot truncation limit change (unrelated) - Config.yaml only for managed_persistence (no env var, no version bump) - Rewrote tests to use config mock instead of env var - Reverted package-lock.json churn Co-authored-by: analista <psikonetik@gmail.com.com>
66 lines
2.5 KiB
Python
66 lines
2.5 KiB
Python
"""Tests for Hermes-managed Camofox state helpers."""
|
|
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
|
|
def _load_module():
|
|
from tools import browser_camofox_state as state
|
|
return state
|
|
|
|
|
|
class TestCamofoxStatePaths:
|
|
def test_paths_are_profile_scoped(self, tmp_path):
|
|
state = _load_module()
|
|
with patch.object(state, "get_hermes_home", return_value=tmp_path):
|
|
assert state.get_camofox_state_dir() == tmp_path / "browser_auth" / "camofox"
|
|
|
|
|
|
class TestCamofoxIdentity:
|
|
def test_identity_is_deterministic(self, tmp_path):
|
|
state = _load_module()
|
|
with patch.object(state, "get_hermes_home", return_value=tmp_path):
|
|
first = state.get_camofox_identity("task-1")
|
|
second = state.get_camofox_identity("task-1")
|
|
assert first == second
|
|
|
|
def test_identity_differs_by_task(self, tmp_path):
|
|
state = _load_module()
|
|
with patch.object(state, "get_hermes_home", return_value=tmp_path):
|
|
a = state.get_camofox_identity("task-a")
|
|
b = state.get_camofox_identity("task-b")
|
|
# Same user (same profile), different session keys
|
|
assert a["user_id"] == b["user_id"]
|
|
assert a["session_key"] != b["session_key"]
|
|
|
|
def test_identity_differs_by_profile(self, tmp_path):
|
|
state = _load_module()
|
|
with patch.object(state, "get_hermes_home", return_value=tmp_path / "profile-a"):
|
|
a = state.get_camofox_identity("task-1")
|
|
with patch.object(state, "get_hermes_home", return_value=tmp_path / "profile-b"):
|
|
b = state.get_camofox_identity("task-1")
|
|
assert a["user_id"] != b["user_id"]
|
|
|
|
def test_default_task_id(self, tmp_path):
|
|
state = _load_module()
|
|
with patch.object(state, "get_hermes_home", return_value=tmp_path):
|
|
identity = state.get_camofox_identity()
|
|
assert "user_id" in identity
|
|
assert "session_key" in identity
|
|
assert identity["user_id"].startswith("hermes_")
|
|
assert identity["session_key"].startswith("task_")
|
|
|
|
|
|
class TestCamofoxConfigDefaults:
|
|
def test_default_config_includes_managed_persistence_toggle(self):
|
|
from hermes_cli.config import DEFAULT_CONFIG
|
|
|
|
browser_cfg = DEFAULT_CONFIG["browser"]
|
|
assert browser_cfg["camofox"]["managed_persistence"] is False
|
|
|
|
def test_config_version_unchanged(self):
|
|
from hermes_cli.config import DEFAULT_CONFIG
|
|
|
|
# managed_persistence is auto-merged by _deep_merge, no version bump needed
|
|
assert DEFAULT_CONFIG["_config_version"] == 10
|