mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-22 16:25:58 +00:00
70679ada61
Fixes #34067. 'hermes config set <unknown.key.path> <value>' silently accepted arbitrary key paths, wrote them to config.yaml, and reported success — but the runtime/gateway never read them. The headline case from the issue: a user typing hermes config set gateway.discord.gateway_restart_notification false gets success, but the value lands at config.yaml:gateway.discord.* where nothing reads it. The correct path is discord.gateway_restart_notification (platform configs live at the top level of DEFAULT_CONFIG, not under a 'platforms' namespace). The user reasonably believes the change took effect, then loses time debugging behavior that hasn't changed. Fix: schema-validate the dotted key path against DEFAULT_CONFIG before writing. Walk DEFAULT_CONFIG along the user's segments and: - Reject unknown top-level keys with a fuzzy-match suggestion - Reject unknown sub-keys by suggesting the closest sibling - Accept anything below open-dict shapes (mcp_servers.<name>.command, providers.<openrouter>.api_key, etc.) - Accept anything below schema-defined-extensible shapes (platform configs like discord.*, telegram.* — PlatformConfig has dynamic 'extra' fields, so deep validation is unsafe) - Special-case 'platforms.X' → suggest 'X' (the actual top-level layout) Bypass with --force for forward-compatibility with keys a newer Hermes version adds but the running version doesn't recognize yet: hermes config set --force brand_new_future_key value API-key style names (OPENROUTER_API_KEY, *_TOKEN, etc.) still route to .env before schema validation runs, so this is non-breaking for that path. Adds 21 regression tests across TestSchemaValidation + TestValidateConfigKey covering: unknown top-level keys, unknown sub-keys (the headline bug), platforms.* prefix suggestions, fuzzy-match top-level typos, sibling- suggestion sub-key typos, --force bypass, and that known config keys (simple, platform-extensible, open-dict) still work. Also updates 2 pre-existing tests that used non-canonical paths (platforms.telegram.* and 'verbose') which schema validation correctly flags — switched to canonical paths (telegram.* and agent.gateway_timeout). All 53 tests in test_set_config_value.py pass. Co-authored-by: Cursor <cursoragent@cursor.com>
69 lines
2.5 KiB
Python
69 lines
2.5 KiB
Python
"""``hermes config`` subcommand parser.
|
|
|
|
Extracted verbatim from ``hermes_cli/main.py:main()`` (god-file Phase 2).
|
|
Handler injected to avoid importing ``main``.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import Callable
|
|
|
|
|
|
def build_config_parser(subparsers, *, cmd_config: Callable) -> None:
|
|
"""Attach the ``config`` subcommand to ``subparsers``."""
|
|
# =========================================================================
|
|
# config command
|
|
# =========================================================================
|
|
config_parser = subparsers.add_parser(
|
|
"config",
|
|
help="View and edit configuration",
|
|
description="Manage Hermes Agent configuration",
|
|
)
|
|
config_subparsers = config_parser.add_subparsers(dest="config_command")
|
|
|
|
# config show (default)
|
|
config_subparsers.add_parser("show", help="Show current configuration")
|
|
|
|
# config edit
|
|
config_subparsers.add_parser("edit", help="Open config file in editor")
|
|
|
|
# config get
|
|
config_get = config_subparsers.add_parser(
|
|
"get", help="Print a resolved configuration value"
|
|
)
|
|
config_get.add_argument("key", nargs="?", help="Configuration key (e.g., model)")
|
|
config_get.add_argument("--json", action="store_true", help="Print value as JSON")
|
|
|
|
# config set
|
|
config_set = config_subparsers.add_parser("set", help="Set a configuration value")
|
|
config_set.add_argument(
|
|
"key", nargs="?", help="Configuration key (e.g., model, terminal.backend)"
|
|
)
|
|
config_set.add_argument("value", nargs="?", help="Value to set")
|
|
config_set.add_argument(
|
|
"--force",
|
|
action="store_true",
|
|
help="Bypass schema validation (write unknown keys without warning). "
|
|
"Use this when setting a key that a newer Hermes version supports "
|
|
"but the running version doesn't recognize yet.",
|
|
)
|
|
|
|
# config unset
|
|
config_unset = config_subparsers.add_parser(
|
|
"unset", help="Remove a configuration value"
|
|
)
|
|
config_unset.add_argument("key", nargs="?", help="Configuration key to remove")
|
|
|
|
# config path
|
|
config_subparsers.add_parser("path", help="Print config file path")
|
|
|
|
# config env-path
|
|
config_subparsers.add_parser("env-path", help="Print .env file path")
|
|
|
|
# config check
|
|
config_subparsers.add_parser("check", help="Check for missing/outdated config")
|
|
|
|
# config migrate
|
|
config_subparsers.add_parser("migrate", help="Update config with new options")
|
|
|
|
config_parser.set_defaults(func=cmd_config)
|