mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-30 06:41:51 +00:00
3fde8c153d
* fix(skills): skip dependency dirs in skill scan * fix(skills): widen sibling rglob scanners to use shared exclusion set Follow-up to PR #29968. The contributor's PR widened EXCLUDED_SKILL_DIRS in the canonical walker (iter_skill_index_files), which fixes the user-visible discovery path. This commit sweeps the ~12 other rglob('SKILL.md') sites that did their own ad-hoc filtering — most only checked .git/.hub, some had no filter at all — so dependency dirs (.venv, node_modules, site-packages, etc.) cannot leak ghost skills through the secondary paths. Adds agent.skill_utils.is_excluded_skill_path(path) helper. Migrates all 13 sites to use it. Removes 3 hardcoded duplicate filter sets. Sites touched: agent/curator_backup.py - skill backup file count gateway/run.py - disabled-skill response (2 sites) hermes_cli/dump.py - skill count in env dump hermes_cli/profile_describer.py- profile description (2 sites) hermes_cli/profile_distribution.py - profile install count hermes_cli/profiles.py - profile skill count hermes_cli/skills_hub.py - category detection tools/skill_manager_tool.py - skill name lookup (already used set, now uses helper) tools/skill_usage.py - usage tracking + skill dir lookup (2 sites) tools/skills_hub.py - optional skills find + scan (2 sites) tools/skills_sync.py - bundled skills sync E2E verified with the exact reported shape (bring/scripts/.venv/.../typer/.agents/skills/typer/SKILL.md): no sibling site picks up the ghost skill, all five legit-skill counts still return 1. * chore(infographic): retro-pop-grid bento for PR #30042 skill-scanner sweep --------- Co-authored-by: helix4u <4317663+helix4u@users.noreply.github.com>
96 lines
2.8 KiB
Python
96 lines
2.8 KiB
Python
"""Tests for agent/skill_utils.py."""
|
|
|
|
from agent.skill_utils import extract_skill_conditions, iter_skill_index_files
|
|
|
|
|
|
def test_metadata_as_dict_with_hermes():
|
|
"""Normal case: metadata is a dict containing hermes keys."""
|
|
frontmatter = {
|
|
"metadata": {
|
|
"hermes": {
|
|
"fallback_for_toolsets": ["toolset_a"],
|
|
"requires_toolsets": ["toolset_b"],
|
|
"fallback_for_tools": ["tool_x"],
|
|
"requires_tools": ["tool_y"],
|
|
}
|
|
}
|
|
}
|
|
result = extract_skill_conditions(frontmatter)
|
|
assert result["fallback_for_toolsets"] == ["toolset_a"]
|
|
assert result["requires_toolsets"] == ["toolset_b"]
|
|
assert result["fallback_for_tools"] == ["tool_x"]
|
|
assert result["requires_tools"] == ["tool_y"]
|
|
|
|
|
|
def test_metadata_as_string_does_not_crash():
|
|
"""Bug case: metadata is a non-dict truthy value (e.g. a YAML string)."""
|
|
frontmatter = {"metadata": "some text"}
|
|
result = extract_skill_conditions(frontmatter)
|
|
assert result == {
|
|
"fallback_for_toolsets": [],
|
|
"requires_toolsets": [],
|
|
"fallback_for_tools": [],
|
|
"requires_tools": [],
|
|
}
|
|
|
|
|
|
def test_metadata_as_none():
|
|
"""metadata key is present but set to null/None."""
|
|
frontmatter = {"metadata": None}
|
|
result = extract_skill_conditions(frontmatter)
|
|
assert result == {
|
|
"fallback_for_toolsets": [],
|
|
"requires_toolsets": [],
|
|
"fallback_for_tools": [],
|
|
"requires_tools": [],
|
|
}
|
|
|
|
|
|
def test_metadata_missing_entirely():
|
|
"""metadata key is absent from frontmatter."""
|
|
frontmatter = {"name": "my-skill", "description": "Does stuff."}
|
|
result = extract_skill_conditions(frontmatter)
|
|
assert result == {
|
|
"fallback_for_toolsets": [],
|
|
"requires_toolsets": [],
|
|
"fallback_for_tools": [],
|
|
"requires_tools": [],
|
|
}
|
|
|
|
|
|
def test_iter_skill_index_files_prunes_dependency_dirs(tmp_path):
|
|
real = tmp_path / "real-skill"
|
|
real.mkdir()
|
|
(real / "SKILL.md").write_text("---\nname: real-skill\n---\n", encoding="utf-8")
|
|
|
|
nested = (
|
|
tmp_path
|
|
/ "bring"
|
|
/ "scripts"
|
|
/ ".venv"
|
|
/ "lib"
|
|
/ "python3.13"
|
|
/ "site-packages"
|
|
/ "typer"
|
|
/ ".agents"
|
|
/ "skills"
|
|
/ "typer"
|
|
)
|
|
nested.mkdir(parents=True)
|
|
(nested / "SKILL.md").write_text("---\nname: typer\n---\n", encoding="utf-8")
|
|
|
|
node_module = (
|
|
tmp_path
|
|
/ "web-skill"
|
|
/ "node_modules"
|
|
/ "dep"
|
|
/ ".agents"
|
|
/ "skills"
|
|
/ "dep"
|
|
)
|
|
node_module.mkdir(parents=True)
|
|
(node_module / "SKILL.md").write_text("---\nname: dep\n---\n", encoding="utf-8")
|
|
|
|
found = list(iter_skill_index_files(tmp_path, "SKILL.md"))
|
|
|
|
assert found == [real / "SKILL.md"]
|