mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
114 lines
4 KiB
Python
114 lines
4 KiB
Python
"""Regression test for #25676 — nested gateway.streaming config must be loaded."""
|
|
from pathlib import Path
|
|
from unittest.mock import patch, MagicMock
|
|
|
|
|
|
|
|
def _load_with_yaml_dict(yaml_dict: dict):
|
|
"""Patch filesystem so load_gateway_config() sees *yaml_dict* as config.yaml."""
|
|
from gateway.config import load_gateway_config
|
|
|
|
fake_home = Path("/tmp/fake_hermes_home_25676")
|
|
|
|
def fake_exists(self):
|
|
return str(self).endswith("config.yaml")
|
|
|
|
with patch("gateway.config.get_hermes_home", return_value=fake_home), \
|
|
patch.object(Path, "exists", fake_exists), \
|
|
patch("builtins.open", create=True) as mock_file:
|
|
mock_file.return_value.__enter__ = lambda s: s
|
|
mock_file.return_value.__exit__ = MagicMock(return_value=False)
|
|
with patch("yaml.safe_load", return_value=yaml_dict):
|
|
return load_gateway_config()
|
|
|
|
|
|
class TestStreamingConfigNested:
|
|
def test_top_level_streaming(self):
|
|
cfg = _load_with_yaml_dict({"streaming": {"enabled": True, "transport": "draft"}})
|
|
assert cfg.streaming.enabled is True
|
|
assert cfg.streaming.transport == "draft"
|
|
|
|
|
|
def test_top_level_takes_precedence(self):
|
|
cfg = _load_with_yaml_dict({
|
|
"streaming": {"enabled": True, "transport": "edit"},
|
|
"gateway": {"streaming": {"enabled": False, "transport": "draft"}},
|
|
})
|
|
assert cfg.streaming.enabled is True
|
|
assert cfg.streaming.transport == "edit"
|
|
|
|
|
|
class TestStreamingModeAlias:
|
|
"""``streaming: {mode: ...}`` is an alias that also implies ``enabled``.
|
|
|
|
Regression for a live config footgun: ``streaming: {mode: auto}`` was
|
|
silently ignored (mode was never read), so streaming stayed disabled and
|
|
the whole reply buffered before the first Telegram send.
|
|
"""
|
|
|
|
def test_mode_auto_enables_streaming(self):
|
|
from gateway.config import StreamingConfig
|
|
|
|
sc = StreamingConfig.from_dict({"mode": "auto"})
|
|
assert sc.enabled is True
|
|
assert sc.transport == "auto"
|
|
|
|
def test_mode_edit_enables_streaming(self):
|
|
from gateway.config import StreamingConfig
|
|
|
|
sc = StreamingConfig.from_dict({"mode": "edit"})
|
|
assert sc.enabled is True
|
|
assert sc.transport == "edit"
|
|
|
|
|
|
|
|
def test_explicit_enabled_overrides_mode(self):
|
|
from gateway.config import StreamingConfig
|
|
|
|
sc = StreamingConfig.from_dict({"mode": "auto", "enabled": False})
|
|
assert sc.enabled is False
|
|
# transport still resolves from mode
|
|
assert sc.transport == "auto"
|
|
|
|
|
|
def test_empty_block_stays_disabled(self):
|
|
from gateway.config import StreamingConfig
|
|
|
|
sc = StreamingConfig.from_dict({})
|
|
assert sc.enabled is False
|
|
|
|
|
|
|
|
class TestStreamingYamlBooleanQuirk:
|
|
"""YAML 1.1 parses bare ``off``/``on`` as booleans; ``mode``/``transport``
|
|
must normalize those back to canonical string tokens.
|
|
|
|
Regression for the review on PR #62873: bare ``mode: off`` arrived as
|
|
Python ``False`` and stringified to ``"false"``, which is not ``"off"``,
|
|
so streaming was enabled instead of honoring the advertised disable.
|
|
"""
|
|
|
|
def test_mode_bare_off_boolean_disables(self):
|
|
from gateway.config import StreamingConfig
|
|
|
|
# yaml.safe_load("off") -> False
|
|
sc = StreamingConfig.from_dict({"mode": False})
|
|
assert sc.enabled is False
|
|
assert sc.transport == "off"
|
|
|
|
def test_mode_bare_on_boolean_enables(self):
|
|
from gateway.config import StreamingConfig
|
|
|
|
# yaml.safe_load("on") -> True
|
|
sc = StreamingConfig.from_dict({"mode": True})
|
|
assert sc.enabled is True
|
|
assert sc.transport == "auto"
|
|
|
|
|
|
def test_loader_normalizes_bare_yaml_off(self):
|
|
"""End-to-end through load_gateway_config(): unquoted ``mode: off``
|
|
(a YAML boolean) must keep streaming disabled."""
|
|
cfg = _load_with_yaml_dict({"streaming": {"mode": False}})
|
|
assert cfg.streaming.enabled is False
|
|
assert cfg.streaming.transport == "off"
|
|
|