mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
95 lines
3.1 KiB
Python
95 lines
3.1 KiB
Python
"""Regression test for TUI v2 blitz bug: explicit /model --provider switch
|
|
silently fell back to the old primary provider on the next turn because the
|
|
fallback chain — seeded from config at agent __init__ — kept entries for the
|
|
provider the user just moved away from.
|
|
|
|
Reported: "switched from openrouter provider to anthropic api key via hermes
|
|
model and the tui keeps trying openrouter".
|
|
"""
|
|
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from run_agent import AIAgent
|
|
|
|
|
|
def _make_agent(chain):
|
|
agent = AIAgent.__new__(AIAgent)
|
|
|
|
agent.provider = "openrouter"
|
|
agent.model = "x-ai/grok-4"
|
|
agent.base_url = "https://openrouter.ai/api/v1"
|
|
agent.api_key = "or-key"
|
|
agent.api_mode = "chat_completions"
|
|
agent.client = MagicMock()
|
|
agent._client_kwargs = {"api_key": "or-key", "base_url": "https://openrouter.ai/api/v1"}
|
|
agent.context_compressor = None
|
|
agent._anthropic_api_key = ""
|
|
agent._anthropic_base_url = None
|
|
agent._anthropic_client = None
|
|
agent._is_anthropic_oauth = False
|
|
agent._cached_system_prompt = "cached"
|
|
agent._primary_runtime = {}
|
|
agent._fallback_activated = False
|
|
agent._fallback_index = 0
|
|
agent._fallback_chain = list(chain)
|
|
agent._fallback_model = chain[0] if chain else None
|
|
|
|
return agent
|
|
|
|
|
|
def _switch_to_anthropic(agent):
|
|
with (
|
|
patch("agent.anthropic_adapter.build_anthropic_client", return_value=MagicMock()),
|
|
patch("agent.anthropic_adapter.resolve_anthropic_token", return_value="sk-ant-xyz"),
|
|
patch("agent.anthropic_adapter._is_oauth_token", return_value=False),
|
|
patch("hermes_cli.timeouts.get_provider_request_timeout", return_value=None),
|
|
):
|
|
agent.switch_model(
|
|
new_model="claude-sonnet-4-5",
|
|
new_provider="anthropic",
|
|
api_key="sk-ant-xyz",
|
|
base_url="https://api.anthropic.com",
|
|
api_mode="anthropic_messages",
|
|
)
|
|
|
|
|
|
def test_switch_drops_old_primary_from_fallback_chain():
|
|
agent = _make_agent([
|
|
{"provider": "openrouter", "model": "x-ai/grok-4"},
|
|
{"provider": "nous", "model": "hermes-4"},
|
|
])
|
|
|
|
_switch_to_anthropic(agent)
|
|
|
|
providers = [entry["provider"] for entry in agent._fallback_chain]
|
|
|
|
assert "openrouter" not in providers, "old primary must be pruned"
|
|
assert "anthropic" not in providers, "new primary is redundant in the chain"
|
|
assert providers == ["nous"]
|
|
assert agent._fallback_model == {"provider": "nous", "model": "hermes-4"}
|
|
|
|
|
|
def test_switch_with_empty_chain_stays_empty():
|
|
agent = _make_agent([])
|
|
|
|
_switch_to_anthropic(agent)
|
|
|
|
assert agent._fallback_chain == []
|
|
assert agent._fallback_model is None
|
|
|
|
|
|
|
|
|
|
def test_switch_within_same_provider_preserves_chain():
|
|
chain = [{"provider": "openrouter", "model": "x-ai/grok-4"}]
|
|
agent = _make_agent(chain)
|
|
|
|
with patch("hermes_cli.timeouts.get_provider_request_timeout", return_value=None):
|
|
agent.switch_model(
|
|
new_model="openai/gpt-5",
|
|
new_provider="openrouter",
|
|
api_key="or-key",
|
|
base_url="https://openrouter.ai/api/v1",
|
|
)
|
|
|
|
assert agent._fallback_chain == chain
|