mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
89 lines
3 KiB
Python
89 lines
3 KiB
Python
"""Tests for _verify_console_scripts_installed (issue #52931)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import textwrap
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def temp_pyproject(tmp_path, monkeypatch):
|
|
pyproject = tmp_path / "pyproject.toml"
|
|
pyproject.write_text(
|
|
textwrap.dedent(
|
|
"""\
|
|
[project]
|
|
name = "fake"
|
|
version = "0.0.0"
|
|
|
|
[project.scripts]
|
|
hermes = "hermes_cli.main:main"
|
|
hermes-agent = "run_agent:main"
|
|
hermes-acp = "acp_adapter.entry:main"
|
|
"""
|
|
)
|
|
)
|
|
import hermes_cli.main as main_mod
|
|
|
|
monkeypatch.setattr(main_mod, "PROJECT_ROOT", tmp_path)
|
|
return tmp_path
|
|
|
|
|
|
@pytest.fixture
|
|
def fake_scripts_dir(tmp_path):
|
|
scripts = tmp_path / "venv" / "Scripts"
|
|
scripts.mkdir(parents=True)
|
|
return scripts
|
|
|
|
|
|
class TestVerifyConsoleScriptsInstalled:
|
|
def test_no_action_when_all_shims_present(self, temp_pyproject, fake_scripts_dir):
|
|
for name in ("hermes", "hermes-agent", "hermes-acp"):
|
|
(fake_scripts_dir / f"{name}.exe").write_bytes(b"fake")
|
|
|
|
with patch("hermes_cli.main._is_windows", return_value=True), \
|
|
patch("hermes_cli.main._venv_scripts_dir", return_value=fake_scripts_dir), \
|
|
patch("hermes_cli.main._run_quarantined_install") as mock_install:
|
|
from hermes_cli.main import _verify_console_scripts_installed
|
|
|
|
_verify_console_scripts_installed(["uv", "pip"], env={})
|
|
|
|
mock_install.assert_not_called()
|
|
|
|
|
|
def test_load_console_script_names_reads_pyproject(self, temp_pyproject):
|
|
from hermes_cli.main import _load_console_script_names
|
|
|
|
names = _load_console_script_names()
|
|
assert names == ["hermes", "hermes-agent", "hermes-acp"]
|
|
|
|
def test_primary_install_success_still_verifies_scripts(self):
|
|
import hermes_cli.main as main_mod
|
|
|
|
with patch("hermes_cli.main._is_windows", return_value=False), \
|
|
patch("hermes_cli.main._run_quarantined_install") as mock_install, \
|
|
patch("hermes_cli.main._verify_console_scripts_installed") as mock_verify:
|
|
main_mod._install_python_dependencies_with_optional_fallback(
|
|
["uv", "pip"], env={"VIRTUAL_ENV": "x"}
|
|
)
|
|
|
|
mock_install.assert_called_once_with(
|
|
["uv", "pip", "install", "-e", ".[all]"],
|
|
env={"VIRTUAL_ENV": "x"},
|
|
scripts_dir=None,
|
|
)
|
|
mock_verify.assert_called_once_with(["uv", "pip"], env={"VIRTUAL_ENV": "x"})
|
|
|
|
def test_quarantine_shims_include_declared_console_scripts(
|
|
self, temp_pyproject, fake_scripts_dir
|
|
):
|
|
import hermes_cli.main as main_mod
|
|
|
|
with patch("hermes_cli.main._is_windows", return_value=True):
|
|
names = {path.name for path in main_mod._hermes_exe_shims(fake_scripts_dir)}
|
|
|
|
assert {"hermes.exe", "hermes-agent.exe", "hermes-acp.exe"} <= names
|
|
assert "hermes-gateway.exe" in names
|