mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
99 lines
4 KiB
Python
99 lines
4 KiB
Python
"""Tests for the static-catalog fallback in validate_requested_model.
|
|
|
|
OpenCode Go and OpenCode Zen publish an OpenAI-compatible API at paths that do
|
|
NOT expose ``/models`` (the path returns the marketing site's HTML 404). This
|
|
caused ``validate_requested_model`` to return ``accepted=False`` for every
|
|
model on those providers, which in turn made ``switch_model()`` fail and the
|
|
gateway's ``/model <name> --provider opencode-go`` command never write to
|
|
``_session_model_overrides``.
|
|
|
|
These tests cover the catalog-fallback path: when ``fetch_api_models`` returns
|
|
``None``, the validator must consult ``provider_model_ids()`` for the provider
|
|
(populated from ``_PROVIDER_MODELS``) rather than rejecting outright.
|
|
"""
|
|
|
|
from unittest.mock import patch
|
|
|
|
from hermes_cli.models import validate_requested_model
|
|
|
|
|
|
_UNREACHABLE_PROBE = {
|
|
"models": None,
|
|
"probed_url": "https://opencode.ai/zen/go/v1/models",
|
|
"resolved_base_url": "https://opencode.ai/zen/go/v1",
|
|
"suggested_base_url": None,
|
|
"used_fallback": False,
|
|
}
|
|
|
|
|
|
def _patched(func):
|
|
"""Decorator: force fetch_api_models / probe_api_models to simulate an
|
|
unreachable /models endpoint, proving the catalog path is used."""
|
|
def wrapper(*args, **kwargs):
|
|
with patch("hermes_cli.models.fetch_api_models", return_value=None), \
|
|
patch("hermes_cli.models.probe_api_models", return_value=_UNREACHABLE_PROBE):
|
|
return func(*args, **kwargs)
|
|
wrapper.__name__ = func.__name__
|
|
return wrapper
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# opencode-go: curated catalog in _PROVIDER_MODELS
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@_patched
|
|
def test_opencode_go_known_model_accepted():
|
|
"""A model present in the opencode-go curated catalog must be accepted
|
|
even when /models is unreachable."""
|
|
result = validate_requested_model("kimi-k2.6", "opencode-go")
|
|
assert result["accepted"] is True
|
|
assert result["persist"] is True
|
|
assert result["recognized"] is True
|
|
assert result["message"] is None
|
|
|
|
|
|
@_patched
|
|
def test_opencode_go_totally_unknown_model_still_accepted():
|
|
"""A model with zero similarity to the catalog is still accepted (no
|
|
suggestion line) so the user can try a model that hasn't made it into the
|
|
curated list yet."""
|
|
result = validate_requested_model("some-brand-new-model", "opencode-go")
|
|
assert result["accepted"] is True
|
|
assert result["persist"] is True
|
|
assert result["recognized"] is False
|
|
# No suggestion text (no close matches)
|
|
assert "Similar models" not in result["message"]
|
|
assert "opencode" in result["message"].lower() or "opencode go" in result["message"].lower()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# opencode-zen: same pattern as opencode-go
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@_patched
|
|
def test_opencode_zen_known_model_accepted():
|
|
"""opencode-zen also uses _PROVIDER_MODELS; kimi-k2 is in its catalog."""
|
|
result = validate_requested_model("kimi-k2", "opencode-zen")
|
|
assert result["accepted"] is True
|
|
assert result["recognized"] is True
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Unknown provider with no catalog: soft-accept (honors the comment's intent)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
@_patched
|
|
def test_provider_without_catalog_accepts_with_warning():
|
|
"""When a provider has no entry in _PROVIDER_MODELS and /models is
|
|
unreachable, accept the model with a 'Note:' warning rather than reject.
|
|
This matches the in-code comment: 'Accept and persist, but warn so typos
|
|
don't silently break things.'"""
|
|
# Use a made-up provider name that won't resolve to any catalog.
|
|
result = validate_requested_model("some-model", "provider-that-does-not-exist")
|
|
assert result["accepted"] is True
|
|
assert result["persist"] is True
|
|
assert result["recognized"] is False
|
|
assert "Note:" in result["message"]
|