mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
120 lines
4.6 KiB
Python
120 lines
4.6 KiB
Python
"""Tests for opencode-go / opencode-zen flat-namespace model handling.
|
|
|
|
OpenCode Go is NOT a vendor/model aggregator like OpenRouter — its
|
|
``/v1/models`` endpoint returns bare IDs (``minimax-m2.7``, ``deepseek-v4-flash``)
|
|
and the inference API rejects vendor-prefixed names with HTTP 401
|
|
"Model not supported".
|
|
|
|
Two bugs this exercises:
|
|
|
|
1. ``switch_model('deepseek-v4-flash', current_provider='opencode-go')`` used
|
|
to silently switch the user off opencode-go to native ``deepseek`` because
|
|
``detect_provider_for_model`` matched the bare name against the static
|
|
deepseek catalog. Fix: once step d matches the model in the current
|
|
aggregator's live catalog, skip ``detect_provider_for_model``.
|
|
|
|
2. ``normalize_model_for_provider('minimax/minimax-m2.7', 'opencode-go')``
|
|
used to pass the ``minimax/`` prefix through unchanged. When user configs
|
|
contained prefixed fallback entries (commonly copied from aggregator slugs),
|
|
the fallback activation path sent ``minimax/minimax-m2.7`` to opencode-go
|
|
which returned HTTP 401. Fix: opencode-go/opencode-zen strip ANY leading
|
|
``vendor/`` prefix because their APIs are flat-namespace.
|
|
"""
|
|
|
|
from unittest.mock import patch
|
|
|
|
from hermes_cli.model_normalize import normalize_model_for_provider
|
|
from hermes_cli.model_switch import switch_model
|
|
|
|
|
|
# Live catalog opencode-go currently returns from /v1/models (snapshot).
|
|
_OPENCODE_GO_LIVE = [
|
|
"minimax-m2.7", "minimax-m2.5",
|
|
"kimi-k2.6", "kimi-k2.5",
|
|
"glm-5.1", "glm-5",
|
|
"deepseek-v4-pro", "deepseek-v4-flash",
|
|
"qwen3.6-plus", "qwen3.5-plus",
|
|
"mimo-v2-pro", "mimo-v2-omni", "mimo-v2.5-pro", "mimo-v2.5",
|
|
]
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# normalize_model_for_provider: strip vendor prefix for flat-namespace providers
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_opencode_go_strips_deepseek_prefix():
|
|
assert normalize_model_for_provider(
|
|
"deepseek/deepseek-v4-flash", "opencode-go"
|
|
) == "deepseek-v4-flash"
|
|
|
|
|
|
def test_opencode_zen_still_hyphenates_claude():
|
|
# Regression: opencode-zen's Claude hyphen conversion must still work.
|
|
assert normalize_model_for_provider(
|
|
"anthropic/claude-sonnet-4.6", "opencode-zen"
|
|
) == "claude-sonnet-4-6"
|
|
|
|
|
|
def test_openrouter_still_prepends_vendor():
|
|
# Regression: real aggregators must still get vendor/model format.
|
|
assert normalize_model_for_provider(
|
|
"claude-sonnet-4.6", "openrouter"
|
|
) == "anthropic/claude-sonnet-4.6"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# switch_model: live-catalog match on opencode-go must not trigger
|
|
# cross-provider auto-switch via detect_provider_for_model
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _run_switch(raw_input: str, **extra):
|
|
"""Call switch_model with opencode-go as current provider, mocking the
|
|
live catalog so the test doesn't hit the network."""
|
|
defaults = dict(
|
|
current_provider="opencode-go",
|
|
current_model="kimi-k2.6",
|
|
current_base_url="https://opencode.ai/zen/go/v1",
|
|
current_api_key="sk-test-opencode-go",
|
|
is_global=False,
|
|
)
|
|
defaults.update(extra)
|
|
|
|
def fake_list_provider_models(provider: str):
|
|
if provider == "opencode-go":
|
|
return list(_OPENCODE_GO_LIVE)
|
|
# For other providers, return empty so tests don't depend on them.
|
|
return []
|
|
|
|
with patch(
|
|
"hermes_cli.model_switch.list_provider_models",
|
|
side_effect=fake_list_provider_models,
|
|
):
|
|
return switch_model(raw_input=raw_input, **defaults)
|
|
|
|
|
|
def test_deepseek_v4_flash_stays_on_opencode_go():
|
|
"""Regression: ``/model deepseek-v4-flash`` while on opencode-go must
|
|
NOT switch to native deepseek just because deepseek's static catalog
|
|
also contains that name."""
|
|
result = _run_switch("deepseek-v4-flash")
|
|
assert result.target_provider == "opencode-go", (
|
|
f"Expected to stay on opencode-go, got {result.target_provider}. "
|
|
f"detect_provider_for_model hijacked the bare name."
|
|
)
|
|
assert result.new_model == "deepseek-v4-flash"
|
|
|
|
|
|
def test_deepseek_v4_pro_stays_on_opencode_go():
|
|
"""Same bug class as the flash variant."""
|
|
result = _run_switch("deepseek-v4-pro")
|
|
assert result.target_provider == "opencode-go"
|
|
assert result.new_model == "deepseek-v4-pro"
|
|
|
|
|
|
def test_kimi_k2_6_stays_on_opencode_go():
|
|
"""Regression guard: this path was always working, keep it working."""
|
|
result = _run_switch("kimi-k2.6", current_model="deepseek-v4-pro")
|
|
assert result.target_provider == "opencode-go"
|
|
assert result.new_model == "kimi-k2.6"
|