mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
115 lines
4.2 KiB
Python
115 lines
4.2 KiB
Python
"""Tests for the launch-time stale-bytecode sweep (checkout fingerprint guard).
|
|
|
|
Bug class: the checkout's ``.py`` files change (``hermes update``, manual
|
|
``git pull``, ZIP update) while ``__pycache__`` retains bytecode compiled
|
|
from the previous revision; the next process to import trusts the stale
|
|
``.pyc`` and dies with ``cannot import name ...`` (#6207, #60242).
|
|
|
|
The launch-time guard compares the current checkout fingerprint against the
|
|
last-validated stamp and sweeps ``__pycache__`` once when they diverge —
|
|
covering paths no update-time clear can reach (manual pulls, pre-hardening
|
|
updaters).
|
|
"""
|
|
|
|
from pathlib import Path
|
|
|
|
from hermes_cli import main as hermes_main
|
|
|
|
|
|
def _make_repo(tmp_path: Path, sha: str = "a" * 40) -> Path:
|
|
"""Minimal git checkout layout that _read_git_revision_fingerprint groks."""
|
|
repo = tmp_path / "repo"
|
|
git_dir = repo / ".git"
|
|
(git_dir / "refs" / "heads").mkdir(parents=True)
|
|
(git_dir / "HEAD").write_text("ref: refs/heads/main\n", encoding="utf-8")
|
|
(git_dir / "refs" / "heads" / "main").write_text(sha + "\n", encoding="utf-8")
|
|
return repo
|
|
|
|
|
|
def _make_pycache(repo: Path, subdir: str = "hermes_cli") -> Path:
|
|
cache = repo / subdir / "__pycache__"
|
|
cache.mkdir(parents=True)
|
|
(cache / "main.cpython-311.pyc").write_bytes(b"stale")
|
|
return cache
|
|
|
|
|
|
def test_sweep_clears_pycache_when_checkout_changed(monkeypatch, tmp_path):
|
|
repo = _make_repo(tmp_path, sha="b" * 40)
|
|
cache = _make_pycache(repo)
|
|
monkeypatch.setattr(hermes_main, "PROJECT_ROOT", repo)
|
|
# Stamp records a different (older) fingerprint.
|
|
(repo / hermes_main._BYTECODE_FINGERPRINT_FILE).write_text(
|
|
"git:refs/heads/main:" + "a" * 40, encoding="utf-8"
|
|
)
|
|
|
|
hermes_main._sweep_stale_bytecode_if_checkout_changed()
|
|
|
|
assert not cache.exists()
|
|
# Stamp updated to the current fingerprint.
|
|
recorded = (repo / hermes_main._BYTECODE_FINGERPRINT_FILE).read_text(encoding="utf-8")
|
|
assert recorded.strip().endswith("b" * 40)
|
|
|
|
|
|
def test_sweep_first_launch_clears_and_records(monkeypatch, tmp_path):
|
|
"""No stamp yet (first launch with the guard) → sweep once, record."""
|
|
repo = _make_repo(tmp_path, sha="d" * 40)
|
|
cache = _make_pycache(repo)
|
|
monkeypatch.setattr(hermes_main, "PROJECT_ROOT", repo)
|
|
|
|
hermes_main._sweep_stale_bytecode_if_checkout_changed()
|
|
|
|
assert not cache.exists()
|
|
assert (repo / hermes_main._BYTECODE_FINGERPRINT_FILE).exists()
|
|
|
|
|
|
def test_record_bytecode_fingerprint_writes_atomically(monkeypatch, tmp_path):
|
|
repo = _make_repo(tmp_path, sha="f" * 40)
|
|
monkeypatch.setattr(hermes_main, "PROJECT_ROOT", repo)
|
|
|
|
hermes_main._record_bytecode_fingerprint()
|
|
|
|
stamp = repo / hermes_main._BYTECODE_FINGERPRINT_FILE
|
|
assert stamp.read_text(encoding="utf-8").endswith("f" * 40)
|
|
assert not stamp.with_name(stamp.name + ".tmp").exists()
|
|
|
|
|
|
def test_sweep_skips_venv_and_git_dirs(monkeypatch, tmp_path):
|
|
"""The underlying clear must not touch venv/node_modules bytecode."""
|
|
repo = _make_repo(tmp_path, sha="9" * 40)
|
|
repo_cache = _make_pycache(repo, "hermes_cli")
|
|
venv_cache = repo / "venv" / "lib" / "__pycache__"
|
|
venv_cache.mkdir(parents=True)
|
|
(venv_cache / "x.pyc").write_bytes(b"keep")
|
|
monkeypatch.setattr(hermes_main, "PROJECT_ROOT", repo)
|
|
|
|
hermes_main._sweep_stale_bytecode_if_checkout_changed()
|
|
|
|
assert not repo_cache.exists()
|
|
assert venv_cache.exists()
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Plugin-update sibling site: __pycache__ under ~/.hermes/plugins/<name>
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def test_clear_plugin_bytecode_removes_nested_caches(tmp_path):
|
|
from hermes_cli import plugins_cmd
|
|
|
|
plugin = tmp_path / "myplugin"
|
|
top = plugin / "__pycache__"
|
|
nested = plugin / "sub" / "__pycache__"
|
|
top.mkdir(parents=True)
|
|
nested.mkdir(parents=True)
|
|
(top / "a.pyc").write_bytes(b"stale")
|
|
(nested / "b.pyc").write_bytes(b"stale")
|
|
|
|
removed = plugins_cmd._clear_plugin_bytecode(plugin)
|
|
|
|
assert removed == 2
|
|
assert not top.exists()
|
|
assert not nested.exists()
|
|
|
|
|
|
def test_clear_plugin_bytecode_never_raises_on_missing_dir(tmp_path):
|
|
from hermes_cli import plugins_cmd
|
|
|
|
assert plugins_cmd._clear_plugin_bytecode(tmp_path / "nope") == 0
|