mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-09 08:21:50 +00:00
The unpacked Hermes.exe showed the stock Electron icon + name in the taskbar because build.win.signAndEditExecutable=false disables BOTH electron-builder's signing AND its rcedit metadata/icon stamping. That flag is load-bearing: enabling it re-triggers signtool -> winCodeSign, whose macOS symlinks crash 7-Zip on non-admin Windows (unfixable dead end). Decouple identity-stamping from signing entirely: after npm run pack, run rcedit ourselves on the produced exe. - Add rcedit as a direct devDependency of apps/desktop (the transitive electron-winstaller copy is fragile). - apps/desktop/scripts/set-exe-identity.cjs: Node helper that calls rcedit's named export to set icon + ProductName/FileDescription/ CompanyName. Node builds argv natively — avoids the PowerShell->exe ->JSON double-escaping that broke the app-builder rcedit path. - install.ps1 Set-DesktopExeIdentity invokes the script after the build, before shortcuts. Best-effort: failure keeps the stock icon, never fails the install. rcedit is a pure PE editor — no signtool, no winCodeSign, no symlinks. Verified locally: stamping a copy of the built Hermes.exe embeds the 32x32 icon and sets ProductName=Hermes. Also fix update-path success-screen flash: in update mode the installer hands off + exits in ~600ms, so don't route to the 'launch Hermes' success view (it flashed before the window closed).
87 lines
3.1 KiB
JavaScript
87 lines
3.1 KiB
JavaScript
#!/usr/bin/env node
|
|
// set-exe-identity.cjs — stamp the Hermes icon + version metadata onto the
|
|
// built Hermes.exe using rcedit, completely decoupled from electron-builder's
|
|
// signing path.
|
|
//
|
|
// WHY THIS EXISTS
|
|
// ---------------
|
|
// apps/desktop/package.json sets build.win.signAndEditExecutable=false. That
|
|
// flag is load-bearing: turning electron-builder's own exe-editing ON also
|
|
// re-enables its signtool step, which fetches winCodeSign-2.6.0.7z, whose
|
|
// macOS symlinks crash 7-Zip on non-admin Windows (no Developer Mode = no
|
|
// SeCreateSymbolicLinkPrivilege). That is an unfixable dead end — we do NOT
|
|
// try to extract winCodeSign.
|
|
//
|
|
// The cost of disabling signAndEditExecutable is that electron-builder also
|
|
// skips rcedit, so the unpacked Hermes.exe keeps the stock Electron icon and
|
|
// "Electron" taskbar name. This script restores the icon + identity by calling
|
|
// rcedit DIRECTLY. rcedit is a pure PE resource editor: no signing, no certs,
|
|
// no winCodeSign, no symlinks. Invoked from install.ps1's Install-Desktop
|
|
// after `npm run pack`.
|
|
//
|
|
// USAGE
|
|
// node scripts/set-exe-identity.cjs <path-to-Hermes.exe>
|
|
//
|
|
// Exits 0 on success, non-zero on failure. install.ps1 treats failure as
|
|
// non-fatal (worst case: stock icon, not a broken app).
|
|
|
|
const path = require('node:path')
|
|
const fs = require('node:fs')
|
|
|
|
async function main() {
|
|
const exe = process.argv[2]
|
|
if (!exe) {
|
|
console.error('[set-exe-identity] usage: set-exe-identity.cjs <path-to-exe>')
|
|
process.exit(2)
|
|
}
|
|
if (!fs.existsSync(exe)) {
|
|
console.error(`[set-exe-identity] target exe not found: ${exe}`)
|
|
process.exit(2)
|
|
}
|
|
|
|
// Icon lives beside this script's package root: apps/desktop/assets/icon.ico
|
|
const desktopRoot = path.resolve(__dirname, '..')
|
|
const icon = path.join(desktopRoot, 'assets', 'icon.ico')
|
|
if (!fs.existsSync(icon)) {
|
|
console.error(`[set-exe-identity] icon not found: ${icon}`)
|
|
process.exit(2)
|
|
}
|
|
|
|
// rcedit is a direct devDependency of apps/desktop, so it resolves whether
|
|
// we're run from the desktop dir or the repo root (workspace hoist).
|
|
// rcedit@5 exports a NAMED `rcedit` function (CommonJS: { rcedit }), not a
|
|
// default export.
|
|
let rcedit
|
|
try {
|
|
const mod = require('rcedit')
|
|
rcedit = typeof mod === 'function' ? mod : mod.rcedit
|
|
if (typeof rcedit !== 'function') {
|
|
throw new Error(`unexpected rcedit export shape: ${typeof mod} keys=${Object.keys(mod)}`)
|
|
}
|
|
} catch (err) {
|
|
console.error(`[set-exe-identity] could not load rcedit module: ${err.message}`)
|
|
process.exit(3)
|
|
}
|
|
|
|
console.log(`[set-exe-identity] stamping ${exe}`)
|
|
console.log(`[set-exe-identity] icon: ${icon}`)
|
|
|
|
try {
|
|
await rcedit(exe, {
|
|
icon,
|
|
'version-string': {
|
|
ProductName: 'Hermes',
|
|
FileDescription: 'Hermes',
|
|
CompanyName: 'Nous Research',
|
|
LegalCopyright: 'Copyright (c) 2026 Nous Research'
|
|
}
|
|
})
|
|
} catch (err) {
|
|
console.error(`[set-exe-identity] rcedit failed: ${err.message}`)
|
|
process.exit(1)
|
|
}
|
|
|
|
console.log('[set-exe-identity] done — Hermes icon + identity stamped')
|
|
}
|
|
|
|
main()
|