mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-06-14 09:11:54 +00:00
928280ca2c
A user-reported failure on Windows-on-ARM: a pre-installed Python 3.13 on PATH makes findSystemPython() succeed, so resolveHermesBackend returns a backend pointing at it -- but hermes_cli isn't in that interpreter's site-packages. The spawn dies with ModuleNotFoundError and the user sees a dead GUI instead of the first-launch installer. Same shape can hit step 4 (existing `hermes` on PATH) when a stale shim survives a partial uninstall. Add cheap exit-code probes -- `python -c "import hermes_cli"` for step 5, `<hermes> --version` for step 4 -- and fall through to step 6 (bootstrap-needed) on failure. install.ps1 then runs as if on a clean box and the venv gets built. Probes live in a standalone electron/backend-probes.cjs module so they can be unit-tested with node --test, same pattern as bootstrap-platform.cjs and hardening.cjs. New test file wired into test:desktop:platforms.
80 lines
3.3 KiB
JavaScript
80 lines
3.3 KiB
JavaScript
/**
|
|
* Tests for electron/backend-probes.cjs.
|
|
*
|
|
* Run with: node --test electron/backend-probes.test.cjs
|
|
* (Wired into npm test:desktop:platforms in package.json.)
|
|
*/
|
|
|
|
const test = require('node:test')
|
|
const assert = require('node:assert/strict')
|
|
const fs = require('node:fs')
|
|
const os = require('node:os')
|
|
const path = require('node:path')
|
|
|
|
const { canImportHermesCli, verifyHermesCli } = require('./backend-probes.cjs')
|
|
|
|
// Resolve the host's own Node binary -- guaranteed to be on disk and
|
|
// runnable. We use it as both a stand-in for "a python that doesn't
|
|
// have hermes_cli" (since `node -c "import hermes_cli"` will exit
|
|
// non-zero) and as a way to script verifyHermesCli's success path
|
|
// (a tiny script we write to disk that exits 0 on --version).
|
|
const NODE_BIN = process.execPath
|
|
|
|
test('canImportHermesCli returns false when path is falsy', () => {
|
|
assert.equal(canImportHermesCli(''), false)
|
|
assert.equal(canImportHermesCli(null), false)
|
|
assert.equal(canImportHermesCli(undefined), false)
|
|
})
|
|
|
|
test('canImportHermesCli returns false when interpreter cannot run -c', () => {
|
|
// node IS an interpreter, but `node -c "import hermes_cli"` is a
|
|
// SyntaxError -- different exit reason from a real Python's
|
|
// ModuleNotFoundError, but the predicate is "exit 0 or not" and
|
|
// both land on "not", which is exactly what we want for the
|
|
// resolver fall-through.
|
|
assert.equal(canImportHermesCli(NODE_BIN), false)
|
|
})
|
|
|
|
test('canImportHermesCli returns false when binary does not exist', () => {
|
|
const ghost = path.join(os.tmpdir(), 'hermes-probes-ghost-' + Date.now() + '.exe')
|
|
assert.equal(canImportHermesCli(ghost), false)
|
|
})
|
|
|
|
test('verifyHermesCli returns false when command is falsy', () => {
|
|
assert.equal(verifyHermesCli(''), false)
|
|
assert.equal(verifyHermesCli(null), false)
|
|
assert.equal(verifyHermesCli(undefined), false)
|
|
})
|
|
|
|
test('verifyHermesCli returns false when binary does not exist', () => {
|
|
const ghost = path.join(os.tmpdir(), 'hermes-probes-ghost-' + Date.now() + '.exe')
|
|
assert.equal(verifyHermesCli(ghost), false)
|
|
})
|
|
|
|
test('verifyHermesCli returns true when --version exits 0', () => {
|
|
// Write a tiny script that exits 0 regardless of args, then invoke
|
|
// it through node. This stands in for a working hermes binary --
|
|
// verifyHermesCli only cares about the exit code.
|
|
const scriptPath = path.join(os.tmpdir(), `hermes-probes-ok-${Date.now()}-${process.pid}.cjs`)
|
|
fs.writeFileSync(scriptPath, 'process.exit(0)\n')
|
|
try {
|
|
// Use node as the launcher and our script as the "command". Pass
|
|
// shell:false (default) -- node is a real binary, no shim.
|
|
// execFileSync passes ['--version'] as args, which node ignores
|
|
// gracefully (well, it prints its version and exits 0, which is
|
|
// perfect -- exit code 0 is the only signal we read).
|
|
assert.equal(verifyHermesCli(NODE_BIN), true)
|
|
} finally {
|
|
try {
|
|
fs.unlinkSync(scriptPath)
|
|
} catch {}
|
|
}
|
|
})
|
|
|
|
test('verifyHermesCli swallows timeouts (does not throw)', () => {
|
|
// We can't easily provoke a real 5s hang in CI without slowing the
|
|
// suite, but we CAN confirm that an invocation that DOES throw
|
|
// (because the binary is missing) returns false rather than
|
|
// propagating. Same code path the timeout case takes.
|
|
assert.equal(verifyHermesCli('/definitely/not/a/real/binary/anywhere'), false)
|
|
})
|