mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
140 lines
5.1 KiB
Python
140 lines
5.1 KiB
Python
"""
|
|
Tests for document cache utilities in gateway/platforms/base.py.
|
|
|
|
Covers: get_document_cache_dir, cache_document_from_bytes,
|
|
cleanup_document_cache, SUPPORTED_DOCUMENT_TYPES.
|
|
"""
|
|
|
|
import os
|
|
import time
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from gateway.platforms.base import (
|
|
SUPPORTED_DOCUMENT_TYPES,
|
|
cache_document_from_bytes,
|
|
cleanup_document_cache,
|
|
get_document_cache_dir,
|
|
)
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Fixture: redirect DOCUMENT_CACHE_DIR to a temp directory for every test
|
|
# ---------------------------------------------------------------------------
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _redirect_cache(tmp_path, monkeypatch):
|
|
"""Point the module-level DOCUMENT_CACHE_DIR to a fresh tmp_path."""
|
|
monkeypatch.setattr(
|
|
"gateway.platforms.base.DOCUMENT_CACHE_DIR", tmp_path / "doc_cache"
|
|
)
|
|
monkeypatch.setattr(
|
|
"gateway.platforms.base.AUDIO_CACHE_DIR", tmp_path / "audio_cache"
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# TestGetDocumentCacheDir
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestGetDocumentCacheDir:
|
|
def test_creates_directory(self, tmp_path):
|
|
cache_dir = get_document_cache_dir()
|
|
assert cache_dir.exists()
|
|
assert cache_dir.is_dir()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# TestCacheDocumentFromBytes
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestCacheDocumentFromBytes:
|
|
def test_basic_caching(self):
|
|
data = b"hello world"
|
|
path = cache_document_from_bytes(data, "test.txt")
|
|
assert os.path.exists(path)
|
|
assert Path(path).read_bytes() == data
|
|
|
|
def test_filename_preserved_in_path(self):
|
|
path = cache_document_from_bytes(b"data", "report.pdf")
|
|
assert "report.pdf" in os.path.basename(path)
|
|
|
|
def test_empty_filename_uses_fallback(self):
|
|
path = cache_document_from_bytes(b"data", "")
|
|
assert "document" in os.path.basename(path)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# TestCleanupDocumentCache
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestCleanupDocumentCache:
|
|
def test_removes_old_files(self, tmp_path):
|
|
cache_dir = get_document_cache_dir()
|
|
old_file = cache_dir / "old.txt"
|
|
old_file.write_text("old")
|
|
# Set modification time to 48 hours ago
|
|
old_mtime = time.time() - 48 * 3600
|
|
os.utime(old_file, (old_mtime, old_mtime))
|
|
|
|
removed = cleanup_document_cache(max_age_hours=24)
|
|
assert removed == 1
|
|
assert not old_file.exists()
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# TestSupportedDocumentTypes
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestSupportedDocumentTypes:
|
|
def test_all_extensions_have_mime_types(self):
|
|
for ext, mime in SUPPORTED_DOCUMENT_TYPES.items():
|
|
assert ext.startswith("."), f"{ext} missing leading dot"
|
|
assert "/" in mime, f"{mime} is not a valid MIME type"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# TestCacheMediaBytes — the unified, platform-agnostic caching primitive
|
|
# ---------------------------------------------------------------------------
|
|
|
|
# 1x1 transparent PNG (passes cache_image_from_bytes validation)
|
|
_PNG_1PX = bytes.fromhex(
|
|
"89504e470d0a1a0a0000000d49484452000000010000000108060000001f15c4"
|
|
"890000000d49444154789c6360000002000154a24f5f0000000049454e44ae426082"
|
|
)
|
|
|
|
|
|
class TestCacheMediaBytes:
|
|
def test_pdf_routes_to_document(self):
|
|
from gateway.platforms.base import cache_media_bytes
|
|
result = cache_media_bytes(b"%PDF-1.4 body", filename="report.pdf", mime_type="application/pdf")
|
|
assert result is not None
|
|
assert result.kind == "document"
|
|
assert result.media_type == "application/pdf"
|
|
assert "report.pdf" in result.display_name
|
|
assert os.path.exists(result.path)
|
|
assert "report.pdf" in result.context_note()
|
|
|
|
def test_png_routes_to_image(self):
|
|
from gateway.platforms.base import cache_media_bytes
|
|
result = cache_media_bytes(_PNG_1PX, filename="photo.png", mime_type="image/png")
|
|
assert result is not None
|
|
assert result.kind == "image"
|
|
assert result.media_type == "image/png"
|
|
assert os.path.exists(result.path)
|
|
|
|
|
|
def test_unknown_document_cached_as_octet_stream(self):
|
|
"""Unknown file types are cached (not dropped) so the agent can inspect them.
|
|
|
|
Authorization to message the agent is the gate, not the file extension.
|
|
"""
|
|
from gateway.platforms.base import cache_media_bytes
|
|
result = cache_media_bytes(b"MZ", filename="program.exe", mime_type="application/x-msdownload")
|
|
assert result is not None
|
|
assert result.kind == "document"
|
|
# Caller-supplied MIME is preserved when present.
|
|
assert result.media_type == "application/x-msdownload"
|
|
assert os.path.exists(result.path)
|
|
|
|
|