mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-29 06:31:32 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
114 lines
4.4 KiB
Python
114 lines
4.4 KiB
Python
"""Tests for ruff lint config — guards against accidental rule removal.
|
|
|
|
PLW1514 (unspecified-encoding) was enabled after a debug session on
|
|
Windows turned up three separate UTF-8 regressions in execute_code.
|
|
The rule catches bare ``open()`` / ``read_text()`` / ``write_text()``
|
|
calls that default to locale encoding — cp1252 on Windows — which
|
|
silently corrupts non-ASCII content.
|
|
|
|
These tests ensure:
|
|
1. PLW1514 stays in ``[tool.ruff.lint.select]``
|
|
2. The CI workflow's blocking step still invokes ``ruff check .``
|
|
3. pyproject.toml has ``preview = true`` (required — PLW1514 is a
|
|
preview rule in ruff 0.15.x)
|
|
|
|
If someone removes any of these, CI stops enforcing UTF-8-explicit
|
|
opens and we're back to the original Windows-regression trap.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pathlib
|
|
|
|
import pytest
|
|
|
|
try:
|
|
import tomllib # Python 3.11+
|
|
except ImportError: # pragma: no cover — 3.10 and earlier
|
|
import tomli as tomllib # type: ignore
|
|
|
|
REPO_ROOT = pathlib.Path(__file__).resolve().parent.parent
|
|
|
|
|
|
def _load_pyproject() -> dict:
|
|
with open(REPO_ROOT / "pyproject.toml", "rb") as fh:
|
|
return tomllib.load(fh)
|
|
|
|
|
|
class TestRuffConfig:
|
|
def test_plw1514_is_in_select_list(self):
|
|
"""pyproject.toml must keep PLW1514 in [tool.ruff.lint.select]."""
|
|
cfg = _load_pyproject()
|
|
selected = (
|
|
cfg.get("tool", {})
|
|
.get("ruff", {})
|
|
.get("lint", {})
|
|
.get("select", [])
|
|
)
|
|
assert "PLW1514" in selected, (
|
|
"PLW1514 (unspecified-encoding) was removed from "
|
|
"[tool.ruff.lint.select]. This rule blocks bare open() calls "
|
|
"that default to locale encoding on Windows — removing it "
|
|
"re-opens a class of UTF-8 bugs we already paid to close. "
|
|
"If you genuinely want to remove it, delete this test in the "
|
|
"same commit so the intent is deliberate."
|
|
)
|
|
|
|
def test_preview_mode_enabled(self):
|
|
"""PLW1514 is a preview rule in ruff 0.15.x — preview=true is
|
|
required for it to actually run."""
|
|
cfg = _load_pyproject()
|
|
ruff_cfg = cfg.get("tool", {}).get("ruff", {})
|
|
assert ruff_cfg.get("preview") is True, (
|
|
"[tool.ruff] preview=true is required — PLW1514 is a preview "
|
|
"rule and silently becomes a no-op without it. If this ever "
|
|
"becomes a stable rule, you can drop preview=true but must "
|
|
"verify PLW1514 still fires in a sample test run first."
|
|
)
|
|
|
|
|
|
class TestLintWorkflow:
|
|
WORKFLOW_PATH = REPO_ROOT / ".github" / "workflows" / "lint.yml"
|
|
|
|
def test_workflow_exists(self):
|
|
assert self.WORKFLOW_PATH.exists(), (
|
|
f"CI workflow missing: {self.WORKFLOW_PATH}"
|
|
)
|
|
|
|
def test_workflow_has_blocking_ruff_step(self):
|
|
"""The workflow must run a blocking ``ruff check .`` step
|
|
(one without --exit-zero) so violations fail the job."""
|
|
content = self.WORKFLOW_PATH.read_text(encoding="utf-8")
|
|
# Look for the blocking step's named line + its command. We want
|
|
# at least one ``ruff check .`` that does NOT have ``--exit-zero``
|
|
# nearby.
|
|
# Split into lines and find ruff check invocations
|
|
lines = content.splitlines()
|
|
found_blocking = False
|
|
for i, line in enumerate(lines):
|
|
stripped = line.strip()
|
|
if stripped.startswith("ruff check") and "--exit-zero" not in stripped:
|
|
# Also check it's not piped to `|| true` which would mask
|
|
# the exit code.
|
|
window = " ".join(lines[i:i + 3])
|
|
if "|| true" not in window:
|
|
found_blocking = True
|
|
break
|
|
assert found_blocking, (
|
|
"lint.yml no longer contains a blocking ``ruff check .`` step "
|
|
"(one without --exit-zero and not masked by || true). "
|
|
"Restore it — the PLW1514 rule is only useful if CI actually "
|
|
"fails on violation."
|
|
)
|
|
|
|
def test_workflow_yaml_is_valid(self):
|
|
"""Workflow file must parse as valid YAML (can't ship a broken
|
|
CI config to main)."""
|
|
import yaml
|
|
content = self.WORKFLOW_PATH.read_text(encoding="utf-8")
|
|
try:
|
|
parsed = yaml.safe_load(content)
|
|
except yaml.YAMLError as exc:
|
|
pytest.fail(f"lint.yml is not valid YAML: {exc}")
|
|
assert isinstance(parsed, dict)
|
|
assert "jobs" in parsed
|