mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-29 06:31:32 +00:00
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
43 lines
1.7 KiB
Python
43 lines
1.7 KiB
Python
"""Regression test for #25676 — nested gateway.streaming config must be loaded."""
|
|
from pathlib import Path
|
|
from unittest.mock import patch, MagicMock
|
|
|
|
|
|
|
|
def _load_with_yaml_dict(yaml_dict: dict):
|
|
"""Patch filesystem so load_gateway_config() sees *yaml_dict* as config.yaml."""
|
|
from gateway.config import load_gateway_config
|
|
|
|
fake_home = Path("/tmp/fake_hermes_home_25676")
|
|
|
|
def fake_exists(self):
|
|
return str(self).endswith("config.yaml")
|
|
|
|
with patch("gateway.config.get_hermes_home", return_value=fake_home), \
|
|
patch.object(Path, "exists", fake_exists), \
|
|
patch("builtins.open", create=True) as mock_file:
|
|
mock_file.return_value.__enter__ = lambda s: s
|
|
mock_file.return_value.__exit__ = MagicMock(return_value=False)
|
|
with patch("yaml.safe_load", return_value=yaml_dict):
|
|
return load_gateway_config()
|
|
|
|
|
|
class TestStreamingConfigNested:
|
|
def test_top_level_streaming(self):
|
|
cfg = _load_with_yaml_dict({"streaming": {"enabled": True, "transport": "draft"}})
|
|
assert cfg.streaming.enabled is True
|
|
assert cfg.streaming.transport == "draft"
|
|
|
|
def test_nested_gateway_streaming(self):
|
|
"""Regression for #25676."""
|
|
cfg = _load_with_yaml_dict({"gateway": {"streaming": {"enabled": True, "transport": "draft"}}})
|
|
assert cfg.streaming.enabled is True
|
|
assert cfg.streaming.transport == "draft"
|
|
|
|
def test_top_level_takes_precedence(self):
|
|
cfg = _load_with_yaml_dict({
|
|
"streaming": {"enabled": True, "transport": "edit"},
|
|
"gateway": {"streaming": {"enabled": False, "transport": "draft"}},
|
|
})
|
|
assert cfg.streaming.enabled is True
|
|
assert cfg.streaming.transport == "edit"
|