mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-29 06:31:32 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
114 lines
4.2 KiB
Python
114 lines
4.2 KiB
Python
"""Tests that invalid context_length values in config produce visible warnings."""
|
|
|
|
from unittest.mock import patch
|
|
|
|
|
|
def _build_agent(model_cfg, custom_providers=None, model="anthropic/claude-opus-4.6"):
|
|
"""Build an AIAgent with the given model config."""
|
|
cfg = {"model": model_cfg}
|
|
if custom_providers is not None:
|
|
cfg["custom_providers"] = custom_providers
|
|
|
|
base_url = model_cfg.get("base_url", "")
|
|
|
|
with (
|
|
patch("hermes_cli.config.load_config", return_value=cfg),
|
|
patch("agent.model_metadata.get_model_context_length", return_value=128_000),
|
|
patch("run_agent.get_tool_definitions", return_value=[]),
|
|
patch("run_agent.check_toolset_requirements", return_value={}),
|
|
patch("run_agent.OpenAI"),
|
|
):
|
|
from run_agent import AIAgent
|
|
|
|
agent = AIAgent(
|
|
model=model,
|
|
api_key="test-key-1234567890",
|
|
base_url=base_url,
|
|
quiet_mode=True,
|
|
skip_context_files=True,
|
|
skip_memory=True,
|
|
)
|
|
return agent
|
|
|
|
|
|
def test_valid_integer_context_length_no_warning():
|
|
"""Plain integer context_length should work silently."""
|
|
with patch("run_agent.logger") as mock_logger:
|
|
agent = _build_agent({"default": "gpt5.4", "provider": "custom",
|
|
"base_url": "http://localhost:4000/v1",
|
|
"context_length": 256000})
|
|
assert agent._config_context_length == 256000
|
|
# No warning about invalid context_length
|
|
for c in mock_logger.warning.call_args_list:
|
|
assert "Invalid" not in str(c)
|
|
|
|
|
|
def test_string_k_suffix_context_length_warns():
|
|
"""context_length: '256K' should warn the user clearly."""
|
|
with patch("run_agent.logger") as mock_logger:
|
|
agent = _build_agent({"default": "gpt5.4", "provider": "custom",
|
|
"base_url": "http://localhost:4000/v1",
|
|
"context_length": "256K"})
|
|
assert agent._config_context_length is None
|
|
# Should have warned
|
|
warning_calls = [c for c in mock_logger.warning.call_args_list
|
|
if "Invalid" in str(c) and "256K" in str(c)]
|
|
assert len(warning_calls) == 1
|
|
assert "plain integer" in str(warning_calls[0])
|
|
|
|
|
|
def test_string_numeric_context_length_works():
|
|
"""context_length: '256000' (string) should parse fine via int()."""
|
|
with patch("run_agent.logger") as mock_logger:
|
|
agent = _build_agent({"default": "gpt5.4", "provider": "custom",
|
|
"base_url": "http://localhost:4000/v1",
|
|
"context_length": "256000"})
|
|
assert agent._config_context_length == 256000
|
|
for c in mock_logger.warning.call_args_list:
|
|
assert "Invalid" not in str(c)
|
|
|
|
|
|
def test_custom_providers_invalid_context_length_warns():
|
|
"""Invalid context_length in custom_providers should warn."""
|
|
custom_providers = [
|
|
{
|
|
"name": "LiteLLM",
|
|
"base_url": "http://localhost:4000/v1",
|
|
"models": {
|
|
"gpt5.4": {"context_length": "256K"}
|
|
},
|
|
}
|
|
]
|
|
with patch("run_agent.logger") as mock_logger:
|
|
agent = _build_agent(
|
|
{"default": "gpt5.4", "provider": "custom",
|
|
"base_url": "http://localhost:4000/v1"},
|
|
custom_providers=custom_providers,
|
|
model="gpt5.4",
|
|
)
|
|
warning_calls = [c for c in mock_logger.warning.call_args_list
|
|
if "Invalid" in str(c) and "256K" in str(c)]
|
|
assert len(warning_calls) == 1
|
|
assert "custom_providers" in str(warning_calls[0])
|
|
|
|
|
|
def test_custom_providers_valid_context_length():
|
|
"""Valid integer in custom_providers should work silently."""
|
|
custom_providers = [
|
|
{
|
|
"name": "LiteLLM",
|
|
"base_url": "http://localhost:4000/v1",
|
|
"models": {
|
|
"gpt5.4": {"context_length": 256000}
|
|
},
|
|
}
|
|
]
|
|
with patch("run_agent.logger") as mock_logger:
|
|
agent = _build_agent(
|
|
{"default": "gpt5.4", "provider": "custom",
|
|
"base_url": "http://localhost:4000/v1"},
|
|
custom_providers=custom_providers,
|
|
model="gpt5.4",
|
|
)
|
|
for c in mock_logger.warning.call_args_list:
|
|
assert "Invalid" not in str(c)
|