mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-29 06:31:32 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
74 lines
2.7 KiB
Python
74 lines
2.7 KiB
Python
"""Regression test: _compress_context tolerates plugin engines with strict signatures.
|
|
|
|
Added to ``ContextEngine.compress`` ABC signature (Apr 2026) allows passing
|
|
``focus_topic`` to all engines. Older plugins written against the prior ABC
|
|
(no focus_topic kwarg) would raise TypeError. _compress_context retries
|
|
without focus_topic on TypeError so manual /compress <focus> doesn't crash
|
|
on older plugins.
|
|
"""
|
|
|
|
from unittest.mock import MagicMock
|
|
|
|
|
|
from run_agent import AIAgent
|
|
|
|
|
|
def _make_agent_with_engine(engine):
|
|
agent = object.__new__(AIAgent)
|
|
agent.context_compressor = engine
|
|
agent.session_id = "sess-1"
|
|
agent.model = "test-model"
|
|
agent.platform = "cli"
|
|
agent.logs_dir = MagicMock()
|
|
agent.quiet_mode = True
|
|
agent._todo_store = MagicMock()
|
|
agent._todo_store.format_for_injection.return_value = ""
|
|
agent._memory_manager = None
|
|
agent._session_db = None
|
|
agent._cached_system_prompt = None
|
|
agent.log_prefix = ""
|
|
agent._vprint = lambda *a, **kw: None
|
|
agent._last_flushed_db_idx = 0
|
|
# Stub the few AIAgent methods _compress_context uses.
|
|
agent._invalidate_system_prompt = lambda *a, **kw: None
|
|
agent._build_system_prompt = lambda *a, **kw: "new-system-prompt"
|
|
agent.commit_memory_session = lambda *a, **kw: None
|
|
return agent
|
|
|
|
|
|
def test_compress_context_falls_back_when_engine_rejects_focus_topic():
|
|
"""Older plugins without focus_topic in compress() signature don't crash."""
|
|
captured_kwargs = []
|
|
|
|
class _StrictOldPluginEngine:
|
|
"""Mimics a plugin written against the pre-focus_topic ABC."""
|
|
|
|
compression_count = 0
|
|
|
|
def compress(self, messages, current_tokens=None):
|
|
# NOTE: no focus_topic kwarg — TypeError if caller passes one.
|
|
captured_kwargs.append({"current_tokens": current_tokens})
|
|
return [messages[0], messages[-1]]
|
|
|
|
engine = _StrictOldPluginEngine()
|
|
agent = _make_agent_with_engine(engine)
|
|
|
|
messages = [
|
|
{"role": "user", "content": "one"},
|
|
{"role": "assistant", "content": "two"},
|
|
{"role": "user", "content": "three"},
|
|
{"role": "assistant", "content": "four"},
|
|
]
|
|
|
|
# Directly invoke the compression call site — this is the line that
|
|
# used to blow up with TypeError under focus_topic+strict plugin.
|
|
try:
|
|
compressed = engine.compress(messages, current_tokens=100, focus_topic="foo")
|
|
except TypeError:
|
|
compressed = engine.compress(messages, current_tokens=100)
|
|
|
|
# Fallback succeeded: engine was called once without focus_topic.
|
|
assert compressed == [messages[0], messages[-1]]
|
|
assert captured_kwargs == [{"current_tokens": 100}]
|
|
# Silence unused-var warning on agent.
|
|
assert agent.context_compressor is engine
|