mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-29 06:31:32 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
127 lines
3.2 KiB
Python
127 lines
3.2 KiB
Python
"""
|
|
Tests for --yes / --force flag separation in `hermes skills install`.
|
|
|
|
--yes / -y → skip_confirm (bypass interactive prompt, needed in TUI mode)
|
|
--force → force (install despite blocked scan verdict)
|
|
|
|
Based on PR #1595 by 333Alden333 (salvaged).
|
|
"""
|
|
|
|
import sys
|
|
|
|
|
|
def test_cli_skills_install_yes_sets_skip_confirm(monkeypatch):
|
|
"""--yes should set skip_confirm=True but NOT force."""
|
|
from hermes_cli.main import main
|
|
|
|
captured = {}
|
|
|
|
def fake_skills_command(args):
|
|
captured["identifier"] = args.identifier
|
|
captured["force"] = args.force
|
|
captured["yes"] = args.yes
|
|
|
|
monkeypatch.setattr("hermes_cli.skills_hub.skills_command", fake_skills_command)
|
|
monkeypatch.setattr(
|
|
sys,
|
|
"argv",
|
|
["hermes", "skills", "install", "official/email/agentmail", "--yes"],
|
|
)
|
|
|
|
main()
|
|
|
|
assert captured["identifier"] == "official/email/agentmail"
|
|
assert captured["yes"] is True
|
|
assert captured["force"] is False
|
|
|
|
|
|
def test_cli_skills_install_y_alias(monkeypatch):
|
|
"""-y should behave the same as --yes."""
|
|
from hermes_cli.main import main
|
|
|
|
captured = {}
|
|
|
|
def fake_skills_command(args):
|
|
captured["yes"] = args.yes
|
|
captured["force"] = args.force
|
|
|
|
monkeypatch.setattr("hermes_cli.skills_hub.skills_command", fake_skills_command)
|
|
monkeypatch.setattr(
|
|
sys,
|
|
"argv",
|
|
["hermes", "skills", "install", "test/skill", "-y"],
|
|
)
|
|
|
|
main()
|
|
|
|
assert captured["yes"] is True
|
|
assert captured["force"] is False
|
|
|
|
|
|
def test_cli_skills_install_force_sets_force(monkeypatch):
|
|
"""--force should set force=True but NOT yes."""
|
|
from hermes_cli.main import main
|
|
|
|
captured = {}
|
|
|
|
def fake_skills_command(args):
|
|
captured["force"] = args.force
|
|
captured["yes"] = args.yes
|
|
|
|
monkeypatch.setattr("hermes_cli.skills_hub.skills_command", fake_skills_command)
|
|
monkeypatch.setattr(
|
|
sys,
|
|
"argv",
|
|
["hermes", "skills", "install", "test/skill", "--force"],
|
|
)
|
|
|
|
main()
|
|
|
|
assert captured["force"] is True
|
|
assert captured["yes"] is False
|
|
|
|
|
|
def test_cli_skills_install_force_and_yes_together(monkeypatch):
|
|
"""--force --yes should set both flags."""
|
|
from hermes_cli.main import main
|
|
|
|
captured = {}
|
|
|
|
def fake_skills_command(args):
|
|
captured["force"] = args.force
|
|
captured["yes"] = args.yes
|
|
|
|
monkeypatch.setattr("hermes_cli.skills_hub.skills_command", fake_skills_command)
|
|
monkeypatch.setattr(
|
|
sys,
|
|
"argv",
|
|
["hermes", "skills", "install", "test/skill", "--force", "--yes"],
|
|
)
|
|
|
|
main()
|
|
|
|
assert captured["force"] is True
|
|
assert captured["yes"] is True
|
|
|
|
|
|
def test_cli_skills_install_no_flags(monkeypatch):
|
|
"""Without flags, both force and yes should be False."""
|
|
from hermes_cli.main import main
|
|
|
|
captured = {}
|
|
|
|
def fake_skills_command(args):
|
|
captured["force"] = args.force
|
|
captured["yes"] = args.yes
|
|
|
|
monkeypatch.setattr("hermes_cli.skills_hub.skills_command", fake_skills_command)
|
|
monkeypatch.setattr(
|
|
sys,
|
|
"argv",
|
|
["hermes", "skills", "install", "test/skill"],
|
|
)
|
|
|
|
main()
|
|
|
|
assert captured["force"] is False
|
|
assert captured["yes"] is False
|