mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-29 06:31:32 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
61 lines
2.7 KiB
Python
61 lines
2.7 KiB
Python
from unittest.mock import patch
|
|
|
|
|
|
def test_pip_install_detected_when_no_git_dir(tmp_path):
|
|
"""When PROJECT_ROOT has no .git, detect as pip install."""
|
|
with patch("hermes_cli.config.get_managed_system", return_value=None), \
|
|
patch("hermes_cli.config.get_hermes_home", return_value=tmp_path):
|
|
from hermes_cli.config import detect_install_method
|
|
method = detect_install_method(project_root=tmp_path)
|
|
assert method == "pip"
|
|
|
|
|
|
def test_git_install_detected_when_git_dir_exists(tmp_path):
|
|
"""When PROJECT_ROOT has .git, detect as git install."""
|
|
(tmp_path / ".git").mkdir()
|
|
with patch("hermes_cli.config.get_managed_system", return_value=None), \
|
|
patch("hermes_cli.config.get_hermes_home", return_value=tmp_path):
|
|
from hermes_cli.config import detect_install_method
|
|
method = detect_install_method(project_root=tmp_path)
|
|
assert method == "git"
|
|
|
|
|
|
def test_managed_install_takes_precedence(tmp_path):
|
|
"""When HERMES_MANAGED is set, that takes precedence over git detection."""
|
|
(tmp_path / ".git").mkdir()
|
|
with patch("hermes_cli.config.get_managed_system", return_value="NixOS"), \
|
|
patch("hermes_cli.config.get_hermes_home", return_value=tmp_path):
|
|
from hermes_cli.config import detect_install_method
|
|
method = detect_install_method(project_root=tmp_path)
|
|
assert method == "nixos"
|
|
|
|
|
|
def test_recommended_update_command_pip():
|
|
"""Pip installs recommend pip install --upgrade."""
|
|
from hermes_cli.config import recommended_update_command_for_method
|
|
cmd = recommended_update_command_for_method("pip")
|
|
assert "pip install" in cmd or "uv pip install" in cmd
|
|
assert "--upgrade" in cmd
|
|
assert "hermes-agent" in cmd
|
|
|
|
|
|
def test_stamp_file_takes_precedence(tmp_path):
|
|
(tmp_path / ".git").mkdir()
|
|
(tmp_path / ".install_method").write_text("docker\n")
|
|
with patch("hermes_cli.config.get_managed_system", return_value=None), \
|
|
patch("hermes_cli.config.get_hermes_home", return_value=tmp_path):
|
|
from hermes_cli.config import detect_install_method
|
|
assert detect_install_method(project_root=tmp_path) == "docker"
|
|
|
|
|
|
def test_docker_detected_via_dockerenv(tmp_path):
|
|
with patch("hermes_cli.config.get_managed_system", return_value=None), \
|
|
patch("hermes_cli.config.get_hermes_home", return_value=tmp_path), \
|
|
patch("hermes_constants.is_container", return_value=True):
|
|
from hermes_cli.config import detect_install_method
|
|
assert detect_install_method(project_root=tmp_path) == "docker"
|
|
|
|
|
|
def test_recommended_update_command_docker():
|
|
from hermes_cli.config import recommended_update_command_for_method
|
|
assert "docker pull" in recommended_update_command_for_method("docker")
|