mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-29 06:31:32 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
30 lines
1.4 KiB
Python
30 lines
1.4 KiB
Python
from unittest.mock import patch
|
|
|
|
|
|
def test_service_path_skips_nonexistent_node_modules(tmp_path):
|
|
"""Service PATH should not include node_modules/.bin if it doesn't exist."""
|
|
from hermes_cli.gateway import _build_service_path_dirs
|
|
with patch("hermes_cli.gateway.get_hermes_home", return_value=tmp_path / ".hermes"):
|
|
dirs = _build_service_path_dirs(project_root=tmp_path)
|
|
node_modules_bin = str(tmp_path / "node_modules" / ".bin")
|
|
assert node_modules_bin not in dirs
|
|
|
|
|
|
def test_service_path_includes_node_modules_when_present(tmp_path):
|
|
"""Service PATH should include node_modules/.bin when it exists."""
|
|
nm_bin = tmp_path / "node_modules" / ".bin"
|
|
nm_bin.mkdir(parents=True)
|
|
from hermes_cli.gateway import _build_service_path_dirs
|
|
with patch("hermes_cli.gateway.get_hermes_home", return_value=tmp_path / ".hermes"):
|
|
dirs = _build_service_path_dirs(project_root=tmp_path)
|
|
assert str(nm_bin) in dirs
|
|
|
|
|
|
def test_service_path_includes_hermes_home_node_modules(tmp_path):
|
|
"""Service PATH should include ~/.hermes/node_modules/.bin when it exists."""
|
|
hermes_nm = tmp_path / ".hermes" / "node_modules" / ".bin"
|
|
hermes_nm.mkdir(parents=True)
|
|
from hermes_cli.gateway import _build_service_path_dirs
|
|
with patch("hermes_cli.gateway.get_hermes_home", return_value=tmp_path / ".hermes"):
|
|
dirs = _build_service_path_dirs(project_root=tmp_path)
|
|
assert str(hermes_nm) in dirs
|