mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-29 06:31:32 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
60 lines
2.5 KiB
Python
60 lines
2.5 KiB
Python
"""Host-specific gating in ``hermes_cli.gateway._all_platforms()``.
|
|
|
|
Some messaging platforms can't function on every host. The gate lives
|
|
in one place — ``_all_platforms()`` — so the setup wizard, the curses
|
|
gateway-config menu, and any future picker all see the same filtered
|
|
list.
|
|
|
|
Currently:
|
|
- Matrix is hidden on Windows. The ``[matrix]`` extra pulls
|
|
``mautrix[encryption]`` -> ``python-olm``, which has no Windows wheel
|
|
and needs ``make`` + libolm to build from sdist. There's no native
|
|
Windows path that works.
|
|
"""
|
|
|
|
|
|
|
|
class TestMatrixHiddenOnWindows:
|
|
def test_matrix_present_on_linux(self, monkeypatch):
|
|
"""Sanity: matrix is still in the picker on Linux/macOS."""
|
|
import hermes_cli.gateway as gateway_mod
|
|
|
|
monkeypatch.setattr(gateway_mod.sys, "platform", "linux")
|
|
platforms = gateway_mod._all_platforms()
|
|
keys = {p["key"] for p in platforms}
|
|
assert "matrix" in keys, "matrix must be available on Linux"
|
|
|
|
def test_matrix_present_on_macos(self, monkeypatch):
|
|
import hermes_cli.gateway as gateway_mod
|
|
|
|
monkeypatch.setattr(gateway_mod.sys, "platform", "darwin")
|
|
platforms = gateway_mod._all_platforms()
|
|
keys = {p["key"] for p in platforms}
|
|
assert "matrix" in keys, "matrix must be available on macOS"
|
|
|
|
def test_matrix_hidden_on_windows(self, monkeypatch):
|
|
"""The actual gate: matrix must NOT appear on Windows."""
|
|
import hermes_cli.gateway as gateway_mod
|
|
|
|
monkeypatch.setattr(gateway_mod.sys, "platform", "win32")
|
|
platforms = gateway_mod._all_platforms()
|
|
keys = {p["key"] for p in platforms}
|
|
assert "matrix" not in keys, (
|
|
"matrix must be hidden on Windows — python-olm has no "
|
|
"Windows wheel and no native build path"
|
|
)
|
|
|
|
def test_other_platforms_unaffected_on_windows(self, monkeypatch):
|
|
"""Gating must only drop matrix, not collateral damage."""
|
|
import hermes_cli.gateway as gateway_mod
|
|
|
|
monkeypatch.setattr(gateway_mod.sys, "platform", "win32")
|
|
platforms = gateway_mod._all_platforms()
|
|
keys = {p["key"] for p in platforms}
|
|
# A representative sample of platforms that have no Windows
|
|
# blockers — picker should still surface them.
|
|
for must_have in ("telegram", "discord", "slack", "mattermost"):
|
|
assert must_have in keys, (
|
|
f"{must_have} disappeared from Windows picker — gate is "
|
|
"over-filtering"
|
|
)
|