mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-29 06:31:32 +00:00
66827f8947
Remove unused imports (F401) and duplicate/shadowed import redefinitions (F811) across the codebase using ruff's safe autofixes. No behavioral changes -- imports only. - ~1400 safe autofixes applied across 644 files (net -1072 lines) - __init__.py re-exports preserved (excluded from F401 removal so public re-export surfaces stay intact) - Re-exports that are imported or monkeypatched by tests but look unused in their defining module are kept with explicit # noqa: F401 (gateway/run.py load_dotenv; run_agent re-exports from agent.message_sanitization, agent.context_compressor, agent.retry_utils, agent.prompt_builder, agent.process_bootstrap, agent.codex_responses_adapter) - Unsafe F841 (unused-variable) fixes deliberately skipped -- those can change behavior when the RHS has side effects - ruff lints remain disabled in pyproject.toml (only PLW1514 is selected); this is a one-time cleanup, not a config change Verification: - python -m compileall: clean - pytest --collect-only: all 27161 tests collect (zero import errors) - core entry points import clean (run_agent, model_tools, cli, toolsets, hermes_state, batch_runner, gateway) - static scan: every name any test imports directly from an edited module still resolves
62 lines
2.5 KiB
Python
62 lines
2.5 KiB
Python
"""Tests for warn_deprecated_cwd_env_vars() migration warning."""
|
|
|
|
|
|
|
|
class TestDeprecatedCwdWarning:
|
|
"""Warn when MESSAGING_CWD or TERMINAL_CWD is set in .env."""
|
|
|
|
def test_messaging_cwd_triggers_warning(self, monkeypatch, capsys):
|
|
monkeypatch.setenv("MESSAGING_CWD", "/some/path")
|
|
monkeypatch.delenv("TERMINAL_CWD", raising=False)
|
|
|
|
from hermes_cli.config import warn_deprecated_cwd_env_vars
|
|
warn_deprecated_cwd_env_vars(config={})
|
|
|
|
captured = capsys.readouterr()
|
|
assert "MESSAGING_CWD" in captured.err
|
|
assert "deprecated" in captured.err.lower()
|
|
assert "config.yaml" in captured.err
|
|
|
|
def test_terminal_cwd_triggers_warning_when_config_placeholder(self, monkeypatch, capsys):
|
|
monkeypatch.setenv("TERMINAL_CWD", "/project")
|
|
monkeypatch.delenv("MESSAGING_CWD", raising=False)
|
|
|
|
from hermes_cli.config import warn_deprecated_cwd_env_vars
|
|
# config has placeholder cwd → TERMINAL_CWD likely from .env
|
|
warn_deprecated_cwd_env_vars(config={"terminal": {"cwd": "."}})
|
|
|
|
captured = capsys.readouterr()
|
|
assert "TERMINAL_CWD" in captured.err
|
|
assert "deprecated" in captured.err.lower()
|
|
|
|
def test_no_warning_when_config_has_explicit_cwd(self, monkeypatch, capsys):
|
|
monkeypatch.setenv("TERMINAL_CWD", "/project")
|
|
monkeypatch.delenv("MESSAGING_CWD", raising=False)
|
|
|
|
from hermes_cli.config import warn_deprecated_cwd_env_vars
|
|
# config has explicit cwd → TERMINAL_CWD could be from config bridge
|
|
warn_deprecated_cwd_env_vars(config={"terminal": {"cwd": "/project"}})
|
|
|
|
captured = capsys.readouterr()
|
|
assert "TERMINAL_CWD" not in captured.err
|
|
|
|
def test_no_warning_when_env_clean(self, monkeypatch, capsys):
|
|
monkeypatch.delenv("MESSAGING_CWD", raising=False)
|
|
monkeypatch.delenv("TERMINAL_CWD", raising=False)
|
|
|
|
from hermes_cli.config import warn_deprecated_cwd_env_vars
|
|
warn_deprecated_cwd_env_vars(config={})
|
|
|
|
captured = capsys.readouterr()
|
|
assert captured.err == ""
|
|
|
|
def test_both_deprecated_vars_warn(self, monkeypatch, capsys):
|
|
monkeypatch.setenv("MESSAGING_CWD", "/msg/path")
|
|
monkeypatch.setenv("TERMINAL_CWD", "/term/path")
|
|
|
|
from hermes_cli.config import warn_deprecated_cwd_env_vars
|
|
warn_deprecated_cwd_env_vars(config={})
|
|
|
|
captured = capsys.readouterr()
|
|
assert "MESSAGING_CWD" in captured.err
|
|
assert "TERMINAL_CWD" in captured.err
|