mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
Addresses teknium1 review on #50983: - cli.py's `hermes photon status` and adapter.py's _start_sidecar() still used the old node_modules/-existence check while check_requirements() had moved to a spectrum-ts content check. Extracted the check into a shared sidecar_deps_installed(), used by all three, so an empty/partial node_modules/ (aborted npm install) is rejected consistently instead of only in check_requirements(). - _install_sidecar()'s success-path _NPM_ERROR_LOG.unlink() only caught FileNotFoundError, so a PermissionError/OSError on a locked file would propagate. Broadened to OSError. - npm stderr was truncated only when read back in check_requirements(); an unbounded stderr was written to disk on every failed install. Now truncated to _NPM_ERROR_LOG_MAX_CHARS before write_text(). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| test_auth.py | ||
| test_check_requirements_risks.py | ||
| test_inbound.py | ||
| test_markdown.py | ||
| test_mention_gating.py | ||
| test_npm_error_log_regression.py | ||
| test_outbound_media.py | ||
| test_overflow_recovery.py | ||
| test_reactions.py | ||
| test_setup_access.py | ||
| test_sidecar_deps_stale.py | ||
| test_sidecar_lifecycle.py | ||
| test_spectrum_patch.py | ||
| test_streaming.py | ||