mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
108 lines
4.2 KiB
Python
108 lines
4.2 KiB
Python
"""Tests for hermes_cli.copilot_auth — Copilot token validation and resolution."""
|
|
|
|
import pytest
|
|
from unittest.mock import patch
|
|
|
|
|
|
class TestTokenValidation:
|
|
"""Token type validation."""
|
|
|
|
def test_classic_pat_rejected(self):
|
|
from hermes_cli.copilot_auth import validate_copilot_token
|
|
valid, msg = validate_copilot_token("ghp_abcdefghijklmnop1234")
|
|
assert valid is False
|
|
assert "Classic Personal Access Tokens" in msg
|
|
assert "ghp_" in msg
|
|
|
|
|
|
class TestResolveToken:
|
|
"""Token resolution with env var priority."""
|
|
|
|
|
|
def test_gh_token_second_priority(self, monkeypatch):
|
|
from hermes_cli.copilot_auth import resolve_copilot_token
|
|
monkeypatch.delenv("COPILOT_GITHUB_TOKEN", raising=False)
|
|
monkeypatch.setenv("GH_TOKEN", "gho_gh_second")
|
|
monkeypatch.setenv("GITHUB_TOKEN", "gho_github_third")
|
|
token, source = resolve_copilot_token()
|
|
assert token == "gho_gh_second"
|
|
assert source == "GH_TOKEN"
|
|
|
|
|
|
|
|
|
|
def test_gh_cli_classic_pat_raises(self, monkeypatch):
|
|
from hermes_cli.copilot_auth import resolve_copilot_token
|
|
monkeypatch.delenv("COPILOT_GITHUB_TOKEN", raising=False)
|
|
monkeypatch.delenv("GH_TOKEN", raising=False)
|
|
monkeypatch.delenv("GITHUB_TOKEN", raising=False)
|
|
with patch("hermes_cli.copilot_auth._try_gh_cli_token", return_value="ghp_classic"):
|
|
with pytest.raises(ValueError, match="classic PAT"):
|
|
resolve_copilot_token()
|
|
|
|
|
|
class TestRequestHeaders:
|
|
"""Copilot API header generation."""
|
|
|
|
def test_default_headers_include_openai_intent(self):
|
|
from hermes_cli.copilot_auth import copilot_request_headers
|
|
headers = copilot_request_headers()
|
|
assert headers["Openai-Intent"] == "conversation-edits"
|
|
assert headers["User-Agent"] == "HermesAgent/1.0"
|
|
assert "Editor-Version" in headers
|
|
|
|
|
|
def test_no_vision_header_by_default(self):
|
|
from hermes_cli.copilot_auth import copilot_request_headers
|
|
headers = copilot_request_headers()
|
|
assert "Copilot-Vision-Request" not in headers
|
|
|
|
|
|
class TestCopilotDefaultHeaders:
|
|
"""The models.py copilot_default_headers uses copilot_auth."""
|
|
|
|
|
|
def test_agent_turn_explicit(self):
|
|
"""Explicitly passing is_agent_turn=True sets x-initiator to 'agent'."""
|
|
from hermes_cli.models import copilot_default_headers
|
|
headers = copilot_default_headers(is_agent_turn=True)
|
|
assert headers["x-initiator"] == "agent"
|
|
|
|
def test_param_passthrough_both_values(self):
|
|
"""is_agent_turn param correctly maps to x-initiator for both True and False."""
|
|
from hermes_cli.models import copilot_default_headers
|
|
for is_agent, expected in [(True, "agent"), (False, "user")]:
|
|
headers = copilot_default_headers(is_agent_turn=is_agent)
|
|
assert headers["x-initiator"] == expected, (
|
|
f"is_agent_turn={is_agent} should produce x-initiator={expected!r}, "
|
|
f"got {headers['x-initiator']!r}"
|
|
)
|
|
|
|
|
|
class TestApiModeSelection:
|
|
"""API mode selection matching opencode's shouldUseCopilotResponsesApi."""
|
|
|
|
def test_gpt5_uses_responses(self):
|
|
from hermes_cli.models import _should_use_copilot_responses_api
|
|
assert _should_use_copilot_responses_api("gpt-5.4") is True
|
|
assert _should_use_copilot_responses_api("gpt-5.4-mini") is True
|
|
assert _should_use_copilot_responses_api("gpt-5.3-codex") is True
|
|
assert _should_use_copilot_responses_api("gpt-5.2-codex") is True
|
|
assert _should_use_copilot_responses_api("gpt-5.2") is True
|
|
assert _should_use_copilot_responses_api("gpt-5.1-codex-max") is True
|
|
|
|
def test_gpt5_mini_excluded(self):
|
|
from hermes_cli.models import _should_use_copilot_responses_api
|
|
assert _should_use_copilot_responses_api("gpt-5-mini") is False
|
|
|
|
|
|
class TestEnvVarOrder:
|
|
"""PROVIDER_REGISTRY has correct env var order."""
|
|
|
|
def test_copilot_env_vars_include_copilot_github_token(self):
|
|
from hermes_cli.auth import PROVIDER_REGISTRY
|
|
copilot = PROVIDER_REGISTRY["copilot"]
|
|
assert "COPILOT_GITHUB_TOKEN" in copilot.api_key_env_vars
|
|
# COPILOT_GITHUB_TOKEN should be first
|
|
assert copilot.api_key_env_vars[0] == "COPILOT_GITHUB_TOKEN"
|
|
|