mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
9725b452a1
Follow-up for PR #12252 salvage: - Extract 75-line inline repair block to _repair_tool_call_arguments() module-level helper for testability and readability - Remove redundant 'import re as _re' (re already imported at line 33) - Bound the while-True excess-delimiter removal loop to 50 iterations - Add 17 tests covering all 6 repair stages - Add sirEven to AUTHOR_MAP in release.py
107 lines
4 KiB
Python
107 lines
4 KiB
Python
"""Tests for _repair_tool_call_arguments — malformed JSON repair pipeline."""
|
|
|
|
import json
|
|
import pytest
|
|
|
|
from run_agent import _repair_tool_call_arguments
|
|
|
|
|
|
class TestRepairToolCallArguments:
|
|
"""Verify each repair stage in the pipeline."""
|
|
|
|
# -- Stage 1: empty / whitespace-only --
|
|
|
|
def test_empty_string_returns_empty_object(self):
|
|
assert _repair_tool_call_arguments("", "t") == "{}"
|
|
|
|
def test_whitespace_only_returns_empty_object(self):
|
|
assert _repair_tool_call_arguments(" \n\t ", "t") == "{}"
|
|
|
|
def test_none_type_returns_empty_object(self):
|
|
"""Non-string input (e.g. None from a broken model response)."""
|
|
assert _repair_tool_call_arguments(None, "t") == "{}"
|
|
|
|
# -- Stage 2: Python None literal --
|
|
|
|
def test_python_none_literal(self):
|
|
assert _repair_tool_call_arguments("None", "t") == "{}"
|
|
|
|
def test_python_none_with_whitespace(self):
|
|
assert _repair_tool_call_arguments(" None ", "t") == "{}"
|
|
|
|
# -- Stage 3: trailing comma repair --
|
|
|
|
def test_trailing_comma_in_object(self):
|
|
result = _repair_tool_call_arguments('{"key": "value",}', "t")
|
|
assert json.loads(result) == {"key": "value"}
|
|
|
|
def test_trailing_comma_in_array(self):
|
|
result = _repair_tool_call_arguments('{"a": [1, 2,]}', "t")
|
|
parsed = json.loads(result)
|
|
assert parsed == {"a": [1, 2]}
|
|
|
|
def test_multiple_trailing_commas(self):
|
|
result = _repair_tool_call_arguments('{"a": 1, "b": 2,}', "t")
|
|
parsed = json.loads(result)
|
|
assert parsed["a"] == 1
|
|
assert parsed["b"] == 2
|
|
|
|
# -- Stage 4: unclosed brackets --
|
|
|
|
def test_unclosed_brace(self):
|
|
result = _repair_tool_call_arguments('{"key": "value"', "t")
|
|
parsed = json.loads(result)
|
|
assert parsed == {"key": "value"}
|
|
|
|
def test_unclosed_bracket_and_brace(self):
|
|
result = _repair_tool_call_arguments('{"a": [1, 2', "t")
|
|
# Bracket counting adds ']' then '}', producing {"a": [1, 2]}
|
|
# which is valid JSON. But the naive count can't always recover
|
|
# complex nesting — verify we at least get valid JSON.
|
|
json.loads(result)
|
|
|
|
# -- Stage 5: excess closing delimiters --
|
|
|
|
def test_extra_closing_brace(self):
|
|
result = _repair_tool_call_arguments('{"key": "value"}}', "t")
|
|
parsed = json.loads(result)
|
|
assert parsed == {"key": "value"}
|
|
|
|
def test_extra_closing_bracket(self):
|
|
result = _repair_tool_call_arguments('{"a": [1]]}', "t")
|
|
# Should produce valid JSON
|
|
json.loads(result)
|
|
|
|
# -- Stage 6: last resort --
|
|
|
|
def test_unrepairable_garbage_returns_empty_object(self):
|
|
assert _repair_tool_call_arguments("totally not json", "t") == "{}"
|
|
|
|
def test_unrepairable_partial_returns_empty_object(self):
|
|
# Truncated in the middle of a string key — bracket closing won't help
|
|
assert _repair_tool_call_arguments('{"truncated": "val', "t") == "{}"
|
|
|
|
# -- Valid JSON passthrough (this path is via except, but still works) --
|
|
|
|
def test_already_valid_json_passes_through(self):
|
|
"""When json.loads fails for a non-JSON reason (shouldn't normally
|
|
happen), but the repair pipeline still produces valid output."""
|
|
raw = '{"path": "/tmp/foo", "content": "hello"}'
|
|
result = _repair_tool_call_arguments(raw, "t")
|
|
parsed = json.loads(result)
|
|
assert parsed["path"] == "/tmp/foo"
|
|
|
|
# -- Combined repairs --
|
|
|
|
def test_trailing_comma_plus_unclosed_brace(self):
|
|
result = _repair_tool_call_arguments('{"a": 1, "b": 2,', "t")
|
|
# Trailing comma stripped first, then closing brace added.
|
|
# May or may not fully recover — verify valid JSON at minimum.
|
|
json.loads(result)
|
|
|
|
def test_real_world_glm_truncation(self):
|
|
"""Simulates GLM-5.1 truncating mid-argument."""
|
|
raw = '{"command": "ls -la /tmp", "timeout": 30, "background":'
|
|
result = _repair_tool_call_arguments(raw, "terminal")
|
|
# Should at least be valid JSON, even if background is lost
|
|
json.loads(result)
|