mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
115 lines
4.1 KiB
Python
115 lines
4.1 KiB
Python
import queue
|
|
from unittest.mock import patch
|
|
|
|
from cli import HermesCLI
|
|
from hermes_cli.moa_config import decode_moa_turn
|
|
|
|
|
|
def _make_cli():
|
|
cli = HermesCLI.__new__(HermesCLI)
|
|
cli.config = {
|
|
"moa": {
|
|
"default_preset": "default",
|
|
"presets": {
|
|
"default": {
|
|
"reference_models": [{"provider": "openai-codex", "model": "gpt-5.5"}],
|
|
"aggregator": {"provider": "openrouter", "model": "anthropic/claude-opus-4.8"},
|
|
},
|
|
"review": {
|
|
"reference_models": [{"provider": "openrouter", "model": "deepseek/deepseek-v4-pro"}],
|
|
"aggregator": {"provider": "openrouter", "model": "anthropic/claude-opus-4.8"},
|
|
},
|
|
},
|
|
}
|
|
}
|
|
cli._pending_input = queue.Queue()
|
|
cli._pending_agent_seed = None
|
|
cli._pending_moa_config = None
|
|
cli._pending_moa_disable_after_turn = False
|
|
cli._pending_moa_restore_model = None
|
|
cli._agent_running = False
|
|
cli.agent = None
|
|
cli.provider = "openrouter"
|
|
cli.requested_provider = "openrouter"
|
|
cli.model = "anthropic/claude-opus-4.8"
|
|
cli.api_key = "test-key"
|
|
cli.base_url = "https://openrouter.ai/api/v1"
|
|
cli.api_mode = "chat_completions"
|
|
return cli
|
|
|
|
|
|
def test_moa_bare_shows_usage_no_switch():
|
|
# /moa with no prompt is usage-only now; switching to a preset for the
|
|
# session is done via the model picker, not /moa.
|
|
cli = _make_cli()
|
|
cli._pending_moa_disable_after_turn = False
|
|
with patch("cli._cprint"):
|
|
assert cli.process_command("/moa") is True
|
|
assert cli.provider != "moa"
|
|
assert cli._pending_agent_seed is None
|
|
assert cli._pending_moa_disable_after_turn is False
|
|
|
|
|
|
def test_moa_arg_is_always_one_shot_prompt():
|
|
# Any argument (even a string that matches a preset name) is treated as a
|
|
# one-shot prompt through the DEFAULT preset, then the model is restored.
|
|
cli = _make_cli()
|
|
with patch("cli._cprint"):
|
|
cli.process_command("/moa review")
|
|
assert cli._pending_agent_seed == "review"
|
|
assert cli._pending_moa_disable_after_turn is True
|
|
assert cli.provider == "moa"
|
|
assert cli.model == "default"
|
|
|
|
|
|
def test_moa_non_preset_is_one_shot_prompt():
|
|
cli = _make_cli()
|
|
with patch("cli._cprint"):
|
|
cli.process_command("/moa inspect the flaky test")
|
|
assert cli._pending_agent_seed == "inspect the flaky test"
|
|
assert cli._pending_moa_disable_after_turn is True
|
|
assert cli.provider == "moa"
|
|
assert cli.model == "default"
|
|
assert cli._pending_moa_restore_model["provider"] != "moa"
|
|
|
|
|
|
|
|
|
|
class TestNormalizeMoaModel:
|
|
"""#56828: `-Q -m moa:<preset>` must route through the MoA virtual provider.
|
|
|
|
``_normalize_moa_model`` maps the model string to (provider, preset); the
|
|
__init__ wiring then forces ``requested_provider="moa"`` so the existing
|
|
resolve_runtime_provider / agent_init MoA path runs in non-interactive mode.
|
|
"""
|
|
|
|
def test_moa_prefix_maps_to_provider_and_preset(self):
|
|
from cli import _normalize_moa_model
|
|
assert _normalize_moa_model("moa:strategy") == ("moa", "strategy")
|
|
|
|
|
|
|
|
|
|
def test_none_model_unchanged(self):
|
|
from cli import _normalize_moa_model
|
|
assert _normalize_moa_model(None) == (None, None)
|
|
|
|
def test_colon_model_that_is_not_moa_unchanged(self):
|
|
from cli import _normalize_moa_model
|
|
# A provider:model form for a real provider must not be hijacked.
|
|
assert _normalize_moa_model("openrouter:deepseek/deepseek-v4") == (
|
|
None,
|
|
"openrouter:deepseek/deepseek-v4",
|
|
)
|
|
|
|
def test_override_wins_over_explicit_provider(self):
|
|
# __init__ resolves requested_provider as
|
|
# ``_moa_provider_override or provider or ...``, so a moa: prefix must
|
|
# take precedence over an explicit --provider (the #56828 deepseek case
|
|
# where MoA was silently ignored).
|
|
from cli import _normalize_moa_model
|
|
override, model = _normalize_moa_model("moa:strategy")
|
|
requested_provider = override or "deepseek" or "auto"
|
|
assert requested_provider == "moa"
|
|
assert model == "strategy"
|
|
|