mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
79 lines
2.7 KiB
Python
79 lines
2.7 KiB
Python
"""Tests for the launch-time stale-bytecode sweep (checkout fingerprint guard).
|
|
|
|
Bug class: the checkout's ``.py`` files change (``hermes update``, manual
|
|
``git pull``, ZIP update) while ``__pycache__`` retains bytecode compiled
|
|
from the previous revision; the next process to import trusts the stale
|
|
``.pyc`` and dies with ``cannot import name ...`` (#6207, #60242).
|
|
|
|
The launch-time guard compares the current checkout fingerprint against the
|
|
last-validated stamp and sweeps ``__pycache__`` once when they diverge —
|
|
covering paths no update-time clear can reach (manual pulls, pre-hardening
|
|
updaters).
|
|
"""
|
|
|
|
from pathlib import Path
|
|
|
|
from hermes_cli import main as hermes_main
|
|
|
|
|
|
def _make_repo(tmp_path: Path, sha: str = "a" * 40) -> Path:
|
|
"""Minimal git checkout layout that _read_git_revision_fingerprint groks."""
|
|
repo = tmp_path / "repo"
|
|
git_dir = repo / ".git"
|
|
(git_dir / "refs" / "heads").mkdir(parents=True)
|
|
(git_dir / "HEAD").write_text("ref: refs/heads/main\n", encoding="utf-8")
|
|
(git_dir / "refs" / "heads" / "main").write_text(sha + "\n", encoding="utf-8")
|
|
return repo
|
|
|
|
|
|
def _make_pycache(repo: Path, subdir: str = "hermes_cli") -> Path:
|
|
cache = repo / subdir / "__pycache__"
|
|
cache.mkdir(parents=True)
|
|
(cache / "main.cpython-311.pyc").write_bytes(b"stale")
|
|
return cache
|
|
|
|
|
|
def test_sweep_clears_pycache_when_checkout_changed(monkeypatch, tmp_path):
|
|
repo = _make_repo(tmp_path, sha="b" * 40)
|
|
cache = _make_pycache(repo)
|
|
monkeypatch.setattr(hermes_main, "PROJECT_ROOT", repo)
|
|
# Stamp records a different (older) fingerprint.
|
|
(repo / hermes_main._BYTECODE_FINGERPRINT_FILE).write_text(
|
|
"git:refs/heads/main:" + "a" * 40, encoding="utf-8"
|
|
)
|
|
|
|
hermes_main._sweep_stale_bytecode_if_checkout_changed()
|
|
|
|
assert not cache.exists()
|
|
# Stamp updated to the current fingerprint.
|
|
recorded = (repo / hermes_main._BYTECODE_FINGERPRINT_FILE).read_text(encoding="utf-8")
|
|
assert recorded.strip().endswith("b" * 40)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Plugin-update sibling site: __pycache__ under ~/.hermes/plugins/<name>
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def test_clear_plugin_bytecode_removes_nested_caches(tmp_path):
|
|
from hermes_cli import plugins_cmd
|
|
|
|
plugin = tmp_path / "myplugin"
|
|
top = plugin / "__pycache__"
|
|
nested = plugin / "sub" / "__pycache__"
|
|
top.mkdir(parents=True)
|
|
nested.mkdir(parents=True)
|
|
(top / "a.pyc").write_bytes(b"stale")
|
|
(nested / "b.pyc").write_bytes(b"stale")
|
|
|
|
removed = plugins_cmd._clear_plugin_bytecode(plugin)
|
|
|
|
assert removed == 2
|
|
assert not top.exists()
|
|
assert not nested.exists()
|
|
|
|
|