mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
103 lines
3.5 KiB
Python
103 lines
3.5 KiB
Python
"""Tests for MemoryManager.commit_session_boundary_async.
|
|
|
|
The /new session boundary must deliver on_session_end (old-session
|
|
extraction) strictly BEFORE on_session_switch (provider rebinding to the
|
|
new session), without blocking the caller. Both hooks run as one task on
|
|
the manager's single serialized background worker.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import threading
|
|
import time
|
|
from typing import Any, Dict, List
|
|
|
|
from agent.memory_manager import MemoryManager
|
|
from agent.memory_provider import MemoryProvider
|
|
|
|
|
|
class _RecordingProvider(MemoryProvider):
|
|
"""Provider that records hook invocations with thread identity."""
|
|
|
|
def __init__(self, end_delay: float = 0.0):
|
|
self.calls: List[tuple] = []
|
|
self._end_delay = end_delay
|
|
self._caller_thread_ids: List[int] = []
|
|
|
|
# Required ABC surface (minimal no-ops)
|
|
@property
|
|
def name(self) -> str:
|
|
return "recorder"
|
|
|
|
def is_available(self) -> bool:
|
|
return True
|
|
|
|
def get_tool_schemas(self) -> List[Dict[str, Any]]:
|
|
return []
|
|
|
|
def initialize(self, agent: Any = None, **kwargs) -> bool: # type: ignore[override]
|
|
return True
|
|
|
|
def build_system_prompt(self) -> str: # type: ignore[override]
|
|
return ""
|
|
|
|
def sync_turn(self, user_content: str, assistant_content: str, **kwargs) -> None: # type: ignore[override]
|
|
self.calls.append(("sync_turn", kwargs.get("session_id", "")))
|
|
|
|
def on_session_end(self, messages: List[Dict[str, Any]]) -> None:
|
|
if self._end_delay:
|
|
time.sleep(self._end_delay)
|
|
self._caller_thread_ids.append(threading.get_ident())
|
|
self.calls.append(("end", list(messages)))
|
|
|
|
def on_session_switch(self, new_session_id: str, **kwargs) -> None:
|
|
self.calls.append(("switch", new_session_id, kwargs.get("reset")))
|
|
|
|
|
|
def _make_manager(provider: _RecordingProvider) -> MemoryManager:
|
|
mm = MemoryManager()
|
|
mm._providers.append(provider) # bypass add_provider validation for the stub
|
|
return mm
|
|
|
|
|
|
def test_boundary_commit_delivers_end_strictly_before_switch():
|
|
"""Even with a slow (LLM-like) extraction, switch waits for end."""
|
|
provider = _RecordingProvider(end_delay=0.15)
|
|
mm = _make_manager(provider)
|
|
|
|
msgs = [{"role": "user", "content": "old turn"}]
|
|
t0 = time.monotonic()
|
|
mm.commit_session_boundary_async(
|
|
msgs, new_session_id="new-sid", parent_session_id="old-sid"
|
|
)
|
|
# Caller returns immediately — the slow extraction must not block /new.
|
|
assert time.monotonic() - t0 < 0.1
|
|
|
|
assert mm.flush_pending(timeout=5)
|
|
|
|
kinds = [c[0] for c in provider.calls]
|
|
assert kinds == ["end", "switch"], f"ordering violated: {provider.calls}"
|
|
assert provider.calls[0] == ("end", msgs)
|
|
assert provider.calls[1] == ("switch", "new-sid", True)
|
|
# And it genuinely ran off the caller's thread.
|
|
assert provider._caller_thread_ids[0] != threading.get_ident()
|
|
|
|
|
|
|
|
|
|
def test_boundary_commit_switch_still_fires_when_end_raises():
|
|
"""A failing provider extraction must not strand providers on the old sid."""
|
|
|
|
class _ExplodingEndProvider(_RecordingProvider):
|
|
def on_session_end(self, messages): # type: ignore[override]
|
|
raise RuntimeError("provider extraction blew up")
|
|
|
|
provider = _ExplodingEndProvider()
|
|
mm = _make_manager(provider)
|
|
|
|
mm.commit_session_boundary_async([{"role": "user", "content": "x"}], new_session_id="new-sid")
|
|
assert mm.flush_pending(timeout=5)
|
|
|
|
assert ("switch", "new-sid", True) in provider.calls
|
|
|
|
|