mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
50 lines
1.5 KiB
Python
50 lines
1.5 KiB
Python
"""Contract for the headless ``hermes serve`` backend command.
|
|
|
|
``serve`` is what the desktop app and remote backends launch — the same gateway
|
|
as ``dashboard`` (shared handler) but always headless, and decoupled in name so
|
|
the desktop never invokes ``dashboard``. These tests pin that contract:
|
|
|
|
- ``serve`` routes to the same handler as ``dashboard``;
|
|
- ``serve`` is headless by default, ``dashboard`` is not;
|
|
- both expose the identical server-runtime flag surface.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import argparse
|
|
|
|
from hermes_cli.subcommands.dashboard import build_dashboard_parser
|
|
|
|
|
|
def _dash(args): # sentinel handler — identity-compared, never invoked
|
|
return args
|
|
|
|
|
|
def _register(args):
|
|
return args
|
|
|
|
|
|
def _parser() -> argparse.ArgumentParser:
|
|
parser = argparse.ArgumentParser()
|
|
build_dashboard_parser(
|
|
parser.add_subparsers(dest="command"),
|
|
cmd_dashboard=_dash,
|
|
cmd_dashboard_register=_register,
|
|
)
|
|
return parser
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_serve_supports_the_lifecycle_flags():
|
|
for flag in ("--stop", "--status"):
|
|
assert getattr(_parser().parse_args(["serve", flag]), flag.lstrip("-")) is True
|
|
|
|
|
|
def test_serve_is_a_headless_backend_but_dashboard_is_not():
|
|
# `headless_backend` is the flag cmd_dashboard reads to skip the web UI
|
|
# build; only `serve` carries it.
|
|
assert getattr(_parser().parse_args(["serve"]), "headless_backend", False) is True
|
|
assert getattr(_parser().parse_args(["dashboard"]), "headless_backend", False) is False
|