mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-25 00:51:20 +00:00
527ca7d238
15 P1 ship-stopper runtime bugs from the ty triage plus the cross-bucket cleanup in run_agent.py. Net: -138 ty diagnostics (1953 -> 1815). Major wins on not-subscriptable (-34), unresolved-attribute (-29), invalid-argument-type (-26), invalid-type-form (-20), unsupported-operator (-18), invalid-key (-9). Missing refs (structural): - tools/rl_training_tool.py: RunState dataclass gains api_log_file, trainer_log_file, env_log_file fields; stop-run was closing undeclared handles. - agent/credential_pool.py: remove_entry(entry_id) added, symmetric with add_entry; used by hermes_cli/web_server.py OAuth dashboard cleanup. - hermes_cli/config.py: _CamofoxConfig TypedDict defined (was referenced by _BrowserConfig but never declared). - hermes_cli/gateway.py: _setup_wecom_callback() added, mirroring _setup_wecom(). - tui_gateway/server.py: skills_hub imports corrected from hermes_cli.skills_hub -> tools.skills_hub. Typo / deprecation: - tools/transcription_tools.py: os.sys.modules -> sys.modules. - gateway/platforms/bluebubbles.py: datetime.utcnow() -> datetime.now(timezone.utc). None-guards: - gateway/platforms/telegram.py:~2798 - msg.sticker None guard. - gateway/platforms/discord.py:3602/3637 - interaction.data None + SelectMenu narrowing; :3009 - thread_id None before `in`; :1893 - guild.member_count None. - gateway/platforms/matrix.py:2174/2185 - walrus-narrow re.search().group(). - agent/display.py:732 - start_time None before elapsed subtraction. - gateway/run.py:10334 - assert _agent_timeout is not None before `// 60`. Platform override signature match: - gateway/platforms/email.py: send_image accepts metadata kwarg; send_document accepts **kwargs (matches base class). run_agent.py annotation pass: - callable/any -> Callable/Any in annotation position (15 sites in run_agent.py + 5 in cli.py, toolset_distributions.py, tools/delegate_tool.py, hermes_cli/dingtalk_auth.py, tui_gateway/server.py). - conversation_history param widened to list[dict[str, Any]] | None. - OMIT_TEMPERATURE sentinel guarded from leaking into call_llm(temperature): kwargs-dict pattern at run_agent.py:7337 + scripts/trajectory_compressor.py:618/688. - build_anthropic_client(timeout) widened to Optional[float]. Tests: - tests/agent/test_credential_pool.py: remove_entry (id match, unknown-id, priority renumbering). - tests/hermes_cli/test_config_shapes.py: _CamofoxConfig shape + nesting. - tests/tools/test_rl_training_tool.py: RunState log_file fields.
42 lines
1.4 KiB
Python
42 lines
1.4 KiB
Python
"""Tests for TypedDict shape definitions added in commit fc00f699.
|
|
|
|
Verifies that _CamofoxConfig is importable, honours total=False
|
|
(all fields optional), and nests correctly inside _BrowserConfig.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
|
|
def test_camofox_config_is_partial_typeddict():
|
|
"""_CamofoxConfig should accept zero or more keys (total=False)."""
|
|
from hermes_cli.config import _CamofoxConfig, _BrowserConfig
|
|
|
|
# total=False: constructing with no keys must succeed at runtime
|
|
cfg_empty: _CamofoxConfig = {}
|
|
cfg_with_field: _CamofoxConfig = {"managed_persistence": True}
|
|
|
|
assert cfg_empty == {}
|
|
assert cfg_with_field.get("managed_persistence") is True
|
|
|
|
|
|
def test_camofox_config_nested_in_browser_config():
|
|
"""_CamofoxConfig should be accepted in the camofox slot of _BrowserConfig."""
|
|
from hermes_cli.config import _CamofoxConfig, _BrowserConfig
|
|
|
|
browser: _BrowserConfig = {
|
|
"inactivity_timeout": 60,
|
|
"command_timeout": 10,
|
|
"record_sessions": False,
|
|
"allow_private_urls": False,
|
|
"cdp_url": "http://localhost:9222",
|
|
"camofox": {"managed_persistence": False},
|
|
}
|
|
|
|
assert browser["camofox"].get("managed_persistence") is False
|
|
|
|
|
|
def test_camofox_config_total_false_flag():
|
|
"""_CamofoxConfig.__total__ must be False (all fields optional)."""
|
|
from hermes_cli.config import _CamofoxConfig
|
|
|
|
assert _CamofoxConfig.__total__ is False
|