hermes-agent/contributors/emails/hellofrommorgan@users.noreply.github.com at 503da4e3085ebb7106652864cdd68d6eee080eaf - mirrors/hermes-agent - Cosmolan Git

mirrors/hermes-agent

mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-07-25 17:04:52 +00:00

hellofrommorgan d6ffe3d767 fix(windows): hide console flashes from LSP server spawn and installer subprocesses

Salvaged from PR #47971 (LSP subset). On Windows, .cmd-wrapped language
servers (e.g. pyright-langserver.CMD launched via cmd.exe /c) and the
npm/go/pip LSP auto-installers spawn without CREATE_NO_WINDOW, so a
console window flashes whenever the spawn happens under a console-less
parent — e.g. a VS Code/Zed extension host running the ACP adapter.

- agent/lsp/client.py::_spawn: pass creationflags=windows_hide_flags()
  to the language-server asyncio subprocess (inert 0 on POSIX;
  start_new_session is kept — it is POSIX-only and ignored on Windows).
- agent/lsp/install.py: same flags on the npm and go installer
  subprocess.run calls. The pip path goes through
  hermes_cli.tools_config._pip_install, which already hides its windows.

Adapted from the PR's hand-rolled _NO_WINDOW constant to the repo's
hermes_cli._subprocess_compat.windows_hide_flags() convention.

2026-07-23 17:59:52 -07:00

1 line

16 B

Text

Raw Blame History

hellofrommorgan