mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-21 16:18:55 +00:00
Hermes' computer_use wrapper dropped cua-driver's structured action verdicts, exposed no delivery_mode, and injected background-only guidance — so the agent reported unverified no-ops as success and concluded cua-driver 'cannot drive' Electron/Chromium surfaces (observed live on tldraw offline). Fixes #67052. Phase A — preserve the result contract: - ActionResult carries verified/effect/escalation/path/degraded/code/delivery_mode - CuaDriverBackend._action() reads structuredContent (was data-only); a helper normalizes it, additive and None-safe on old drivers - _text_response surfaces the fields additively (ok stays transport-only) Phase B — bounded, model-reachable foreground: - delivery_mode (background|foreground) + bring_to_front on the schema, dispatcher, ABC, and all input methods - foreground is capability-gated (input.delivery_mode); old drivers get a structured foreground_unsupported refusal, never a silent background downgrade - no automatic/hidden foreground retry — the model selects it from the signal Phase C — guidance + isolation: - system prompt (prompt_builder) and bundled skills/computer-use/SKILL.md go from background-ONLY to background-FIRST, teaching the AX→PX→foreground ladder driven by returned effect/escalation, not predicted from the app being Electron - foreground approval scoped by (action, delivery_mode): a background approval never silently authorizes foreground - approval state keyed per session_id so concurrent gateway runs don't leak unlocks Tests: tests/tools/test_computer_use_delivery_ladder.py (15) cover confirmed/ unverifiable/suspected_noop/degraded/old-driver verdicts, delivery_mode gating + foreground_unsupported, and session-scoped foreground approval. Existing 265 computer_use tests still green. Live E2E (real cua-driver 0.8.3 + tldraw offline on Linux/X11): a background click returned effect='unverifiable'/path='ax' (no fabricated success), and a foreground request returned code='foreground_unsupported' — correct on a driver that predates the input.delivery_mode capability.
220 lines
9.2 KiB
Python
220 lines
9.2 KiB
Python
"""Abstract backend interface for computer use.
|
|
|
|
Any implementation (cua-driver over MCP, pyautogui, noop, future Linux/Windows)
|
|
must return the shape described below. All methods synchronous; async is
|
|
handled inside the backend implementation if needed.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from abc import ABC, abstractmethod
|
|
from dataclasses import dataclass, field
|
|
from typing import Any, Dict, List, Optional, Tuple
|
|
|
|
|
|
@dataclass
|
|
class UIElement:
|
|
"""One interactable element on the current screen."""
|
|
|
|
index: int # 1-based SOM index
|
|
role: str # AX role (AXButton, AXTextField, ...)
|
|
label: str = "" # AXTitle / AXDescription / AXValue snippet
|
|
bounds: Tuple[int, int, int, int] = (0, 0, 0, 0) # x, y, w, h (logical px)
|
|
app: str = "" # owning bundle ID or app name
|
|
pid: int = 0 # owning process PID
|
|
window_id: int = 0 # SkyLight / CG window ID
|
|
attributes: Dict[str, Any] = field(default_factory=dict)
|
|
# Opaque per-snapshot element handle from cua-driver
|
|
# (trycua/cua#1961 — Surface 6 of NousResearch/hermes-agent#47072).
|
|
# When set, downstream calls can pass it alongside `index` for
|
|
# explicit stale-detection: a stale token returns an error from
|
|
# cua-driver rather than silently re-resolving to a different
|
|
# element. None for pre-#1961 drivers that didn't carry the field.
|
|
element_token: Optional[str] = None
|
|
|
|
def center(self) -> Tuple[int, int]:
|
|
x, y, w, h = self.bounds
|
|
return x + w // 2, y + h // 2
|
|
|
|
|
|
@dataclass
|
|
class CaptureResult:
|
|
"""Result of a screen capture call.
|
|
|
|
At least one of png_b64 / elements is populated depending on capture mode:
|
|
* mode="vision" → png_b64 only
|
|
* mode="ax" → elements only
|
|
* mode="som" → both (default): PNG already has numbered overlays
|
|
drawn by the backend, and `elements` holds the
|
|
matching index → element mapping.
|
|
"""
|
|
|
|
mode: str
|
|
width: int # screenshot width (logical px, pre-Anthropic-scale)
|
|
height: int
|
|
png_b64: Optional[str] = None
|
|
elements: List[UIElement] = field(default_factory=list)
|
|
# Optional: the target app/window the elements were captured for.
|
|
app: str = ""
|
|
window_title: str = ""
|
|
# Raw bytes we sent to Anthropic, for token estimation.
|
|
png_bytes_len: int = 0
|
|
# Explicit MIME type for `png_b64` when the backend supplied it
|
|
# (cua-driver-rs emits `mimeType` on every image part as of
|
|
# trycua/cua#1961 — Surface 7 of NousResearch/hermes-agent#47072).
|
|
# When None, downstream consumers fall back to base64-prefix
|
|
# sniffing for back-compat with older drivers.
|
|
image_mime_type: Optional[str] = None
|
|
|
|
|
|
@dataclass
|
|
class ActionResult:
|
|
"""Result of any action (click / type / scroll / drag / key / wait).
|
|
|
|
Beyond the transport-level ``ok`` flag, this carries cua-driver's
|
|
structured action verdict so the model can follow the documented
|
|
verify → escalate ladder (NousResearch/hermes-agent#67052). ``ok`` stays
|
|
tool/transport success only — it is NOT the semantic verdict. Read
|
|
``effect`` / ``escalation`` to decide the next rung. All structured
|
|
fields are optional and additive: an older driver that omits
|
|
``structuredContent`` leaves them ``None`` and behavior is unchanged.
|
|
"""
|
|
|
|
ok: bool
|
|
action: str
|
|
message: str = "" # human-readable summary
|
|
# Optional trailing screenshot — set when the caller asked for a
|
|
# post-action capture or the backend always returns one.
|
|
capture: Optional[CaptureResult] = None
|
|
# Arbitrary extra fields for debugging / telemetry.
|
|
meta: Dict[str, Any] = field(default_factory=dict)
|
|
# ── cua-driver structured verdict (additive; None on old drivers) ──
|
|
# AX read-back verification: True = driver read the effect back,
|
|
# False = ran but unconfirmed, None = tool doesn't carry the field.
|
|
verified: Optional[bool] = None
|
|
# Confidence signal: "confirmed" | "unverifiable" | "suspected_noop".
|
|
effect: Optional[str] = None
|
|
# Machine-readable next-rung hint: {"recommended": "px"|"foreground"|"page",
|
|
# "reason": str} — present only when the driver recommends climbing.
|
|
escalation: Optional[Dict[str, Any]] = None
|
|
# Delivery rung that actually ran (e.g. "ax", "x11_pixel", "cgevent_fg").
|
|
path: Optional[str] = None
|
|
# True when an AX walk found no actionable elements (act by px instead).
|
|
degraded: Optional[bool] = None
|
|
# The delivery_mode the caller requested for this action, echoed back.
|
|
delivery_mode: Optional[str] = None
|
|
# A structured refusal code (e.g. "background_unavailable",
|
|
# "foreground_unsupported", "desktop_scope_disabled") when present.
|
|
code: Optional[str] = None
|
|
|
|
|
|
class ComputerUseBackend(ABC):
|
|
"""Lifecycle: `start()` before first use, `stop()` at shutdown."""
|
|
|
|
@abstractmethod
|
|
def start(self) -> None: ...
|
|
|
|
@abstractmethod
|
|
def stop(self) -> None: ...
|
|
|
|
@abstractmethod
|
|
def is_available(self) -> bool:
|
|
"""Return True if the backend can be used on this host right now.
|
|
|
|
Used by check_fn gating and by the post-setup wizard.
|
|
"""
|
|
|
|
# ── Capture ─────────────────────────────────────────────────────
|
|
@abstractmethod
|
|
def capture(
|
|
self,
|
|
mode: str = "som",
|
|
app: Optional[str] = None,
|
|
pid: Optional[int] = None,
|
|
window_id: Optional[int] = None,
|
|
) -> CaptureResult: ...
|
|
|
|
# ── Pointer actions ─────────────────────────────────────────────
|
|
@abstractmethod
|
|
def click(
|
|
self,
|
|
*,
|
|
element: Optional[int] = None,
|
|
x: Optional[int] = None,
|
|
y: Optional[int] = None,
|
|
button: str = "left", # left | right | middle
|
|
click_count: int = 1,
|
|
modifiers: Optional[List[str]] = None,
|
|
delivery_mode: Optional[str] = None, # background (default) | foreground
|
|
bring_to_front: bool = False,
|
|
) -> ActionResult: ...
|
|
|
|
@abstractmethod
|
|
def drag(
|
|
self,
|
|
*,
|
|
from_element: Optional[int] = None,
|
|
to_element: Optional[int] = None,
|
|
from_xy: Optional[Tuple[int, int]] = None,
|
|
to_xy: Optional[Tuple[int, int]] = None,
|
|
button: str = "left",
|
|
modifiers: Optional[List[str]] = None,
|
|
delivery_mode: Optional[str] = None,
|
|
bring_to_front: bool = False,
|
|
) -> ActionResult: ...
|
|
|
|
@abstractmethod
|
|
def scroll(
|
|
self,
|
|
*,
|
|
direction: str, # up | down | left | right
|
|
amount: int = 3, # wheel ticks
|
|
element: Optional[int] = None,
|
|
x: Optional[int] = None,
|
|
y: Optional[int] = None,
|
|
modifiers: Optional[List[str]] = None,
|
|
delivery_mode: Optional[str] = None,
|
|
bring_to_front: bool = False,
|
|
) -> ActionResult: ...
|
|
|
|
# ── Keyboard ────────────────────────────────────────────────────
|
|
@abstractmethod
|
|
def type_text(self, text: str, *, delivery_mode: Optional[str] = None,
|
|
bring_to_front: bool = False) -> ActionResult: ...
|
|
|
|
@abstractmethod
|
|
def key(self, keys: str, *, delivery_mode: Optional[str] = None,
|
|
bring_to_front: bool = False) -> ActionResult:
|
|
"""Send a key combo, e.g. 'cmd+s', 'ctrl+alt+t', 'return'."""
|
|
|
|
# ── Introspection ───────────────────────────────────────────────
|
|
@abstractmethod
|
|
def list_apps(self) -> List[Dict[str, Any]]:
|
|
"""Return running apps with bundle IDs, PIDs, window counts."""
|
|
|
|
def list_windows(self) -> List[Dict[str, Any]]:
|
|
"""Return visible native windows with PID and window identifiers.
|
|
|
|
Optional compatibility hook: backends that predate window discovery
|
|
remain instantiable and simply report no windows.
|
|
"""
|
|
return []
|
|
|
|
@abstractmethod
|
|
def focus_app(self, app: str, raise_window: bool = False) -> ActionResult:
|
|
"""Route input to `app` (by name or bundle ID). Default: focus without raise."""
|
|
|
|
# ── Native-value mutation ────────────────────────────────────────
|
|
@abstractmethod
|
|
def set_value(self, value: str, element: Optional[int] = None) -> ActionResult:
|
|
"""Set a native value on an element (e.g. AXPopUpButton selection).
|
|
|
|
`element` is the 1-based SOM index returned by a prior capture call.
|
|
"""
|
|
|
|
# ── Timing ──────────────────────────────────────────────────────
|
|
def wait(self, seconds: float) -> ActionResult:
|
|
"""Default implementation: time.sleep."""
|
|
import time
|
|
time.sleep(max(0.0, min(seconds, 30.0)))
|
|
return ActionResult(ok=True, action="wait", message=f"waited {seconds:.2f}s")
|