mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
52 lines
1.8 KiB
Python
52 lines
1.8 KiB
Python
"""Tests for the interim_assistant_callback config gating in tui_gateway.
|
|
|
|
These tests exercise the real _agent_cbs() wiring rather than a local
|
|
imitation, so a break in the production callback registration is caught.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import patch
|
|
|
|
|
|
def test_load_interim_assistant_messages_defaults_true():
|
|
from tui_gateway.server import _load_interim_assistant_messages
|
|
|
|
with patch("tui_gateway.server._load_cfg", return_value={}):
|
|
assert _load_interim_assistant_messages() is True
|
|
|
|
|
|
def test_agent_cbs_includes_interim_callback_when_enabled():
|
|
"""_agent_cbs() includes interim_assistant_callback when the config is on.
|
|
|
|
Exercises the real _agent_cbs() wiring: the callback must be present in
|
|
the returned dict and, when invoked, must emit a message.interim event
|
|
with the text and already_streamed flag passed through.
|
|
"""
|
|
from tui_gateway.server import _agent_cbs
|
|
|
|
emitted: list[tuple] = []
|
|
|
|
def fake_emit(event_type, sid, payload=None):
|
|
emitted.append((event_type, sid, payload))
|
|
|
|
with patch("tui_gateway.server._load_cfg", return_value={}), \
|
|
patch("tui_gateway.server._emit", side_effect=fake_emit):
|
|
cbs = _agent_cbs("test-session")
|
|
|
|
assert "interim_assistant_callback" in cbs
|
|
cb = cbs["interim_assistant_callback"]
|
|
assert callable(cb)
|
|
|
|
# Invoke the real callback inside the patch context — the lambda
|
|
# resolves _emit by name at call time, so it must be called while
|
|
# the patch is active.
|
|
cb("hello world", already_streamed=True)
|
|
|
|
assert len(emitted) == 1
|
|
assert emitted[0][0] == "message.interim"
|
|
assert emitted[0][1] == "test-session"
|
|
assert emitted[0][2]["text"] == "hello world"
|
|
assert emitted[0][2]["already_streamed"] is True
|
|
|
|
|