mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
59 lines
1.6 KiB
Python
59 lines
1.6 KiB
Python
"""Tests for xAI Imagine storage helper behavior."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import yaml
|
|
|
|
|
|
def _invalidate_config_cache():
|
|
try:
|
|
import hermes_cli.config as cfg_mod
|
|
|
|
if hasattr(cfg_mod, "_invalidate_load_config_cache"):
|
|
cfg_mod._invalidate_load_config_cache()
|
|
except Exception:
|
|
pass
|
|
|
|
|
|
def test_storage_defaults_to_permanent_public_urls(tmp_path, monkeypatch):
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
_invalidate_config_cache()
|
|
|
|
from tools.xai_http import build_xai_storage_options
|
|
|
|
storage = build_xai_storage_options(
|
|
"image_gen",
|
|
filename_prefix="hermes-xai-image",
|
|
extension="png",
|
|
)
|
|
|
|
assert storage is not None
|
|
assert storage["public_url"] is True
|
|
assert "expires_after" not in storage
|
|
assert storage["filename"].startswith("hermes-xai-image-")
|
|
assert storage["filename"].endswith(".png")
|
|
|
|
|
|
def test_invalid_storage_retention_falls_back_to_bounded_ttl(tmp_path, monkeypatch):
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
(tmp_path / "config.yaml").write_text(yaml.safe_dump({
|
|
"video_gen": {
|
|
"xai": {
|
|
"storage": {
|
|
"expires_after": "definitely-not-a-duration",
|
|
},
|
|
},
|
|
},
|
|
}))
|
|
_invalidate_config_cache()
|
|
|
|
from tools.xai_http import build_xai_storage_options
|
|
|
|
storage = build_xai_storage_options(
|
|
"video_gen",
|
|
filename_prefix="hermes-xai-video",
|
|
extension="mp4",
|
|
)
|
|
|
|
assert storage is not None
|
|
assert storage["expires_after"] == 172800
|