mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
278 lines
12 KiB
Python
278 lines
12 KiB
Python
"""Tests for TTS speed configuration across providers."""
|
|
|
|
import asyncio
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def clean_env(monkeypatch):
|
|
for key in (
|
|
"OPENAI_API_KEY",
|
|
"MINIMAX_API_KEY",
|
|
"MINIMAX_GROUP_ID",
|
|
"HERMES_SESSION_PLATFORM",
|
|
):
|
|
monkeypatch.delenv(key, raising=False)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Edge TTS speed
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestEdgeTtsSpeed:
|
|
def _run(self, tts_config, tmp_path):
|
|
mock_comm = MagicMock()
|
|
mock_comm.save = AsyncMock()
|
|
mock_edge = MagicMock()
|
|
mock_edge.Communicate = MagicMock(return_value=mock_comm)
|
|
|
|
with patch("tools.tts_tool._import_edge_tts", return_value=mock_edge):
|
|
from tools.tts_tool import _generate_edge_tts
|
|
asyncio.run(_generate_edge_tts("Hello", str(tmp_path / "out.mp3"), tts_config))
|
|
return mock_edge.Communicate
|
|
|
|
def test_default_no_rate_kwarg(self, tmp_path):
|
|
"""No speed config => no rate kwarg passed to Communicate."""
|
|
comm_cls = self._run({}, tmp_path)
|
|
kwargs = comm_cls.call_args[1]
|
|
assert "rate" not in kwargs
|
|
|
|
|
|
def test_speed_exactly_one_no_rate(self, tmp_path):
|
|
"""Explicit speed=1.0 should not pass rate kwarg."""
|
|
comm_cls = self._run({"speed": 1.0}, tmp_path)
|
|
kwargs = comm_cls.call_args[1]
|
|
assert "rate" not in kwargs
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# OpenAI TTS speed
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestOpenaiTtsSpeed:
|
|
def _run(self, tts_config, tmp_path, monkeypatch):
|
|
monkeypatch.setenv("OPENAI_API_KEY", "test-key")
|
|
mock_response = MagicMock()
|
|
mock_client = MagicMock()
|
|
mock_client.audio.speech.create.return_value = mock_response
|
|
mock_cls = MagicMock(return_value=mock_client)
|
|
|
|
with patch("tools.tts_tool._import_openai_client", return_value=mock_cls), \
|
|
patch("tools.tts_tool._resolve_openai_audio_client_config",
|
|
return_value=("test-key", None, False)):
|
|
from tools.tts_tool import _generate_openai_tts
|
|
_generate_openai_tts("Hello", str(tmp_path / "out.mp3"), tts_config)
|
|
return mock_client.audio.speech.create
|
|
|
|
def test_default_no_speed_kwarg(self, tmp_path, monkeypatch):
|
|
"""No speed config => no speed kwarg in create call."""
|
|
create = self._run({}, tmp_path, monkeypatch)
|
|
kwargs = create.call_args[1]
|
|
assert "speed" not in kwargs
|
|
|
|
|
|
def test_speed_clamped_high(self, tmp_path, monkeypatch):
|
|
"""Speed above 4.0 is clamped to 4.0."""
|
|
create = self._run({"speed": 10.0}, tmp_path, monkeypatch)
|
|
kwargs = create.call_args[1]
|
|
assert kwargs["speed"] == 4.0
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# OpenAI TTS language (lang_code for OpenAI-compatible endpoints)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestOpenaiTtsLangCode:
|
|
def _run(self, tts_config, tmp_path, monkeypatch):
|
|
monkeypatch.setenv("OPENAI_API_KEY", "test-key")
|
|
mock_response = MagicMock()
|
|
mock_client = MagicMock()
|
|
mock_client.audio.speech.create.return_value = mock_response
|
|
mock_cls = MagicMock(return_value=mock_client)
|
|
|
|
with patch("tools.tts_tool._import_openai_client", return_value=mock_cls), \
|
|
patch("tools.tts_tool._resolve_openai_audio_client_config",
|
|
return_value=("test-key", None, False)):
|
|
from tools.tts_tool import _generate_openai_tts
|
|
_generate_openai_tts("Hola", str(tmp_path / "out.mp3"), tts_config)
|
|
return mock_client.audio.speech.create
|
|
|
|
def test_default_no_extra_body(self, tmp_path, monkeypatch):
|
|
"""No language config => no extra_body kwarg in create call."""
|
|
create = self._run({}, tmp_path, monkeypatch)
|
|
kwargs = create.call_args[1]
|
|
assert "extra_body" not in kwargs
|
|
|
|
|
|
def test_language_coexists_with_speed(self, tmp_path, monkeypatch):
|
|
"""language and speed are forwarded independently."""
|
|
create = self._run({"openai": {"language": "es", "speed": 2.0}},
|
|
tmp_path, monkeypatch)
|
|
kwargs = create.call_args[1]
|
|
assert kwargs["extra_body"] == {"lang_code": "es"}
|
|
assert kwargs["speed"] == 2.0
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# MiniMax TTS (t2a_v2 endpoint: nested voice_setting/audio_setting,
|
|
# JSON response with hex-encoded audio. Falls back to the legacy
|
|
# text_to_speech endpoint shape when the base_url points at it.)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _hex_response(payload_audio: bytes = b"\x00\x01\x02\x03"):
|
|
"""Build a mock response shaped like a successful t2a_v2 reply."""
|
|
mock_response = MagicMock()
|
|
mock_response.status_code = 200
|
|
mock_response.headers = {"Content-Type": "application/json"}
|
|
mock_response.json.return_value = {
|
|
"data": {"audio": payload_audio.hex(), "status": 2},
|
|
"base_resp": {"status_code": 0, "status_msg": "success"},
|
|
}
|
|
return mock_response
|
|
|
|
|
|
class TestMinimaxTtsT2aV2:
|
|
"""Default path: base_url contains 't2a_v2'."""
|
|
|
|
def _run(self, tts_config, tmp_path, monkeypatch, response=None):
|
|
monkeypatch.setenv("MINIMAX_API_KEY", "test-key")
|
|
resp = response if response is not None else _hex_response()
|
|
with patch("requests.post", return_value=resp) as mock_post:
|
|
from tools.tts_tool import _generate_minimax_tts
|
|
output = _generate_minimax_tts("Hello", str(tmp_path / "out.mp3"), tts_config)
|
|
return mock_post, output
|
|
|
|
def test_nested_payload(self, tmp_path, monkeypatch):
|
|
"""Default endpoint uses nested voice_setting / audio_setting."""
|
|
mock_post, _ = self._run({}, tmp_path, monkeypatch)
|
|
payload = mock_post.call_args[1]["json"]
|
|
assert payload["model"] == "speech-02-hd"
|
|
assert payload["text"] == "Hello"
|
|
assert "voice_setting" in payload
|
|
assert payload["voice_setting"]["voice_id"] == "English_expressive_narrator"
|
|
assert "audio_setting" in payload
|
|
assert payload["audio_setting"]["format"] == "mp3"
|
|
# Don't send flat top-level voice_id alongside nested voice_setting.
|
|
assert "voice_id" not in payload
|
|
|
|
def test_decodes_hex_audio(self, tmp_path, monkeypatch):
|
|
"""t2a_v2 hex-encoded audio is decoded and written verbatim."""
|
|
_, output = self._run({}, tmp_path, monkeypatch)
|
|
with open(output, "rb") as f:
|
|
assert f.read() == b"\x00\x01\x02\x03"
|
|
|
|
|
|
def test_api_error_raises(self, tmp_path, monkeypatch):
|
|
"""Non-zero base_resp.status_code surfaces as RuntimeError."""
|
|
resp = MagicMock()
|
|
resp.status_code = 200
|
|
resp.headers = {"Content-Type": "application/json"}
|
|
resp.json.return_value = {
|
|
"data": {"audio": "", "status": 1},
|
|
"base_resp": {"status_code": 2013, "status_msg": "invalid voice"},
|
|
}
|
|
with pytest.raises(RuntimeError, match="2013"):
|
|
self._run({}, tmp_path, monkeypatch, response=resp)
|
|
|
|
|
|
class TestMinimaxTtsLegacyTextToSpeech:
|
|
"""Legacy path: caller pins base_url to the old text_to_speech endpoint."""
|
|
|
|
LEGACY_URL = "https://api.minimax.chat/v1/text_to_speech"
|
|
|
|
def _run(self, tts_config, tmp_path, monkeypatch):
|
|
monkeypatch.setenv("MINIMAX_API_KEY", "test-key")
|
|
cfg = dict(tts_config)
|
|
cfg.setdefault("minimax", {})["base_url"] = self.LEGACY_URL
|
|
mock_response = MagicMock()
|
|
mock_response.status_code = 200
|
|
mock_response.headers = {"Content-Type": "audio/mpeg"}
|
|
mock_response.content = b"\x00\x01\x02\x03"
|
|
with patch("requests.post", return_value=mock_response) as mock_post:
|
|
from tools.tts_tool import _generate_minimax_tts
|
|
output = _generate_minimax_tts("Hello", str(tmp_path / "out.mp3"), cfg)
|
|
return mock_post, output
|
|
|
|
def test_flat_payload(self, tmp_path, monkeypatch):
|
|
"""Legacy endpoint keeps the flat {model, text, voice_id} shape."""
|
|
mock_post, _ = self._run({}, tmp_path, monkeypatch)
|
|
payload = mock_post.call_args[1]["json"]
|
|
assert "voice_id" in payload
|
|
assert "voice_setting" not in payload
|
|
assert "audio_setting" not in payload
|
|
|
|
def test_writes_raw_audio(self, tmp_path, monkeypatch):
|
|
"""Legacy endpoint returns raw bytes written directly to file."""
|
|
_, output = self._run({}, tmp_path, monkeypatch)
|
|
with open(output, "rb") as f:
|
|
assert f.read() == b"\x00\x01\x02\x03"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Tool-level speed parameter (text_to_speech_tool speed injection)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestToolLevelSpeed:
|
|
"""Verify that the speed parameter on text_to_speech_tool injects into config."""
|
|
|
|
def test_speed_injected_into_config(self, tmp_path, monkeypatch):
|
|
"""When speed is passed to the tool, it overrides config speed."""
|
|
monkeypatch.setenv("OPENAI_API_KEY", "test-key")
|
|
mock_response = MagicMock()
|
|
mock_client = MagicMock()
|
|
mock_client.audio.speech.create.return_value = mock_response
|
|
mock_cls = MagicMock(return_value=mock_client)
|
|
|
|
with patch("tools.tts_tool._import_openai_client", return_value=mock_cls), \
|
|
patch("tools.tts_tool._resolve_openai_audio_client_config",
|
|
return_value=("test-key", None, False)), \
|
|
patch("tools.tts_tool._load_tts_config", return_value={"provider": "openai", "openai": {}}), \
|
|
patch("tools.tts_tool._get_provider", return_value="openai"), \
|
|
patch("tools.tts_tool._resolve_command_provider_config", return_value=None), \
|
|
patch("tools.tts_tool._resolve_max_text_length", return_value=4096), \
|
|
patch("tools.tts_tool._generate_openai_tts") as mock_gen, \
|
|
patch("gateway.session_context.get_session_env", return_value=""):
|
|
from tools.tts_tool import text_to_speech_tool
|
|
text_to_speech_tool("Hello", str(tmp_path / "out.mp3"), speed=0.7)
|
|
|
|
# Verify the tts_config passed to the generator has speed=0.7
|
|
call_args = mock_gen.call_args
|
|
config_passed = call_args[0][2] # (text, output_path, tts_config)
|
|
assert config_passed["speed"] == 0.7
|
|
|
|
def test_speed_clamped_range(self, tmp_path, monkeypatch):
|
|
"""Speed values outside 0.25-4.0 are clamped."""
|
|
monkeypatch.setenv("OPENAI_API_KEY", "test-key")
|
|
|
|
with patch("tools.tts_tool._load_tts_config", return_value={"provider": "openai", "openai": {}}), \
|
|
patch("tools.tts_tool._get_provider", return_value="openai"), \
|
|
patch("tools.tts_tool._resolve_command_provider_config", return_value=None), \
|
|
patch("tools.tts_tool._resolve_max_text_length", return_value=4096), \
|
|
patch("tools.tts_tool._generate_openai_tts") as mock_gen, \
|
|
patch("gateway.session_context.get_session_env", return_value=""):
|
|
from tools.tts_tool import text_to_speech_tool
|
|
text_to_speech_tool("Hello", str(tmp_path / "out.mp3"), speed=10.0)
|
|
|
|
config_passed = mock_gen.call_args[0][2]
|
|
assert config_passed["speed"] == 4.0
|
|
|
|
def test_no_speed_preserves_config(self, tmp_path, monkeypatch):
|
|
"""When speed is None, config is not mutated."""
|
|
monkeypatch.setenv("OPENAI_API_KEY", "test-key")
|
|
original_config = {"provider": "openai", "openai": {}, "speed": 1.5}
|
|
|
|
with patch("tools.tts_tool._load_tts_config", return_value=original_config), \
|
|
patch("tools.tts_tool._get_provider", return_value="openai"), \
|
|
patch("tools.tts_tool._resolve_command_provider_config", return_value=None), \
|
|
patch("tools.tts_tool._resolve_max_text_length", return_value=4096), \
|
|
patch("tools.tts_tool._generate_openai_tts") as mock_gen, \
|
|
patch("gateway.session_context.get_session_env", return_value=""):
|
|
from tools.tts_tool import text_to_speech_tool
|
|
text_to_speech_tool("Hello", str(tmp_path / "out.mp3"), speed=None)
|
|
|
|
config_passed = mock_gen.call_args[0][2]
|
|
assert config_passed.get("speed") == 1.5 # original config preserved
|
|
assert original_config.get("speed") == 1.5 # original not mutated
|