mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
246 lines
10 KiB
Python
246 lines
10 KiB
Python
"""
|
|
Tests for the native Piper TTS provider.
|
|
|
|
These tests pin the resolution / caching / dispatch paths for Piper
|
|
without requiring the ``piper-tts`` package to actually be installed
|
|
(the synthesis step is monkey-patched to avoid needing the ONNX wheel).
|
|
"""
|
|
|
|
import json
|
|
import sys
|
|
import types
|
|
from pathlib import Path
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from tools import tts_tool
|
|
from tools.tts_tool import (
|
|
BUILTIN_TTS_PROVIDERS,
|
|
DEFAULT_PIPER_VOICE,
|
|
PROVIDER_MAX_TEXT_LENGTH,
|
|
_check_piper_available,
|
|
_resolve_piper_voice_path,
|
|
check_tts_requirements,
|
|
text_to_speech_tool,
|
|
)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Registry / constants
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestPiperRegistration:
|
|
def test_piper_is_a_builtin_provider(self):
|
|
assert "piper" in BUILTIN_TTS_PROVIDERS
|
|
|
|
def test_piper_has_a_text_length_cap(self):
|
|
assert PROVIDER_MAX_TEXT_LENGTH.get("piper", 0) > 0
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _check_piper_available
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestCheckPiperAvailable:
|
|
def test_returns_bool_without_raising(self):
|
|
# We don't care about the current environment's answer — just that
|
|
# the probe never raises on a machine without piper installed.
|
|
assert isinstance(_check_piper_available(), bool)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _resolve_piper_voice_path
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestResolvePiperVoicePath:
|
|
def test_direct_onnx_path_returned_as_is(self, tmp_path):
|
|
model = tmp_path / "custom.onnx"
|
|
model.write_bytes(b"fake onnx bytes")
|
|
result = _resolve_piper_voice_path(str(model), tmp_path)
|
|
assert result == str(model)
|
|
|
|
|
|
def test_empty_voice_falls_back_to_default_name(self, tmp_path):
|
|
(tmp_path / f"{DEFAULT_PIPER_VOICE}.onnx").write_bytes(b"model")
|
|
(tmp_path / f"{DEFAULT_PIPER_VOICE}.onnx.json").write_text("{}")
|
|
result = _resolve_piper_voice_path("", tmp_path)
|
|
assert result.endswith(f"{DEFAULT_PIPER_VOICE}.onnx")
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _generate_piper_tts — stubbed so we don't need piper-tts installed
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class _StubPiperVoice:
|
|
"""Stand-in for piper.PiperVoice used by the synthesis tests."""
|
|
|
|
loaded: list[str] = []
|
|
calls: list[tuple] = []
|
|
|
|
@classmethod
|
|
def load(cls, model_path, use_cuda=False):
|
|
cls.loaded.append(model_path)
|
|
instance = cls()
|
|
instance.model_path = model_path
|
|
instance.use_cuda = use_cuda
|
|
return instance
|
|
|
|
def synthesize_wav(self, text, wav_file, syn_config=None):
|
|
# Minimal valid WAV: an empty frame set is fine for our size check.
|
|
# The wave module accepts any frames; we just need the file to exist
|
|
# with non-zero bytes after close.
|
|
wav_file.setnchannels(1)
|
|
wav_file.setsampwidth(2)
|
|
wav_file.setframerate(22050)
|
|
wav_file.writeframes(b"\x00\x00" * 1024)
|
|
_StubPiperVoice.calls.append((text, getattr(self, "model_path", ""), syn_config))
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_piper_cache():
|
|
"""Clear the module-level voice cache between tests."""
|
|
tts_tool._piper_voice_cache.clear()
|
|
_StubPiperVoice.loaded = []
|
|
_StubPiperVoice.calls = []
|
|
yield
|
|
tts_tool._piper_voice_cache.clear()
|
|
|
|
|
|
class TestGeneratePiperTts:
|
|
def _prepare_voice_files(self, tmp_path, voice=DEFAULT_PIPER_VOICE):
|
|
model = tmp_path / f"{voice}.onnx"
|
|
model.write_bytes(b"model")
|
|
(tmp_path / f"{voice}.onnx.json").write_text("{}")
|
|
return model
|
|
|
|
def test_loads_voice_and_writes_wav(self, tmp_path, monkeypatch):
|
|
model = self._prepare_voice_files(tmp_path)
|
|
monkeypatch.setattr(tts_tool, "_import_piper", lambda: _StubPiperVoice)
|
|
|
|
out_path = str(tmp_path / "out.wav")
|
|
config = {"piper": {"voice": str(model)}}
|
|
|
|
result = tts_tool._generate_piper_tts("hello", out_path, config)
|
|
|
|
assert result == out_path
|
|
assert Path(out_path).exists()
|
|
assert Path(out_path).stat().st_size > 0
|
|
assert _StubPiperVoice.loaded == [str(model)]
|
|
assert _StubPiperVoice.calls[0][0] == "hello"
|
|
|
|
def test_voice_cache_reused_across_calls(self, tmp_path, monkeypatch):
|
|
model = self._prepare_voice_files(tmp_path)
|
|
monkeypatch.setattr(tts_tool, "_import_piper", lambda: _StubPiperVoice)
|
|
|
|
config = {"piper": {"voice": str(model)}}
|
|
tts_tool._generate_piper_tts("one", str(tmp_path / "a.wav"), config)
|
|
tts_tool._generate_piper_tts("two", str(tmp_path / "b.wav"), config)
|
|
|
|
# load() should have been called exactly once for the same model+cuda key.
|
|
assert _StubPiperVoice.loaded == [str(model)]
|
|
# But both synthesize calls went through.
|
|
assert [c[0] for c in _StubPiperVoice.calls] == ["one", "two"]
|
|
|
|
|
|
def test_speaker_id_alone_triggers_synconfig(self, tmp_path, monkeypatch):
|
|
"""Setting ONLY speaker_id (no other advanced knobs) still constructs SynthesisConfig.
|
|
|
|
Regression guard: has_advanced must include speaker_id, otherwise
|
|
this knob gets silently dropped on the simplest configuration.
|
|
"""
|
|
model = self._prepare_voice_files(tmp_path)
|
|
monkeypatch.setattr(tts_tool, "_import_piper", lambda: _StubPiperVoice)
|
|
|
|
fake_syn_cls = MagicMock()
|
|
monkeypatch.setitem(sys.modules, "piper", types.SimpleNamespace(SynthesisConfig=fake_syn_cls))
|
|
|
|
config = {"piper": {"voice": str(model), "speaker_id": 1}}
|
|
tts_tool._generate_piper_tts("hi", str(tmp_path / "out.wav"), config)
|
|
|
|
fake_syn_cls.assert_called_once()
|
|
|
|
|
|
def test_speaker_id_does_not_invalidate_voice_cache(self, tmp_path, monkeypatch):
|
|
"""Switching speaker_id between calls must NOT trigger a model reload.
|
|
|
|
PiperVoice is bound to a model, not a speaker — speaker is applied
|
|
per-call via syn_config.speaker_id. The voice cache should serve the
|
|
same PiperVoice instance for the same (model, cuda) regardless of
|
|
how many distinct speaker_ids the user cycles through.
|
|
"""
|
|
model = self._prepare_voice_files(tmp_path)
|
|
monkeypatch.setattr(tts_tool, "_import_piper", lambda: _StubPiperVoice)
|
|
|
|
for speaker in (0, 1, 2, 3):
|
|
config = {"piper": {"voice": str(model), "speaker_id": speaker}}
|
|
tts_tool._generate_piper_tts("hi", str(tmp_path / f"out-{speaker}.wav"), config)
|
|
|
|
# Only one PiperVoice.load() call across four calls with different speakers.
|
|
assert _StubPiperVoice.loaded == [str(model)]
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# text_to_speech_tool end-to-end (provider == "piper")
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestTextToSpeechToolWithPiper:
|
|
def test_dispatches_to_piper(self, tmp_path, monkeypatch):
|
|
model = tmp_path / f"{DEFAULT_PIPER_VOICE}.onnx"
|
|
model.write_bytes(b"model")
|
|
(tmp_path / f"{DEFAULT_PIPER_VOICE}.onnx.json").write_text("{}")
|
|
|
|
monkeypatch.setattr(tts_tool, "_import_piper", lambda: _StubPiperVoice)
|
|
|
|
cfg = {"provider": "piper", "piper": {"voice": str(model)}}
|
|
monkeypatch.setattr(tts_tool, "_load_tts_config", lambda: cfg)
|
|
|
|
result = text_to_speech_tool(text="hi", output_path=str(tmp_path / "clip.wav"))
|
|
data = json.loads(result)
|
|
|
|
assert data["success"] is True, data
|
|
assert data["provider"] == "piper"
|
|
assert Path(data["file_path"]).exists()
|
|
|
|
def test_missing_package_surfaces_error(self, tmp_path, monkeypatch):
|
|
def raise_import():
|
|
raise ImportError("No module named 'piper'")
|
|
|
|
monkeypatch.setattr(tts_tool, "_import_piper", raise_import)
|
|
|
|
cfg = {"provider": "piper"}
|
|
monkeypatch.setattr(tts_tool, "_load_tts_config", lambda: cfg)
|
|
|
|
result = text_to_speech_tool(text="hi", output_path=str(tmp_path / "clip.wav"))
|
|
data = json.loads(result)
|
|
|
|
assert data["success"] is False
|
|
assert "piper-tts" in data["error"]
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# check_tts_requirements
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestCheckTtsRequirementsPiper:
|
|
def test_piper_install_satisfies_requirements(self, monkeypatch):
|
|
# Drop every other provider so we can isolate the piper signal.
|
|
monkeypatch.setattr(tts_tool, "_load_tts_config", lambda: {"provider": "piper"})
|
|
monkeypatch.setattr(tts_tool, "_import_edge_tts", lambda: (_ for _ in ()).throw(ImportError()))
|
|
monkeypatch.setattr(tts_tool, "_import_elevenlabs", lambda: (_ for _ in ()).throw(ImportError()))
|
|
monkeypatch.setattr(tts_tool, "_import_openai_client", lambda: (_ for _ in ()).throw(ImportError()))
|
|
monkeypatch.setattr(tts_tool, "_import_mistral_client", lambda: (_ for _ in ()).throw(ImportError()))
|
|
monkeypatch.setattr(tts_tool, "_check_neutts_available", lambda: False)
|
|
monkeypatch.setattr(tts_tool, "_check_kittentts_available", lambda: False)
|
|
monkeypatch.setattr(tts_tool, "_has_any_command_tts_provider", lambda: False)
|
|
monkeypatch.setattr(tts_tool, "_has_openai_audio_backend", lambda: False)
|
|
for env in ("MINIMAX_API_KEY", "XAI_API_KEY", "GEMINI_API_KEY",
|
|
"GOOGLE_API_KEY", "MISTRAL_API_KEY", "ELEVENLABS_API_KEY"):
|
|
monkeypatch.delenv(env, raising=False)
|
|
|
|
# Now toggle the piper check on and off.
|
|
monkeypatch.setattr(tts_tool, "_check_piper_available", lambda: False)
|
|
assert check_tts_requirements() is False
|
|
|
|
monkeypatch.setattr(tts_tool, "_check_piper_available", lambda: True)
|
|
assert check_tts_requirements() is True
|