mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
83 lines
3.6 KiB
Python
83 lines
3.6 KiB
Python
"""tts.openai.api_key / base_url from config.yaml drive the OpenAI audio client.
|
|
|
|
Regression coverage for issue #26175: the resolver was env-only
|
|
(VOICE_TOOLS_OPENAI_KEY / OPENAI_API_KEY) and always returned the default
|
|
OpenAI base URL, ignoring the tts.openai config block. Resolution order now
|
|
mirrors the STT resolver: config -> env (still honoring config base_url) ->
|
|
managed gateway.
|
|
"""
|
|
from types import SimpleNamespace
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from tools import tts_tool
|
|
|
|
|
|
class TestResolveOpenaiAudioClientConfig:
|
|
def test_prefers_tts_config_credentials_and_base_url(self):
|
|
config = {
|
|
"provider": "openai",
|
|
"openai": {
|
|
"api_key": "cfg-key",
|
|
"base_url": "http://localhost:4003/v1",
|
|
},
|
|
}
|
|
|
|
with patch.object(tts_tool, "_load_tts_config", return_value=config), \
|
|
patch.object(tts_tool, "prefers_gateway", return_value=False), \
|
|
patch.object(tts_tool, "resolve_openai_audio_api_key", return_value="env-key"), \
|
|
patch.object(tts_tool, "resolve_managed_tool_gateway", return_value=None):
|
|
assert tts_tool._resolve_openai_audio_client_config() == (
|
|
"cfg-key",
|
|
"http://localhost:4003/v1",
|
|
False,
|
|
)
|
|
|
|
def test_config_without_base_url_falls_back_to_default_openai_base(self):
|
|
config = {"openai": {"api_key": "cfg-key"}}
|
|
|
|
with patch.object(tts_tool, "_load_tts_config", return_value=config), \
|
|
patch.object(tts_tool, "prefers_gateway", return_value=False):
|
|
assert tts_tool._resolve_openai_audio_client_config() == (
|
|
"cfg-key",
|
|
tts_tool.DEFAULT_OPENAI_BASE_URL,
|
|
False,
|
|
)
|
|
|
|
|
|
def test_use_gateway_overrides_config_credentials(self):
|
|
config = {"openai": {"api_key": "cfg-key", "base_url": "http://localhost:4003/v1"}}
|
|
managed = SimpleNamespace(
|
|
nous_user_token="managed-token",
|
|
gateway_origin="https://openai-audio-gateway.nousresearch.com",
|
|
)
|
|
|
|
with patch.object(tts_tool, "_load_tts_config", return_value=config), \
|
|
patch.object(tts_tool, "prefers_gateway", return_value=True), \
|
|
patch.object(tts_tool, "resolve_openai_audio_api_key", return_value="env-key"), \
|
|
patch.object(tts_tool, "resolve_managed_tool_gateway", return_value=managed):
|
|
assert tts_tool._resolve_openai_audio_client_config() == (
|
|
"managed-token",
|
|
"https://openai-audio-gateway.nousresearch.com/v1",
|
|
True,
|
|
)
|
|
|
|
def test_missing_config_and_env_raises_updated_error(self):
|
|
with patch.object(tts_tool, "_load_tts_config", return_value={}), \
|
|
patch.object(tts_tool, "prefers_gateway", return_value=False), \
|
|
patch.object(tts_tool, "resolve_openai_audio_api_key", return_value=""), \
|
|
patch.object(tts_tool, "resolve_managed_tool_gateway", return_value=None), \
|
|
patch.object(tts_tool, "managed_nous_tools_enabled", return_value=False):
|
|
with pytest.raises(ValueError) as exc:
|
|
tts_tool._resolve_openai_audio_client_config()
|
|
|
|
assert (
|
|
str(exc.value)
|
|
== "Neither tts.openai.api_key in config nor VOICE_TOOLS_OPENAI_KEY/OPENAI_API_KEY is set"
|
|
)
|
|
|
|
def test_config_api_key_counts_as_available_backend(self):
|
|
config = {"openai": {"api_key": "cfg-key"}}
|
|
with patch.object(tts_tool, "_load_tts_config", return_value=config):
|
|
assert tts_tool._has_openai_audio_backend() is True
|