mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
131 lines
4.5 KiB
Python
131 lines
4.5 KiB
Python
"""Tests for the KittenTTS local provider in tools/tts_tool.py."""
|
|
|
|
import json
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def clean_env(monkeypatch):
|
|
for key in ("HERMES_SESSION_PLATFORM",):
|
|
monkeypatch.delenv(key, raising=False)
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def clear_kittentts_cache():
|
|
"""Reset the module-level model cache between tests."""
|
|
from tools import tts_tool as _tt
|
|
_tt._kittentts_model_cache.clear()
|
|
yield
|
|
_tt._kittentts_model_cache.clear()
|
|
|
|
|
|
@pytest.fixture
|
|
def mock_kittentts_module():
|
|
"""Inject a fake kittentts + soundfile module that return stub objects."""
|
|
fake_model = MagicMock()
|
|
# 24kHz float32 PCM at ~2s of silence
|
|
fake_model.generate.return_value = [0.0] * 48000
|
|
fake_cls = MagicMock(return_value=fake_model)
|
|
fake_kittentts = MagicMock()
|
|
fake_kittentts.KittenTTS = fake_cls
|
|
|
|
# Stub soundfile — the real package isn't installed in CI venv, and
|
|
# _generate_kittentts does `import soundfile as sf` at runtime.
|
|
fake_sf = MagicMock()
|
|
def _fake_write(path, audio, samplerate):
|
|
# Emulate writing a real file so downstream path checks succeed.
|
|
import pathlib
|
|
pathlib.Path(path).write_bytes(b"RIFF\x00\x00\x00\x00WAVEfmt fake")
|
|
fake_sf.write = _fake_write
|
|
|
|
with patch.dict(
|
|
"sys.modules",
|
|
{"kittentts": fake_kittentts, "soundfile": fake_sf},
|
|
):
|
|
yield fake_model, fake_cls
|
|
|
|
|
|
class TestGenerateKittenTts:
|
|
def test_successful_wav_generation(self, tmp_path, mock_kittentts_module):
|
|
from tools.tts_tool import _generate_kittentts
|
|
|
|
fake_model, fake_cls = mock_kittentts_module
|
|
output_path = str(tmp_path / "test.wav")
|
|
result = _generate_kittentts("Hello world", output_path, {})
|
|
|
|
assert result == output_path
|
|
assert (tmp_path / "test.wav").exists()
|
|
fake_cls.assert_called_once()
|
|
fake_model.generate.assert_called_once()
|
|
|
|
def test_config_passes_voice_speed_cleantext(self, tmp_path, mock_kittentts_module):
|
|
from tools.tts_tool import _generate_kittentts
|
|
|
|
fake_model, _ = mock_kittentts_module
|
|
config = {
|
|
"kittentts": {
|
|
"model": "KittenML/kitten-tts-mini-0.8",
|
|
"voice": "Luna",
|
|
"speed": 1.25,
|
|
"clean_text": False,
|
|
}
|
|
}
|
|
_generate_kittentts("Hi there", str(tmp_path / "out.wav"), config)
|
|
|
|
call_kwargs = fake_model.generate.call_args.kwargs
|
|
assert call_kwargs["voice"] == "Luna"
|
|
assert call_kwargs["speed"] == 1.25
|
|
assert call_kwargs["clean_text"] is False
|
|
|
|
|
|
def test_missing_kittentts_raises_import_error(self, tmp_path, monkeypatch):
|
|
"""When kittentts package is not installed, _import_kittentts raises."""
|
|
import sys
|
|
monkeypatch.setitem(sys.modules, "kittentts", None)
|
|
from tools.tts_tool import _generate_kittentts
|
|
|
|
with pytest.raises((ImportError, TypeError)):
|
|
_generate_kittentts("Hi", str(tmp_path / "out.wav"), {})
|
|
|
|
|
|
class TestCheckKittenttsAvailable:
|
|
def test_reports_available_when_package_present(self, monkeypatch):
|
|
import importlib.util
|
|
from tools.tts_tool import _check_kittentts_available
|
|
|
|
fake_spec = MagicMock()
|
|
monkeypatch.setattr(
|
|
importlib.util, "find_spec",
|
|
lambda name: fake_spec if name == "kittentts" else None,
|
|
)
|
|
assert _check_kittentts_available() is True
|
|
|
|
def test_reports_unavailable_when_package_missing(self, monkeypatch):
|
|
import importlib.util
|
|
from tools.tts_tool import _check_kittentts_available
|
|
|
|
monkeypatch.setattr(importlib.util, "find_spec", lambda name: None)
|
|
assert _check_kittentts_available() is False
|
|
|
|
|
|
class TestDispatcherBranch:
|
|
def test_kittentts_not_installed_returns_helpful_error(self, monkeypatch, tmp_path):
|
|
"""When provider=kittentts but package missing, return JSON error with setup hint."""
|
|
import sys
|
|
monkeypatch.setitem(sys.modules, "kittentts", None)
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
|
|
from tools.tts_tool import text_to_speech_tool
|
|
|
|
# Write a config telling it to use kittentts
|
|
import yaml
|
|
(tmp_path / "config.yaml").write_text(
|
|
yaml.safe_dump({"tts": {"provider": "kittentts"}})
|
|
)
|
|
|
|
result = json.loads(text_to_speech_tool(text="Hello"))
|
|
assert result["success"] is False
|
|
assert "kittentts" in result["error"].lower()
|
|
assert "hermes setup tts" in result["error"].lower()
|