mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
95 lines
3.2 KiB
Python
95 lines
3.2 KiB
Python
"""Tests for the class-level TTS .ogg container repair.
|
|
|
|
Root cause class (#57048, #54589, #57213, #58845, #14841, #45557, #57049):
|
|
several TTS backends silently write MP3/WAV bytes into a ``.ogg`` output
|
|
path (Edge only emits MP3; Piper writes WAV; xAI writes MP3; some
|
|
OpenAI-compatible servers ignore ``response_format="opus"``). Platforms
|
|
that require real Ogg/Opus for native voice bubbles (Telegram, Matrix,
|
|
Feishu, WhatsApp, Signal) then render a broken 0-second bubble.
|
|
|
|
Instead of per-provider fixes, ``text_to_speech_tool`` sniffs the magic
|
|
bytes once after synthesis and repairs the container centrally.
|
|
"""
|
|
|
|
import struct
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from tools.tts_tool import (
|
|
OPUS_VOICE_PLATFORMS,
|
|
_repair_ogg_container,
|
|
_sniff_audio_container,
|
|
)
|
|
|
|
MP3_ID3 = b"ID3\x04\x00\x00\x00\x00\x00\x00" + b"\x00" * 64
|
|
MP3_FRAME = b"\xff\xfb\x90\x00" + b"\x00" * 64
|
|
OGG = b"OggS\x00\x02" + b"\x00" * 64
|
|
FLAC = b"fLaC" + b"\x00" * 64
|
|
|
|
|
|
def _wav_bytes() -> bytes:
|
|
return b"RIFF" + struct.pack("<I", 36) + b"WAVE" + b"\x00" * 64
|
|
|
|
|
|
class TestSniffAudioContainer:
|
|
@pytest.mark.parametrize(
|
|
"data,expected",
|
|
[
|
|
(MP3_ID3, "mp3"),
|
|
(MP3_FRAME, "mp3"),
|
|
(OGG, "ogg"),
|
|
(FLAC, "flac"),
|
|
],
|
|
)
|
|
def test_magic_bytes(self, tmp_path, data, expected):
|
|
p = tmp_path / "a.bin"
|
|
p.write_bytes(data)
|
|
assert _sniff_audio_container(str(p)) == expected
|
|
|
|
|
|
def test_unknown_and_missing(self, tmp_path):
|
|
p = tmp_path / "a.bin"
|
|
p.write_bytes(b"\x00\x01\x02\x03" * 8)
|
|
assert _sniff_audio_container(str(p)) == "unknown"
|
|
assert _sniff_audio_container(str(tmp_path / "missing")) == "unknown"
|
|
|
|
|
|
class TestRepairOggContainer:
|
|
def test_real_ogg_untouched(self, tmp_path):
|
|
p = tmp_path / "v.ogg"
|
|
p.write_bytes(OGG)
|
|
assert _repair_ogg_container(str(p)) == str(p)
|
|
assert p.read_bytes() == OGG
|
|
|
|
|
|
def test_ffmpeg_real_transcode_if_available(self, tmp_path):
|
|
"""Live ffmpeg round-trip when the binary exists (skipped otherwise)."""
|
|
import shutil as _shutil
|
|
import subprocess as _sp
|
|
|
|
if not _shutil.which("ffmpeg"):
|
|
pytest.skip("ffmpeg not installed")
|
|
# Synthesize a real tiny mp3 with ffmpeg, misname it .ogg
|
|
p = tmp_path / "v.ogg"
|
|
_sp.run(
|
|
["ffmpeg", "-f", "lavfi", "-i", "sine=frequency=440:duration=0.3",
|
|
"-acodec", "libmp3lame", "-f", "mp3", str(p), "-y"],
|
|
capture_output=True, check=True,
|
|
)
|
|
assert _sniff_audio_container(str(p)) == "mp3"
|
|
result = _repair_ogg_container(str(p))
|
|
assert result == str(p)
|
|
assert _sniff_audio_container(str(p)) == "ogg"
|
|
|
|
|
|
class TestOpusPlatformSet:
|
|
def test_opus_platforms_cover_voice_bubble_platforms(self):
|
|
# Behavior contract: the platforms whose adapters deliver native
|
|
# voice bubbles only for Ogg/Opus must be recognized.
|
|
for platform in ("telegram", "matrix", "feishu", "whatsapp", "signal"):
|
|
assert platform in OPUS_VOICE_PLATFORMS
|
|
|
|
def test_cli_not_included(self):
|
|
assert "" not in OPUS_VOICE_PLATFORMS
|
|
assert "cli" not in OPUS_VOICE_PLATFORMS
|