mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
74 lines
2.6 KiB
Python
74 lines
2.6 KiB
Python
"""Regression tests for inaccessible-cwd fallback (#65583).
|
|
|
|
``/root`` leaking into a non-root gateway/cron process's terminal cwd used to
|
|
kill every command with ``PermissionError: [Errno 13] Permission denied:
|
|
'/root'`` — ``os.path.isdir('/root')`` is True for a non-root user (stat only
|
|
needs search permission on ``/``), so the old existence-only check in
|
|
``_resolve_safe_cwd`` happily returned a directory ``subprocess.Popen`` could
|
|
not enter. The fix checks X_OK and falls back to the nearest usable ancestor.
|
|
"""
|
|
|
|
import os
|
|
import sys
|
|
import tempfile
|
|
|
|
import pytest
|
|
|
|
from tools.environments.local import LocalEnvironment, _cwd_usable, _resolve_safe_cwd
|
|
|
|
|
|
@pytest.fixture
|
|
def denied_dir(tmp_path):
|
|
"""A directory that exists but cannot be entered (simulates /root)."""
|
|
d = tmp_path / "rootlike"
|
|
d.mkdir()
|
|
d.chmod(0)
|
|
yield d
|
|
d.chmod(0o755) # so pytest can clean up
|
|
|
|
|
|
needs_posix_perms = pytest.mark.skipif(
|
|
sys.platform == "win32" or os.geteuid() == 0,
|
|
reason="chmod-based access denial needs POSIX + non-root",
|
|
)
|
|
|
|
|
|
@needs_posix_perms
|
|
class TestInaccessibleCwdFallback:
|
|
def test_cwd_usable_rejects_unenterable_directory(self, denied_dir):
|
|
assert os.path.isdir(denied_dir) # the trap: stat succeeds
|
|
assert _cwd_usable(str(denied_dir)) is False
|
|
|
|
|
|
def test_resolve_safe_cwd_climbs_past_denied_ancestor(self, denied_dir, tmp_path):
|
|
missing_child = str(denied_dir / "sub" / "dir")
|
|
resolved = _resolve_safe_cwd(missing_child)
|
|
assert os.access(resolved, os.X_OK)
|
|
assert resolved == str(tmp_path)
|
|
|
|
def test_local_environment_survives_denied_cwd(self, denied_dir):
|
|
"""The #65583 shape: env constructed with an unenterable cwd must
|
|
still execute commands instead of raising PermissionError."""
|
|
env = LocalEnvironment(cwd=str(denied_dir), timeout=30)
|
|
try:
|
|
handle = env._run_bash("echo ALIVE")
|
|
out = handle.stdout.read() if handle.stdout else b""
|
|
rc = handle.wait(timeout=15)
|
|
assert rc == 0
|
|
assert b"ALIVE" in (out if isinstance(out, bytes) else out.encode())
|
|
finally:
|
|
try:
|
|
env.cleanup()
|
|
except Exception:
|
|
pass
|
|
|
|
|
|
class TestUsableCwdBehaviorUnchanged:
|
|
def test_existing_accessible_cwd_returned_verbatim(self, tmp_path):
|
|
assert _resolve_safe_cwd(str(tmp_path)) == str(tmp_path)
|
|
|
|
|
|
def test_hopeless_path_falls_back_to_tempdir(self):
|
|
# A path whose every component is missing outside any real tree.
|
|
resolved = _resolve_safe_cwd("")
|
|
assert resolved == tempfile.gettempdir()
|