mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
43 lines
1.6 KiB
Python
43 lines
1.6 KiB
Python
"""Tool-surface cwd contract tests for gateway workspaces.
|
|
|
|
These cover the platform-neutral part of #29265: once the gateway has resolved
|
|
``TERMINAL_CWD``, the user-visible tool surfaces should agree on that workspace.
|
|
|
|
Unlike the system-prompt readers fixed in the gateway-cwd-resolver cluster
|
|
(agent/runtime_cwd.py), these tool sites already read ``TERMINAL_CWD``-first and
|
|
were deliberately left out of scope. This file is a *characterization* guard: it
|
|
pins the already-correct behavior so the supersession of PR #29365 is airtight
|
|
and a future refactor of these sites can't silently regress the contract.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
from tools import code_execution_tool, file_tools, terminal_tool
|
|
|
|
|
|
def test_terminal_env_config_uses_terminal_cwd(monkeypatch, tmp_path):
|
|
"""The terminal tool's default cwd should come from TERMINAL_CWD."""
|
|
workspace = tmp_path / "workspace"
|
|
workspace.mkdir()
|
|
|
|
monkeypatch.setenv("TERMINAL_ENV", "local")
|
|
monkeypatch.setenv("TERMINAL_CWD", str(workspace))
|
|
|
|
config = terminal_tool._get_env_config()
|
|
|
|
assert config["cwd"] == str(workspace)
|
|
|
|
|
|
def test_execute_code_project_mode_falls_back_when_terminal_cwd_missing(monkeypatch, tmp_path):
|
|
"""Invalid TERMINAL_CWD should not break execute_code project mode startup."""
|
|
staging = tmp_path / "staging"
|
|
staging.mkdir()
|
|
|
|
monkeypatch.setenv("TERMINAL_CWD", str(tmp_path / "missing"))
|
|
|
|
resolved = code_execution_tool._resolve_child_cwd("project", str(staging))
|
|
|
|
assert Path(resolved).is_dir()
|
|
assert Path(resolved) != tmp_path / "missing"
|