mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
86 lines
3.6 KiB
Python
86 lines
3.6 KiB
Python
"""Regression tests for profile-aware tilde expansion in file tools.
|
|
|
|
The bug (#48552): in-process file tools (write_file, read_file, patch,
|
|
search_files) resolved ``~`` via ``os.path.expanduser()``, which reads the
|
|
gateway process's ``HOME``. In profile mode (Docker, systemd, s6) the gateway
|
|
``HOME`` differs from the profile ``HOME`` that interactive sessions use, so
|
|
``~`` expanded to the wrong directory and file operations failed with
|
|
"no such file or directory".
|
|
|
|
The fix adds ``_expand_tilde()`` which delegates to
|
|
``hermes_constants.get_subprocess_home()`` — the same policy the terminal tool
|
|
uses for subprocess environments.
|
|
|
|
See: https://github.com/NousResearch/hermes-agent/issues/48552
|
|
"""
|
|
|
|
import os
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
import tools.file_tools as ft
|
|
import tools.terminal_tool as terminal_tool
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _expand_tilde() unit tests
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestExpandTilde:
|
|
"""Verify the _expand_tilde() helper resolves ~ to the profile home."""
|
|
|
|
def test_tilde_expands_to_profile_home(self):
|
|
"""When get_subprocess_home returns a value, ~/path uses it."""
|
|
with patch("hermes_constants.get_subprocess_home", return_value="/opt/data/profiles/coder/home"):
|
|
result = ft._expand_tilde("~/scratch/file.txt")
|
|
assert result == "/opt/data/profiles/coder/home/scratch/file.txt"
|
|
|
|
|
|
def test_empty_path_unchanged(self):
|
|
"""Empty string returns empty."""
|
|
with patch("hermes_constants.get_subprocess_home", return_value="/opt/data/profiles/coder/home"):
|
|
assert ft._expand_tilde("") == ""
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Integration: _resolve_path_for_task uses profile home
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestResolvePathUsesProfileHome:
|
|
"""Verify _resolve_path_for_task resolves ~ to the profile home."""
|
|
|
|
def test_relative_tilde_resolves_to_profile_home(self, tmp_path, monkeypatch):
|
|
"""A ~/path argument resolves under the profile home, not process HOME."""
|
|
profile_home = tmp_path / "profile_home"
|
|
profile_home.mkdir()
|
|
process_home = tmp_path / "process_home"
|
|
process_home.mkdir()
|
|
|
|
monkeypatch.setenv("HOME", str(process_home))
|
|
monkeypatch.setattr(terminal_tool, "_session_cwd", {})
|
|
|
|
with patch("hermes_constants.get_subprocess_home", return_value=str(profile_home)):
|
|
resolved = ft._resolve_path_for_task("~/test_file.txt", task_id="test")
|
|
|
|
assert str(resolved).startswith(str(profile_home))
|
|
assert "process_home" not in str(resolved)
|
|
|
|
def test_absolute_tilde_in_workspace_root(self, tmp_path, monkeypatch):
|
|
"""A workspace root specified with ~ resolves to profile home."""
|
|
profile_home = tmp_path / "profile_home"
|
|
profile_home.mkdir()
|
|
process_home = tmp_path / "process_home"
|
|
process_home.mkdir()
|
|
|
|
monkeypatch.setenv("HOME", str(process_home))
|
|
monkeypatch.setattr(terminal_tool, "_session_cwd", {})
|
|
|
|
with patch("hermes_constants.get_subprocess_home", return_value=str(profile_home)):
|
|
# _resolve_base_dir uses the workspace root from config; if it contains ~,
|
|
# it should resolve to profile home
|
|
resolved = ft._resolve_path_for_task("~/data/config.json", task_id="test")
|
|
|
|
assert str(profile_home) in str(resolved)
|
|
assert str(process_home) not in str(resolved)
|