mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
48 lines
1.6 KiB
Python
48 lines
1.6 KiB
Python
"""Tests for tools.environments.docker.find_docker — Docker CLI discovery."""
|
|
|
|
import os
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from tools.environments import docker as docker_mod
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_cache():
|
|
"""Clear the module-level docker executable cache between tests."""
|
|
docker_mod._docker_executable = None
|
|
yield
|
|
docker_mod._docker_executable = None
|
|
|
|
|
|
class TestFindDocker:
|
|
def test_found_via_shutil_which(self):
|
|
with patch("tools.environments.docker.shutil.which", return_value="/usr/bin/docker"):
|
|
result = docker_mod.find_docker()
|
|
assert result == "/usr/bin/docker"
|
|
|
|
def test_not_in_path_falls_back_to_known_locations(self, tmp_path):
|
|
# Create a fake docker binary at a known path
|
|
fake_docker = tmp_path / "docker"
|
|
fake_docker.write_text("#!/bin/sh\n")
|
|
fake_docker.chmod(0o755)
|
|
|
|
with patch("tools.environments.docker.shutil.which", return_value=None), \
|
|
patch("tools.environments.docker._DOCKER_SEARCH_PATHS", [str(fake_docker)]):
|
|
result = docker_mod.find_docker()
|
|
assert result == str(fake_docker)
|
|
|
|
|
|
def test_docker_preferred_over_podman(self):
|
|
"""When both docker and podman are on PATH, docker wins."""
|
|
def which_side_effect(name):
|
|
if name == "docker":
|
|
return "/usr/bin/docker"
|
|
if name == "podman":
|
|
return "/usr/bin/podman"
|
|
return None
|
|
|
|
with patch("tools.environments.docker.shutil.which", side_effect=which_side_effect):
|
|
result = docker_mod.find_docker()
|
|
assert result == "/usr/bin/docker"
|