mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
106 lines
3.4 KiB
Python
106 lines
3.4 KiB
Python
"""Regression: the async-delegation ledger must close every SQLite connection.
|
|
|
|
Sibling of the cron execution-ledger leak (#69567 / PR #69594). The durable
|
|
delegation ledger used ``with _connect() as conn:`` where the connection
|
|
context manager commits/rolls back but never closes, leaking the db/-wal/-shm
|
|
file descriptors on every dispatch, completion, and delivery-claim. These tests
|
|
fail if the deterministic ``close()`` is ever removed again.
|
|
"""
|
|
|
|
import queue
|
|
import sqlite3
|
|
|
|
import pytest
|
|
|
|
from tools import async_delegation as ad
|
|
|
|
|
|
class _TrackingConnection:
|
|
"""Delegates to a real sqlite3.Connection while recording close() calls.
|
|
|
|
sqlite3.Connection is a static C type: it has no per-instance __dict__ and
|
|
its methods can't be monkeypatched, so open/close tracking is done via a
|
|
delegating wrapper returned in place of the real connection.
|
|
"""
|
|
|
|
def __init__(self, real, closed_ids):
|
|
object.__setattr__(self, "_real", real)
|
|
object.__setattr__(self, "_closed_ids", closed_ids)
|
|
|
|
def close(self):
|
|
self._closed_ids.append(id(self._real))
|
|
self._real.close()
|
|
|
|
def __enter__(self):
|
|
self._real.__enter__()
|
|
return self
|
|
|
|
def __exit__(self, exc_type, exc, tb):
|
|
return self._real.__exit__(exc_type, exc, tb)
|
|
|
|
def __getattr__(self, name):
|
|
return getattr(self._real, name)
|
|
|
|
def __setattr__(self, name, value):
|
|
setattr(self._real, name, value)
|
|
|
|
|
|
def _point_ledger(monkeypatch, tmp_path):
|
|
monkeypatch.setattr(ad, "_db_path", lambda: tmp_path / "state.db")
|
|
return ad
|
|
|
|
|
|
def _track_connections(monkeypatch):
|
|
opened, closed = [], []
|
|
real_connect = sqlite3.connect
|
|
|
|
def tracking_connect(*args, **kwargs):
|
|
conn = real_connect(*args, **kwargs)
|
|
opened.append(id(conn))
|
|
return _TrackingConnection(conn, closed)
|
|
|
|
monkeypatch.setattr(ad.sqlite3, "connect", tracking_connect)
|
|
return opened, closed
|
|
|
|
|
|
def test_ledger_operations_close_every_connection(monkeypatch, tmp_path):
|
|
"""Public durable-ledger reads/writes must close every connection opened."""
|
|
_point_ledger(monkeypatch, tmp_path)
|
|
opened, closed = _track_connections(monkeypatch)
|
|
|
|
ad.get_durable_delegation("nope")
|
|
ad.recover_abandoned_delegations()
|
|
ad.restore_undelivered_completions(queue.Queue())
|
|
ad.mark_completion_delivered("nope")
|
|
ad.claim_completion_delivery("nope", "claim-1")
|
|
|
|
assert opened, "expected at least one connection to be opened"
|
|
assert len(opened) == len(closed)
|
|
assert set(opened) == set(closed)
|
|
|
|
|
|
def test_schema_init_failure_still_closes_connection(monkeypatch, tmp_path):
|
|
"""A PRAGMA/DDL failure after connect() must still close the connection."""
|
|
_point_ledger(monkeypatch, tmp_path)
|
|
opened, closed = [], []
|
|
real_connect = sqlite3.connect
|
|
|
|
class _FailingSchemaConnection(_TrackingConnection):
|
|
def execute(self, sql, *args, **kwargs):
|
|
if "CREATE TABLE" in sql:
|
|
raise sqlite3.OperationalError("simulated schema init failure")
|
|
return self._real.execute(sql, *args, **kwargs)
|
|
|
|
def tracking_connect(*args, **kwargs):
|
|
conn = real_connect(*args, **kwargs)
|
|
opened.append(id(conn))
|
|
return _FailingSchemaConnection(conn, closed)
|
|
|
|
monkeypatch.setattr(ad.sqlite3, "connect", tracking_connect)
|
|
|
|
with pytest.raises(sqlite3.OperationalError):
|
|
with ad._transaction():
|
|
pass
|
|
|
|
assert len(opened) == 1
|
|
assert len(closed) == 1
|