mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-31 19:16:29 +00:00
39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
168 lines
4.8 KiB
Python
168 lines
4.8 KiB
Python
"""Comprehensive tests for ANSI escape sequence stripping (ECMA-48).
|
|
|
|
The strip_ansi function in tools/ansi_strip.py is the source-level fix for
|
|
ANSI codes leaking into the model's context via terminal/execute_code output.
|
|
It must strip ALL terminal escape sequences while preserving legitimate text.
|
|
"""
|
|
|
|
from tools.ansi_strip import sanitize_display_text, strip_ansi
|
|
|
|
|
|
class TestStripAnsiBasicSGR:
|
|
"""Select Graphic Rendition — the most common ANSI sequences."""
|
|
|
|
def test_reset(self):
|
|
assert strip_ansi("\x1b[0m") == ""
|
|
|
|
|
|
def test_truecolor_colon_separated(self):
|
|
"""Modern terminals use colon-separated SGR params."""
|
|
assert strip_ansi("\x1b[38:2:255:0:0m") == ""
|
|
assert strip_ansi("\x1b[48:2:0:255:0m") == ""
|
|
|
|
|
|
class TestStripAnsiCSIPrivateMode:
|
|
"""CSI sequences with ? prefix (DEC private modes)."""
|
|
|
|
def test_cursor_show_hide(self):
|
|
assert strip_ansi("\x1b[?25h") == ""
|
|
assert strip_ansi("\x1b[?25l") == ""
|
|
|
|
|
|
def test_bracketed_paste(self):
|
|
assert strip_ansi("\x1b[?2004h") == ""
|
|
|
|
|
|
class TestStripAnsiCSIIntermediate:
|
|
"""CSI sequences with intermediate bytes (space, etc.)."""
|
|
|
|
def test_cursor_shape(self):
|
|
assert strip_ansi("\x1b[0 q") == ""
|
|
assert strip_ansi("\x1b[2 q") == ""
|
|
assert strip_ansi("\x1b[6 q") == ""
|
|
|
|
|
|
class TestStripAnsiOSC:
|
|
"""Operating System Command sequences."""
|
|
|
|
def test_bel_terminator(self):
|
|
assert strip_ansi("\x1b]0;title\x07") == ""
|
|
|
|
|
|
def test_hyperlink_preserves_text(self):
|
|
assert strip_ansi(
|
|
"\x1b]8;;https://example.com\x1b\\click\x1b]8;;\x1b\\"
|
|
) == "click"
|
|
|
|
|
|
class TestStripAnsiDECPrivate:
|
|
"""DEC private / Fp escape sequences."""
|
|
|
|
def test_save_restore_cursor(self):
|
|
assert strip_ansi("\x1b7") == ""
|
|
assert strip_ansi("\x1b8") == ""
|
|
|
|
def test_keypad_modes(self):
|
|
assert strip_ansi("\x1b=") == ""
|
|
assert strip_ansi("\x1b>") == ""
|
|
|
|
|
|
class TestStripAnsiFe:
|
|
"""Fe (C1 as 7-bit) escape sequences."""
|
|
|
|
def test_reverse_index(self):
|
|
assert strip_ansi("\x1bM") == ""
|
|
|
|
|
|
def test_index_and_newline(self):
|
|
assert strip_ansi("\x1bD") == ""
|
|
assert strip_ansi("\x1bE") == ""
|
|
|
|
|
|
class TestStripAnsiNF:
|
|
"""nF (character set selection) sequences."""
|
|
|
|
def test_charset_selection(self):
|
|
assert strip_ansi("\x1b(A") == ""
|
|
assert strip_ansi("\x1b(B") == ""
|
|
assert strip_ansi("\x1b(0") == ""
|
|
|
|
|
|
class TestStripAnsiDCS:
|
|
"""Device Control String sequences."""
|
|
|
|
def test_dcs(self):
|
|
assert strip_ansi("\x1bP+q\x1b\\") == ""
|
|
|
|
|
|
class TestStripAnsi8BitC1:
|
|
"""8-bit C1 control characters."""
|
|
|
|
def test_8bit_csi(self):
|
|
assert strip_ansi("\x9b31m") == ""
|
|
assert strip_ansi("\x9b38;2;255;0;0m") == ""
|
|
|
|
def test_8bit_standalone(self):
|
|
assert strip_ansi("\x9c") == ""
|
|
assert strip_ansi("\x9d") == ""
|
|
assert strip_ansi("\x90") == ""
|
|
|
|
|
|
class TestStripAnsiRealWorld:
|
|
"""Real-world contamination scenarios from bug reports."""
|
|
|
|
def test_colored_shebang(self):
|
|
"""The original reported bug: shebang corrupted by color codes."""
|
|
assert strip_ansi(
|
|
"\x1b[32m#!/usr/bin/env python3\x1b[0m\nprint('hello')"
|
|
) == "#!/usr/bin/env python3\nprint('hello')"
|
|
|
|
|
|
def test_ansi_mid_code(self):
|
|
assert strip_ansi(
|
|
"def foo(\x1b[33m):\x1b[0m\n return 42"
|
|
) == "def foo():\n return 42"
|
|
|
|
|
|
class TestStripAnsiPassthrough:
|
|
"""Clean content must pass through unmodified."""
|
|
|
|
def test_plain_text(self):
|
|
assert strip_ansi("normal text") == "normal text"
|
|
|
|
def test_empty(self):
|
|
assert strip_ansi("") == ""
|
|
|
|
|
|
def test_square_brackets_in_code(self):
|
|
"""Array indexing must not be confused with CSI."""
|
|
code = "arr[0] = arr[31]"
|
|
assert strip_ansi(code) == code
|
|
|
|
|
|
class TestSanitizeDisplayText:
|
|
"""sanitize_display_text — escape sequences AND bare control chars.
|
|
|
|
Port of the openai/codex#31494 bug class: stored/untrusted text
|
|
replayed into a terminal UI (e.g. the /resume recap) must not be able
|
|
to clear the screen, retitle the window, or corrupt adjacent output.
|
|
"""
|
|
|
|
def test_csi_removed(self):
|
|
assert sanitize_display_text("a\x1b[2Jb") == "ab"
|
|
|
|
def test_osc_title_removed(self):
|
|
assert sanitize_display_text("x\x1b]0;pwned\x07y") == "xy"
|
|
|
|
|
|
def test_empty(self):
|
|
assert sanitize_display_text("") == ""
|
|
|
|
def test_codex_31494_fixture(self):
|
|
"""The exact input shape from openai/codex#31494's test."""
|
|
raw = "_count_r\x1b[13;2:3uows\tindent\n\x00two\x7f"
|
|
assert sanitize_display_text(raw) == "_count_rows\tindent\ntwo"
|
|
|
|
def test_mixed_escape_and_controls(self):
|
|
raw = "hello \x1b[2J\x1b]0;pwned\x07 world \x9b31m red\x07"
|
|
assert sanitize_display_text(raw) == "hello world red"
|