mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
92 lines
2.6 KiB
Python
92 lines
2.6 KiB
Python
"""Unit tests for docker/tini-shim.sh argument stripping (#66679).
|
|
|
|
These run without Docker: the shim's HERMES_TINI_SHIM_TARGET /
|
|
HERMES_TINI_SHIM_WRAPPER hooks let us record the argv that would be
|
|
handed to /init.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import subprocess
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parents[1]
|
|
SHIM = REPO_ROOT / "docker" / "tini-shim.sh"
|
|
|
|
|
|
@pytest.fixture
|
|
def recorder(tmp_path: Path) -> tuple[Path, Path]:
|
|
"""Fake /init + wrapper that print argv, one token per line."""
|
|
init = tmp_path / "fake-init"
|
|
wrapper = tmp_path / "fake-wrapper"
|
|
init.write_text("#!/bin/sh\nprintf '%s\\n' \"$@\"\n")
|
|
wrapper.write_text("#!/bin/sh\nprintf 'wrapper\\n'\n")
|
|
init.chmod(0o755)
|
|
wrapper.chmod(0o755)
|
|
return init, wrapper
|
|
|
|
|
|
def _run_shim(
|
|
recorder: tuple[Path, Path],
|
|
args: list[str],
|
|
) -> subprocess.CompletedProcess[str]:
|
|
init, wrapper = recorder
|
|
env = os.environ.copy()
|
|
env["HERMES_TINI_SHIM_TARGET"] = str(init)
|
|
env["HERMES_TINI_SHIM_WRAPPER"] = str(wrapper)
|
|
return subprocess.run(
|
|
["sh", str(SHIM), *args],
|
|
capture_output=True,
|
|
text=True,
|
|
timeout=10,
|
|
env=env,
|
|
check=False,
|
|
)
|
|
|
|
|
|
def test_shim_script_is_executable_bit_friendly() -> None:
|
|
assert SHIM.is_file()
|
|
text = SHIM.read_text()
|
|
assert text.startswith("#!/bin/sh")
|
|
assert "HERMES_TINI_SHIM_TARGET" in text
|
|
|
|
|
|
def test_strips_g_and_double_dash(recorder: tuple[Path, Path]) -> None:
|
|
"""Legacy `tini -g -- gateway run` must not forward `-g` to /init."""
|
|
r = _run_shim(recorder, ["-g", "--", "gateway", "run"])
|
|
assert r.returncode == 0, r.stderr
|
|
lines = [ln for ln in r.stdout.splitlines() if ln]
|
|
init, wrapper = recorder
|
|
assert lines[0] == str(wrapper)
|
|
assert lines[1:] == ["gateway", "run"]
|
|
assert "-g" not in lines
|
|
assert "--" not in lines
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_does_not_double_wrap_existing_wrapper(
|
|
recorder: tuple[Path, Path],
|
|
) -> None:
|
|
_, wrapper = recorder
|
|
r = _run_shim(recorder, ["-g", "--", str(wrapper), "gateway", "run"])
|
|
assert r.returncode == 0, r.stderr
|
|
lines = [ln for ln in r.stdout.splitlines() if ln]
|
|
assert lines == [str(wrapper), "gateway", "run"]
|
|
|
|
|
|
def test_strips_p_and_e_with_arguments(recorder: tuple[Path, Path]) -> None:
|
|
r = _run_shim(
|
|
recorder,
|
|
["-p", "SIGKILL", "-e", "143", "-v", "-v", "--", "sleep", "infinity"],
|
|
)
|
|
assert r.returncode == 0, r.stderr
|
|
lines = [ln for ln in r.stdout.splitlines() if ln]
|
|
_, wrapper = recorder
|
|
assert lines == [str(wrapper), "sleep", "infinity"]
|
|
assert "SIGKILL" not in lines
|
|
assert "143" not in lines
|