mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-07-30 19:09:28 +00:00
6b81590c55
Systematic prune per AGENTS.md test policy, one pass over every major test tree (gateway, hermes_cli, tools, agent, run_agent, plugins, cli, cron, tui_gateway, honcho/openviking, root-level): - DELETE: source-reading tests (read_text/getsource on prod files), change-detector tests (exact catalog counts, model-name snapshots, config version literals), mock-echo tests (assert a mock returns what it was told), assertion-free/trivial tests, near-duplicate parametrizations (boundaries + one representative kept), async/sync twin duplicates, cosmetic within-file variations. - KEEP (mandatory): security/redaction/approval guards, message-role alternation invariants, prompt-caching/deterministic-call-id invariants, issue-number regression tests (deduped), E2E tests. - 6 test files deleted outright (script-style/no-assert or fully redundant); conftest.py, fakes/, fixtures/ untouched. - tests/acp/conftest.py added: autouse fixture stubs the live models.dev/GitHub/Copilot/Anthropic inventory fetches that ACP server tests performed on every session create — test_server.py 147s → 3.4s, and the tests are now genuinely hermetic. - Sleep-based slowness shrunk where safe (codex_ttfb_watchdog, compression_concurrent_fork, etc.); no wall-clock assertion tightened. Verification: full hermetic suite via scripts/run_tests.sh — 2439 files, 31,130 tests passed, 0 failed, 0 flaky retries, 315s wall (baseline: 583s wall, 13,564s subprocess CPU).
115 lines
3.4 KiB
Python
115 lines
3.4 KiB
Python
import json
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import web_server
|
|
|
|
|
|
class FakeBridge:
|
|
def __init__(self):
|
|
self.alive = True
|
|
|
|
def read(self, timeout):
|
|
return b"" # idle forever
|
|
|
|
def write(self, data):
|
|
pass
|
|
|
|
def resize(self, cols, rows):
|
|
pass
|
|
|
|
def close(self):
|
|
self.alive = False
|
|
|
|
|
|
@pytest.fixture
|
|
def pty_keepalive_harness(monkeypatch):
|
|
spawned = []
|
|
|
|
def fake_spawn(argv, cwd=None, env=None):
|
|
b = FakeBridge()
|
|
spawned.append(argv)
|
|
return b
|
|
|
|
monkeypatch.setattr(web_server.PtyBridge, "spawn", staticmethod(fake_spawn))
|
|
monkeypatch.setattr(web_server, "_ws_auth_reason", lambda ws: (None, "test"))
|
|
monkeypatch.setattr(web_server, "_ws_host_origin_reason", lambda ws: None)
|
|
monkeypatch.setattr(web_server, "_ws_client_reason", lambda ws: None)
|
|
|
|
async def fake_argv(**kw):
|
|
resume = "child" if kw.get("resume") == "parent" else kw.get("resume")
|
|
env = {"HERMES_TUI_RESUME": resume} if resume else {}
|
|
return (["x", resume or "fresh"], "/tmp", env)
|
|
|
|
monkeypatch.setattr(web_server, "_resolve_chat_argv_async", fake_argv)
|
|
|
|
try:
|
|
yield spawned
|
|
finally:
|
|
web_server.PTY_REGISTRY._sessions.clear()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_attach_token_reuses_same_session(pty_keepalive_harness):
|
|
"""Two connects with the same ?attach= token hit one spawned bridge."""
|
|
from starlette.testclient import TestClient
|
|
|
|
client = TestClient(web_server.app)
|
|
with client.websocket_connect("/api/pty?attach=TOK1") as ws1:
|
|
ws1.send_bytes(b"hi")
|
|
with client.websocket_connect("/api/pty?attach=TOK1") as ws2:
|
|
ws2.send_bytes(b"again")
|
|
assert len(pty_keepalive_harness) == 1 # reattached, did not respawn
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_attach_token_reuses_same_resume(pty_keepalive_harness):
|
|
from starlette.testclient import TestClient
|
|
|
|
client = TestClient(web_server.app)
|
|
with client.websocket_connect("/api/pty?attach=TOK1&resume=same") as ws1:
|
|
ws1.send_bytes(b"hi")
|
|
with client.websocket_connect("/api/pty?attach=TOK1&resume=same") as ws2:
|
|
ws2.send_bytes(b"again")
|
|
assert pty_keepalive_harness == [["x", "same"]]
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_attach_token_reuses_canonical_resume(pty_keepalive_harness):
|
|
from starlette.testclient import TestClient
|
|
|
|
client = TestClient(web_server.app)
|
|
with client.websocket_connect("/api/pty?attach=TOK1&resume=parent") as ws1:
|
|
ws1.send_bytes(b"hi")
|
|
with client.websocket_connect("/api/pty?attach=TOK1&resume=child") as ws2:
|
|
ws2.send_bytes(b"again")
|
|
assert pty_keepalive_harness == [["x", "child"]]
|
|
|
|
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_attach_token_reuses_default_chat_after_active_session_fallback(
|
|
pty_keepalive_harness, tmp_path, monkeypatch
|
|
):
|
|
from starlette.testclient import TestClient
|
|
|
|
active_session_file = tmp_path / "active-session.json"
|
|
monkeypatch.setattr(
|
|
web_server,
|
|
"_active_session_file_for_channel",
|
|
lambda app, channel: active_session_file,
|
|
)
|
|
|
|
client = TestClient(web_server.app)
|
|
with client.websocket_connect("/api/pty?attach=TOK1&channel=CHAT") as ws1:
|
|
ws1.send_bytes(b"hi")
|
|
|
|
active_session_file.write_text(json.dumps({"session_id": "existing"}))
|
|
|
|
with client.websocket_connect("/api/pty?attach=TOK1&channel=CHAT") as ws2:
|
|
ws2.send_bytes(b"again")
|
|
|
|
assert pty_keepalive_harness == [["x", "fresh"]]
|